ivooskamp/backupchecks
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Allow admins to view screenshots of deleted feedback items

Browse Source 
Two fixes:
1. Improved deleted item row styling (opacity + background)
2. Allow feedback_attachment route to serve images from deleted items (admin only)

Before: Screenshots shown as links only (2026-02-10_13_29_39.png)
After: Screenshots shown as images/thumbnails

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Ivo Oskamp 2026-02-10 13:46:24 +01:00
parent fc99f17db3
commit 0510613708
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
containers/backupchecks/src/backend/app/main/routes_feedback.py
View File

@ -489,9 +489,11 @@ def feedback_attachment(attachment_id: int):
"""Serve a feedback attachment image.""" """Serve a feedback attachment image."""
attachment = FeedbackAttachment.query.get_or_404(attachment_id) attachment = FeedbackAttachment.query.get_or_404(attachment_id)
# Check if the feedback item is deleted # Check if the feedback item is deleted - allow admins to view
item = FeedbackItem.query.get(attachment.feedback_item_id) item = FeedbackItem.query.get(attachment.feedback_item_id)
if not item or item.deleted_at is not None: if not item:
abort(404)
if item.deleted_at is not None and get_active_role() != "admin":
abort(404) abort(404)
# Serve the image # Serve the image

2
containers/backupchecks/src/templates/main/feedback.html
View File

@ -69,7 +69,7 @@
{% endif %} {% endif %}
{% for i in items %} {% for i in items %}
<tr {% if i.is_deleted %}class="table-secondary"{% endif %}> <tr {% if i.is_deleted %}style="opacity: 0.6; background-color: var(--bs-secondary-bg);"{% endif %}>
<td> <td>
{% if not i.is_deleted %} {% if not i.is_deleted %}
<form method="post" action="{{ url_for('main.feedback_vote', item_id=i.id) }}"> <form method="post" action="{{ url_for('main.feedback_vote', item_id=i.id) }}">