From e3303681e1cd58dc48b942f449889d814063109d Mon Sep 17 00:00:00 2001 From: Ivo Oskamp Date: Tue, 3 Feb 2026 11:06:35 +0100 Subject: [PATCH] Auto-commit local changes before build (2026-02-03 11:06:35) --- .last-branch | 2 +- .../src/templates/main/run_checks.html | 17 +++++++++++------ docs/changelog.md | 6 ++++++ 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/.last-branch b/.last-branch index 36e7b9e..dc149a9 100644 --- a/.last-branch +++ b/.last-branch @@ -1 +1 @@ -v20260203-01-autotask-resolve-note +v20260203-02-autotask-resolve-button-enabled diff --git a/containers/backupchecks/src/templates/main/run_checks.html b/containers/backupchecks/src/templates/main/run_checks.html index eda46b2..1039a44 100644 --- a/containers/backupchecks/src/templates/main/run_checks.html +++ b/containers/backupchecks/src/templates/main/run_checks.html @@ -913,8 +913,6 @@ table.addEventListener('change', function (e) { function setDisabled(disabled) { if (btnAutotask) btnAutotask.disabled = disabled; - if (btnAutotaskResolveNote) btnAutotaskResolveNote.disabled = disabled; - if (btnAutotaskLink) btnAutotaskLink.disabled = disabled; if (btnTicket) btnTicket.disabled = disabled; if (tCode) tCode.disabled = disabled; if (btnRemark) btnRemark.disabled = disabled; @@ -972,6 +970,9 @@ table.addEventListener('change', function (e) { // Resolve note is only meaningful when there is an active linked PSA ticket. btnAutotaskResolveNote.style.display = (hasTicket && !isResolved && !isDeleted) ? '' : 'none'; } + if (btnAutotaskLink) btnAutotaskLink.disabled = !currentRunId; + if (btnAutotaskResolveNote) btnAutotaskResolveNote.disabled = !currentRunId; + } window.__rcmRenderAutotaskInfo = renderAutotaskInfo; @@ -1290,11 +1291,15 @@ table.addEventListener('change', function (e) { if (window.__rcmRenderAutotaskInfo) window.__rcmRenderAutotaskInfo(run); if (window.__rcmSetAutotaskCreateLabel) window.__rcmSetAutotaskCreateLabel(run); if (window.__rcmSetCreateDisabled) { + // Only disable inputs when no run is selected. + window.__rcmSetCreateDisabled(!currentRunId); + if (autotaskEnabled) { - var canCreateAt = !!currentRunId && (!run.autotask_ticket_id || !!run.autotask_ticket_is_resolved); - window.__rcmSetCreateDisabled(!canCreateAt); - } else { - window.__rcmSetCreateDisabled(!currentRunId); + // Autotask ticket creation is only possible when there is no active linked PSA ticket, + // or when the existing PSA ticket is already resolved/deleted. + var canCreateAt = !!currentRunId && (!run.autotask_ticket_id || !!run.autotask_ticket_is_resolved || !!run.autotask_ticket_is_deleted); + var btnAutotask = document.getElementById('rcm_autotask_create'); + if (btnAutotask) btnAutotask.disabled = !canCreateAt; } } if (btnMarkSuccessOverride) { diff --git a/docs/changelog.md b/docs/changelog.md index 22958ce..3ea71dd 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -465,6 +465,12 @@ Changes: - Added backend API endpoint to handle the resolve-note action. - Extended Autotask client with a helper to update existing tickets via PUT. +## v20260203-02-autotask-resolve-button-enabled + +- Fixed an issue where the Autotask Resolve button was incorrectly disabled. +- Updated UI disable logic so only the Create action is disabled when an active Autotask ticket exists. +- Ensured the Resolve button remains clickable for existing linked Autotask tickets. + *** ## v0.1.21