.last-branch

@@ -1 +1 @@
-v20260101-07-run-checks-shift-multiselect-delegation-fix
+v20260101-06-run-checks-shift-multiselect-fix

containers/backupchecks/src/templates/main/run_checks.html

@@ -286,9 +286,6 @@
 
     var btnMarkAllReviewed = document.getElementById('rcm_mark_all_reviewed');
 
-    // Shift-click range selection for checkbox rows
-    var lastCheckedCb = null;
-
     function statusClass(status) {
       var s = (status || "").toString().toLowerCase();
 
@@ -351,18 +348,9 @@
       if (btnMark) btnMark.disabled = ids.length === 0;
       if (btnUnmark) btnUnmark.disabled = ids.length === 0;
       if (statusEl) statusEl.textContent = ids.length ? (ids.length + ' selected') : '';
-      refreshSelectAll();
     }
 
-    function refreshSelectAll() {
-      if (!selectAll) return;
-      var cbs = table.querySelectorAll('tbody .rc_row_cb');
-      var total = cbs.length;
-      var checked = 0;
-      cbs.forEach(function (cb) { if (cb.checked) checked++; });
-      selectAll.indeterminate = checked > 0 && checked < total;
-      selectAll.checked = total > 0 && checked === total;
-    }
+    var lastRowCheckbox = null;
 
     if (selectAll) {
       selectAll.addEventListener('change', function () {
@@ -372,67 +360,47 @@
       });
     }
 
-// Prevent browser text selection when using Shift with checkbox selection
-table.addEventListener('mousedown', function (e) {
-  var t = e.target;
-  if (!t) return;
-  if (t.classList && t.classList.contains('rc_row_cb') && e.shiftKey) {
-    e.preventDefault();
-    if (window.getSelection) {
-      try { window.getSelection().removeAllRanges(); } catch (err) {}
-    }
-  }
-}, true);
+    // Shift-click multi select for row checkboxes (continuous range)
+    table.addEventListener('click', function (e) {
+      if (!(e.target && e.target.classList && e.target.classList.contains('rc_row_cb'))) return;
 
-// Handle Shift-click range selection on the checkbox inputs (delegated)
-table.addEventListener('click', function (e) {
-  var t = e.target;
-  if (!t || !(t.classList && t.classList.contains('rc_row_cb'))) return;
-
-  // Custom handling so we can reliably read shiftKey and control the toggle + range
-  if (e.shiftKey && lastCheckedCb && lastCheckedCb !== t) {
-    e.preventDefault();
+      // Prevent row click handlers and stop the browser from doing text-range selection.
       e.stopPropagation();
 
-    // The default action would toggle the checkbox; do it manually
-    var targetChecked = !t.checked;
-    t.checked = targetChecked;
-
+      // If shift is held, apply the checkbox state to the whole range.
+      if (e.shiftKey && lastRowCheckbox && lastRowCheckbox !== e.target) {
         var cbs = Array.prototype.slice.call(table.querySelectorAll('tbody .rc_row_cb'));
-    var start = cbs.indexOf(lastCheckedCb);
-    var end = cbs.indexOf(t);
+        var start = cbs.indexOf(lastRowCheckbox);
+        var end = cbs.indexOf(e.target);
 
         if (start !== -1 && end !== -1) {
-      var lo = Math.min(start, end);
-      var hi = Math.max(start, end);
-      for (var i = lo; i <= hi; i++) {
-        cbs[i].checked = targetChecked;
+          var min = Math.min(start, end);
+          var max = Math.max(start, end);
+          var state = e.target.checked;
+
+          for (var i = min; i <= max; i++) {
+            cbs[i].checked = state;
+          }
         }
       }
 
-    if (window.getSelection) {
-      try { window.getSelection().removeAllRanges(); } catch (err) {}
-    }
+      lastRowCheckbox = e.target;
+
+      // Clear any accidental text selection caused by Shift-click.
+      try {
+        var sel = window.getSelection ? window.getSelection() : null;
+        if (sel && sel.removeAllRanges) sel.removeAllRanges();
+      } catch (err) {}
 
       updateButtons();
-    lastCheckedCb = t;
-    return;
-  }
+    });
 
-  // Normal click: let default toggle happen, but remember the last checkbox
-  lastCheckedCb = t;
-
-  // Defer update until after the checkbox state changes
-  setTimeout(updateButtons, 0);
-}, true);
-
-// Fallback for keyboard toggles (space) and other state changes
-table.addEventListener('change', function (e) {
+    // Fallback: any checkbox change should still update the buttons.
+    table.addEventListener('change', function (e) {
       if (e.target && e.target.classList && e.target.classList.contains('rc_row_cb')) {
-    lastCheckedCb = e.target;
         updateButtons();
       }
-});
+    });
 
     function postJson(url, body) {
       return fetch(url, {

docs/changelog.md

@@ -142,15 +142,6 @@
 - Implemented tracking of the last selected checkbox to enable continuous range selection.
 - Ensured multiselect only applies to checkbox interactions and not table row text.
 
----
-
-## v20260101-07-run-checks-shift-multiselect-delegation-fix
-
-- Reworked Shift-click multiselect on the Run Checks page using event delegation.
-- Ensured checkbox range selection works correctly with dynamically rendered table rows.
-- Disabled default browser text selection when using Shift during checkbox interaction.
-- Applied Gmail-style range selection logic for consistent multi-row selection behavior.
-
 ================================================================================================================================================
 ## v0.1.14
 

temp.md

@@ -0,0 +1 @@
+left empty