Compare commits
No commits in common. "main" and "v0.1.16" have entirely different histories.
@ -1 +1 @@
|
||||
v20260113-08-vspc-object-linking-normalize
|
||||
v20260104-20-changelog-0-1-16
|
||||
|
||||
@ -7,4 +7,3 @@ python-dateutil==2.9.0.post0
|
||||
gunicorn==23.0.0
|
||||
requests==2.32.3
|
||||
reportlab==4.2.5
|
||||
Markdown==3.6
|
||||
|
||||
@ -18,9 +18,8 @@ from ..models import User
|
||||
auth_bp = Blueprint("auth", __name__, url_prefix="/auth")
|
||||
|
||||
|
||||
def users_exist() -> bool:
|
||||
# Initial setup should only run on a fresh install where NO users exist yet.
|
||||
return db.session.query(User.id).first() is not None
|
||||
def admin_exists() -> bool:
|
||||
return db.session.query(User.id).filter_by(role="admin").first() is not None
|
||||
|
||||
|
||||
def generate_captcha():
|
||||
@ -56,7 +55,7 @@ def captcha_required(func):
|
||||
@captcha_required
|
||||
def login():
|
||||
if request.method == "GET":
|
||||
if not users_exist():
|
||||
if not admin_exists():
|
||||
return redirect(url_for("auth.initial_setup"))
|
||||
|
||||
question, answer = generate_captcha()
|
||||
@ -99,8 +98,8 @@ def logout():
|
||||
|
||||
@auth_bp.route("/initial-setup", methods=["GET", "POST"])
|
||||
def initial_setup():
|
||||
if users_exist():
|
||||
flash("Users already exist. Please log in.", "info")
|
||||
if admin_exists():
|
||||
flash("An admin user already exists. Please log in.", "info")
|
||||
return redirect(url_for("auth.login"))
|
||||
|
||||
if request.method == "POST":
|
||||
|
||||
@ -7,7 +7,7 @@ from datetime import datetime
|
||||
from .admin_logging import log_admin_event
|
||||
from .mail_importer import MailImportError, run_auto_import
|
||||
from .models import SystemSettings
|
||||
from .object_persistence import persist_objects_for_auto_run
|
||||
from .object_persistence import persist_objects_for_approved_run
|
||||
|
||||
|
||||
_AUTO_IMPORTER_THREAD_NAME = "auto_importer"
|
||||
@ -80,7 +80,7 @@ def start_auto_importer(app) -> None:
|
||||
persisted_errors = 0
|
||||
for (customer_id, job_id, run_id, mail_message_id) in auto_approved_runs:
|
||||
try:
|
||||
persisted_objects += persist_objects_for_auto_run(
|
||||
persisted_objects += persist_objects_for_approved_run(
|
||||
int(customer_id), int(job_id), int(run_id), int(mail_message_id)
|
||||
)
|
||||
except Exception as exc:
|
||||
|
||||
@ -3,7 +3,6 @@ from __future__ import annotations
|
||||
from email import policy
|
||||
from email.parser import BytesParser
|
||||
from email.utils import parseaddr
|
||||
import re
|
||||
from typing import List, Optional, Tuple
|
||||
|
||||
|
||||
@ -126,42 +125,3 @@ def extract_best_html_from_eml(
|
||||
return None
|
||||
_fn, html_text = items[0]
|
||||
return html_text or None
|
||||
|
||||
|
||||
def is_effectively_blank_html(value: str | None) -> bool:
|
||||
"""Return True when an HTML body is effectively empty.
|
||||
|
||||
Some sources produce Graph bodies that are non-empty strings but contain only
|
||||
an empty HTML skeleton (e.g. <html><body></body></html>) or whitespace.
|
||||
In those cases we want to treat the body as empty so we can fall back to an
|
||||
HTML report attachment stored in the EML.
|
||||
"""
|
||||
if value is None:
|
||||
return True
|
||||
if not isinstance(value, str):
|
||||
return False
|
||||
|
||||
raw = value.strip()
|
||||
if raw == "":
|
||||
return True
|
||||
|
||||
# Fast path: if we clearly have content-bearing elements, it is not blank.
|
||||
# (This avoids false positives for report-like HTML.)
|
||||
if re.search(r"<(table|img|svg|pre|ul|ol|li|iframe|object|embed)\b", raw, re.IGNORECASE):
|
||||
return False
|
||||
|
||||
# Try to isolate the body content; if no body tag is present, evaluate the full string.
|
||||
m = re.search(r"<body\b[^>]*>(.*?)</body>", raw, re.IGNORECASE | re.DOTALL)
|
||||
body = m.group(1) if m else raw
|
||||
|
||||
# Remove comments, scripts, and styles.
|
||||
body = re.sub(r"<!--.*?-->", "", body, flags=re.DOTALL)
|
||||
body = re.sub(r"<script\b[^>]*>.*?</script>", "", body, flags=re.IGNORECASE | re.DOTALL)
|
||||
body = re.sub(r"<style\b[^>]*>.*?</style>", "", body, flags=re.IGNORECASE | re.DOTALL)
|
||||
|
||||
# Strip tags and common non-breaking whitespace entities.
|
||||
text = re.sub(r"<[^>]+>", "", body)
|
||||
text = text.replace(" ", " ").replace("\xa0", " ")
|
||||
text = re.sub(r"\s+", "", text)
|
||||
|
||||
return text == ""
|
||||
|
||||
@ -68,53 +68,4 @@ def find_matching_job(msg: MailMessage) -> Optional[Job]:
|
||||
if len(matches) == 1:
|
||||
return matches[0]
|
||||
|
||||
# Backwards-compatible matching for Veeam VSPC Active Alarms summary per-company jobs.
|
||||
# Earlier versions could store company names with slightly different whitespace / HTML entities,
|
||||
# while parsers store objects using a normalized company prefix. When the exact match fails,
|
||||
# try a normalized company comparison so existing jobs continue to match.
|
||||
try:
|
||||
bsw = (backup or "").strip().lower()
|
||||
bt = (btype or "").strip().lower()
|
||||
jn = (job_name or "").strip()
|
||||
if bsw == "veeam" and bt == "service provider console" and "|" in jn:
|
||||
left, right = [p.strip() for p in jn.split("|", 1)]
|
||||
if left.lower() == "active alarms summary" and right:
|
||||
from .parsers.veeam import normalize_vspc_company_name # lazy import
|
||||
|
||||
target_company = normalize_vspc_company_name(right)
|
||||
if not target_company:
|
||||
return None
|
||||
|
||||
q2 = Job.query
|
||||
if norm_from is None:
|
||||
q2 = q2.filter(Job.from_address.is_(None))
|
||||
else:
|
||||
q2 = q2.filter(Job.from_address == norm_from)
|
||||
q2 = q2.filter(Job.backup_software == backup)
|
||||
q2 = q2.filter(Job.backup_type == btype)
|
||||
q2 = q2.filter(Job.job_name.ilike("Active alarms summary | %"))
|
||||
|
||||
# Load a small set of candidates and compare the company portion.
|
||||
candidates = q2.order_by(Job.updated_at.desc(), Job.id.desc()).limit(25).all()
|
||||
normalized_matches: list[Job] = []
|
||||
for cand in candidates:
|
||||
cand_name = (cand.job_name or "").strip()
|
||||
if "|" not in cand_name:
|
||||
continue
|
||||
c_left, c_right = [p.strip() for p in cand_name.split("|", 1)]
|
||||
if c_left.lower() != "active alarms summary" or not c_right:
|
||||
continue
|
||||
if normalize_vspc_company_name(c_right) == target_company:
|
||||
normalized_matches.append(cand)
|
||||
|
||||
if len(normalized_matches) > 1:
|
||||
customer_ids = {m.customer_id for m in normalized_matches}
|
||||
if len(customer_ids) == 1:
|
||||
return normalized_matches[0]
|
||||
return None
|
||||
if len(normalized_matches) == 1:
|
||||
return normalized_matches[0]
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
return None
|
||||
|
||||
@ -11,10 +11,9 @@ import requests
|
||||
from sqlalchemy import func
|
||||
|
||||
from . import db
|
||||
from .models import MailMessage, SystemSettings, Job, JobRun, MailObject
|
||||
from .models import MailMessage, SystemSettings, Job, JobRun
|
||||
from .parsers import parse_mail_message
|
||||
from .parsers.veeam import extract_vspc_active_alarms_companies
|
||||
from .email_utils import normalize_from_address, extract_best_html_from_eml, is_effectively_blank_html
|
||||
from .email_utils import normalize_from_address, extract_best_html_from_eml
|
||||
from .job_matching import find_matching_job
|
||||
|
||||
|
||||
@ -229,15 +228,9 @@ def _store_messages(settings: SystemSettings, messages):
|
||||
)
|
||||
|
||||
# Some systems send empty bodies and put the actual report in an HTML attachment.
|
||||
# Graph may still return a body that only contains whitespace/newlines; treat that
|
||||
# as empty so we can fall back to the attachment.
|
||||
def _is_blank_text(s):
|
||||
return s is None or (isinstance(s, str) and s.strip() == "")
|
||||
|
||||
# If we have raw EML bytes and no meaningful body content, extract the first
|
||||
# HTML attachment and use it as the HTML body so parsers and the inbox preview
|
||||
# can work.
|
||||
if is_effectively_blank_html(mail.html_body) and _is_blank_text(mail.text_body) and mail.eml_blob:
|
||||
# If we have raw EML bytes and no body content, extract the first HTML attachment
|
||||
# and use it as the HTML body so parsers and the inbox preview can work.
|
||||
if not (mail.html_body or mail.text_body) and mail.eml_blob:
|
||||
attachment_html = extract_best_html_from_eml(mail.eml_blob)
|
||||
if attachment_html:
|
||||
mail.html_body = attachment_html
|
||||
@ -266,94 +259,6 @@ def _store_messages(settings: SystemSettings, messages):
|
||||
and getattr(mail, "parse_result", None) == "ok"
|
||||
and not bool(getattr(mail, "approved", False))
|
||||
):
|
||||
# Special case: Veeam VSPC "Active alarms summary" contains multiple companies.
|
||||
bsw = (getattr(mail, "backup_software", "") or "").strip().lower()
|
||||
btype = (getattr(mail, "backup_type", "") or "").strip().lower()
|
||||
jname = (getattr(mail, "job_name", "") or "").strip().lower()
|
||||
|
||||
if bsw == "veeam" and btype == "service provider console" and jname == "active alarms summary":
|
||||
raw = (mail.text_body or "").strip() or (mail.html_body or "")
|
||||
companies = extract_vspc_active_alarms_companies(raw)
|
||||
|
||||
if companies:
|
||||
def _is_error_status(value: str | None) -> bool:
|
||||
v = (value or "").strip().lower()
|
||||
return v in {"error", "failed", "critical"} or v.startswith("fail")
|
||||
|
||||
created_any = False
|
||||
first_job = None
|
||||
mapped_count = 0
|
||||
|
||||
for company in companies:
|
||||
# Build a temp message using the per-company job name
|
||||
tmp = MailMessage(
|
||||
from_address=mail.from_address,
|
||||
backup_software=mail.backup_software,
|
||||
backup_type=mail.backup_type,
|
||||
job_name=f"{(mail.job_name or 'Active alarms summary').strip()} | {company}".strip(),
|
||||
)
|
||||
job = find_matching_job(tmp)
|
||||
if not job:
|
||||
continue
|
||||
|
||||
# Respect per-job flags.
|
||||
if hasattr(job, "active") and not bool(job.active):
|
||||
continue
|
||||
if hasattr(job, "auto_approve") and not bool(job.auto_approve):
|
||||
continue
|
||||
|
||||
mapped_count += 1
|
||||
|
||||
objs = (
|
||||
MailObject.query.filter(MailObject.mail_message_id == mail.id)
|
||||
.filter(MailObject.object_name.ilike(f"{company} | %"))
|
||||
.all()
|
||||
)
|
||||
saw_error = any(_is_error_status(o.status) for o in objs)
|
||||
saw_warning = any((o.status or "").strip().lower() == "warning" for o in objs)
|
||||
status = "Error" if saw_error else ("Warning" if saw_warning else (mail.overall_status or "Success"))
|
||||
|
||||
run = JobRun(
|
||||
job_id=job.id,
|
||||
mail_message_id=mail.id,
|
||||
run_at=mail.received_at,
|
||||
status=status or None,
|
||||
missed=False,
|
||||
)
|
||||
|
||||
# Optional storage metrics
|
||||
if hasattr(run, "storage_used_bytes") and hasattr(mail, "storage_used_bytes"):
|
||||
run.storage_used_bytes = mail.storage_used_bytes
|
||||
if hasattr(run, "storage_capacity_bytes") and hasattr(mail, "storage_capacity_bytes"):
|
||||
run.storage_capacity_bytes = mail.storage_capacity_bytes
|
||||
if hasattr(run, "storage_free_bytes") and hasattr(mail, "storage_free_bytes"):
|
||||
run.storage_free_bytes = mail.storage_free_bytes
|
||||
if hasattr(run, "storage_free_percent") and hasattr(mail, "storage_free_percent"):
|
||||
run.storage_free_percent = mail.storage_free_percent
|
||||
|
||||
db.session.add(run)
|
||||
db.session.flush()
|
||||
|
||||
auto_approved_runs.append((job.customer_id, job.id, run.id, mail.id))
|
||||
created_any = True
|
||||
|
||||
if not first_job:
|
||||
first_job = job
|
||||
|
||||
# If all companies are mapped, mark the mail as fully approved and move to history.
|
||||
if created_any and mapped_count == len(companies):
|
||||
mail.job_id = first_job.id if first_job else None
|
||||
if hasattr(mail, "approved"):
|
||||
mail.approved = True
|
||||
if hasattr(mail, "approved_at"):
|
||||
mail.approved_at = datetime.utcnow()
|
||||
if hasattr(mail, "location"):
|
||||
mail.location = "history"
|
||||
auto_approved += 1
|
||||
|
||||
# Do not fall back to single-job matching for VSPC summary.
|
||||
continue
|
||||
|
||||
job = find_matching_job(mail)
|
||||
if job:
|
||||
# Respect per-job flags.
|
||||
@ -531,21 +436,6 @@ def run_auto_import(settings: SystemSettings):
|
||||
new_messages = 0
|
||||
auto_approved = 0
|
||||
auto_approved_runs = []
|
||||
# Never move messages when the import failed (prevents "moved but not stored" situations).
|
||||
processed_folder_id = None
|
||||
|
||||
# Ensure imported messages are committed before moving them to another folder.
|
||||
# If commit fails, do not move anything.
|
||||
if processed_folder_id and new_messages >= 0:
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
errors.append(f"Failed to commit imported messages: {exc}")
|
||||
new_messages = 0
|
||||
auto_approved = 0
|
||||
auto_approved_runs = []
|
||||
processed_folder_id = None
|
||||
|
||||
# Move messages to the processed folder if configured
|
||||
if processed_folder_id:
|
||||
@ -723,21 +613,6 @@ def run_manual_import(settings: SystemSettings, batch_size: int):
|
||||
errors.append(str(exc))
|
||||
new_messages = 0
|
||||
auto_approved_runs = []
|
||||
# Never move messages when the import failed (prevents "moved but not stored" situations).
|
||||
processed_folder_id = None
|
||||
|
||||
# Ensure imported messages are committed before moving them to another folder.
|
||||
# If commit fails, do not move anything.
|
||||
if processed_folder_id and new_messages >= 0:
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
errors.append(f"Failed to commit imported messages: {exc}")
|
||||
new_messages = 0
|
||||
auto_approved = 0
|
||||
auto_approved_runs = []
|
||||
processed_folder_id = None
|
||||
|
||||
# Move messages to the processed folder if configured
|
||||
if processed_folder_id:
|
||||
|
||||
Binary file not shown.
@ -10,7 +10,6 @@ from .routes_shared import main_bp, roles_required # noqa: F401
|
||||
from . import routes_core # noqa: F401
|
||||
from . import routes_news # noqa: F401
|
||||
from . import routes_inbox # noqa: F401
|
||||
from . import routes_mail_audit # noqa: F401
|
||||
from . import routes_customers # noqa: F401
|
||||
from . import routes_jobs # noqa: F401
|
||||
from . import routes_settings # noqa: F401
|
||||
|
||||
@ -1,135 +0,0 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
from .routes_shared import _format_datetime
|
||||
|
||||
|
||||
@main_bp.route("/admin/all-mail")
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
def admin_all_mail_page():
|
||||
# Pagination
|
||||
try:
|
||||
page = int(request.args.get("page", "1"))
|
||||
except ValueError:
|
||||
page = 1
|
||||
if page < 1:
|
||||
page = 1
|
||||
|
||||
per_page = 50
|
||||
|
||||
# Filters (AND combined)
|
||||
from_q = (request.args.get("from_q") or "").strip()
|
||||
subject_q = (request.args.get("subject_q") or "").strip()
|
||||
backup_q = (request.args.get("backup_q") or "").strip()
|
||||
type_q = (request.args.get("type_q") or "").strip()
|
||||
job_name_q = (request.args.get("job_name_q") or "").strip()
|
||||
received_from = (request.args.get("received_from") or "").strip()
|
||||
received_to = (request.args.get("received_to") or "").strip()
|
||||
only_unlinked = (request.args.get("only_unlinked") or "").strip().lower() in (
|
||||
"1",
|
||||
"true",
|
||||
"yes",
|
||||
"on",
|
||||
)
|
||||
|
||||
query = db.session.query(MailMessage).outerjoin(Job, MailMessage.job_id == Job.id)
|
||||
|
||||
if from_q:
|
||||
query = query.filter(MailMessage.from_address.ilike(f"%{from_q}%"))
|
||||
|
||||
if subject_q:
|
||||
query = query.filter(MailMessage.subject.ilike(f"%{subject_q}%"))
|
||||
|
||||
if backup_q:
|
||||
query = query.filter(MailMessage.backup_software.ilike(f"%{backup_q}%"))
|
||||
|
||||
if type_q:
|
||||
query = query.filter(MailMessage.backup_type.ilike(f"%{type_q}%"))
|
||||
|
||||
if job_name_q:
|
||||
# Prefer stored job_name, but also allow matching the linked Job name.
|
||||
query = query.filter(
|
||||
or_(
|
||||
MailMessage.job_name.ilike(f"%{job_name_q}%"),
|
||||
Job.name.ilike(f"%{job_name_q}%"),
|
||||
)
|
||||
)
|
||||
|
||||
if only_unlinked:
|
||||
query = query.filter(MailMessage.job_id.is_(None))
|
||||
|
||||
# Datetime window (received_at)
|
||||
# Use dateutil.parser when available, otherwise a simple ISO parse fallback.
|
||||
def _parse_dt(value: str):
|
||||
if not value:
|
||||
return None
|
||||
try:
|
||||
from dateutil import parser as dtparser # type: ignore
|
||||
|
||||
return dtparser.parse(value)
|
||||
except Exception:
|
||||
try:
|
||||
# Accept "YYYY-MM-DDTHH:MM" from datetime-local.
|
||||
return datetime.fromisoformat(value)
|
||||
except Exception:
|
||||
return None
|
||||
|
||||
dt_from = _parse_dt(received_from)
|
||||
dt_to = _parse_dt(received_to)
|
||||
|
||||
if dt_from is not None:
|
||||
query = query.filter(MailMessage.received_at >= dt_from)
|
||||
if dt_to is not None:
|
||||
query = query.filter(MailMessage.received_at <= dt_to)
|
||||
|
||||
total_items = query.count()
|
||||
total_pages = max(1, math.ceil(total_items / per_page)) if total_items else 1
|
||||
if page > total_pages:
|
||||
page = total_pages
|
||||
|
||||
messages = (
|
||||
query.order_by(
|
||||
MailMessage.received_at.desc().nullslast(),
|
||||
MailMessage.id.desc(),
|
||||
)
|
||||
.offset((page - 1) * per_page)
|
||||
.limit(per_page)
|
||||
.all()
|
||||
)
|
||||
|
||||
rows = []
|
||||
for msg in messages:
|
||||
rows.append(
|
||||
{
|
||||
"id": msg.id,
|
||||
"from_address": msg.from_address or "",
|
||||
"subject": msg.subject or "",
|
||||
"received_at": _format_datetime(msg.received_at),
|
||||
"backup_software": msg.backup_software or "",
|
||||
"backup_type": msg.backup_type or "",
|
||||
"job_name": (msg.job_name or "") or (msg.job.name if msg.job else ""),
|
||||
"linked": bool(msg.job_id),
|
||||
"has_eml": bool(getattr(msg, "eml_stored_at", None)),
|
||||
}
|
||||
)
|
||||
|
||||
has_prev = page > 1
|
||||
has_next = page < total_pages
|
||||
|
||||
return render_template(
|
||||
"main/admin_all_mail.html",
|
||||
rows=rows,
|
||||
page=page,
|
||||
total_pages=total_pages,
|
||||
has_prev=has_prev,
|
||||
has_next=has_next,
|
||||
filters={
|
||||
"from_q": from_q,
|
||||
"subject_q": subject_q,
|
||||
"backup_q": backup_q,
|
||||
"type_q": type_q,
|
||||
"job_name_q": job_name_q,
|
||||
"received_from": received_from,
|
||||
"received_to": received_to,
|
||||
"only_unlinked": only_unlinked,
|
||||
},
|
||||
)
|
||||
@ -1,6 +1,5 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
from .routes_shared import _format_datetime, _get_ui_timezone_name, _to_amsterdam_date
|
||||
import re
|
||||
from .routes_shared import _format_datetime, _get_ui_timezone_name, _next_ticket_code, _to_amsterdam_date
|
||||
|
||||
@main_bp.route("/api/job-runs/<int:run_id>/alerts")
|
||||
@login_required
|
||||
@ -22,19 +21,14 @@ def api_job_run_alerts(run_id: int):
|
||||
db.session.execute(
|
||||
text(
|
||||
"""
|
||||
SELECT t.id,
|
||||
t.ticket_code,
|
||||
t.description,
|
||||
t.start_date,
|
||||
COALESCE(ts.resolved_at, t.resolved_at) AS resolved_at,
|
||||
t.active_from_date
|
||||
SELECT t.id, t.ticket_code, t.description, t.start_date, t.resolved_at, t.active_from_date
|
||||
FROM tickets t
|
||||
JOIN ticket_scopes ts ON ts.ticket_id = t.id
|
||||
WHERE ts.job_id = :job_id
|
||||
AND t.active_from_date <= :run_date
|
||||
AND (
|
||||
COALESCE(ts.resolved_at, t.resolved_at) IS NULL
|
||||
OR ((COALESCE(ts.resolved_at, t.resolved_at) AT TIME ZONE 'UTC' AT TIME ZONE :ui_tz)::date) >= :run_date
|
||||
t.resolved_at IS NULL
|
||||
OR ((t.resolved_at AT TIME ZONE 'UTC' AT TIME ZONE :ui_tz)::date) >= :run_date
|
||||
)
|
||||
ORDER BY t.start_date DESC
|
||||
"""
|
||||
@ -174,7 +168,7 @@ def api_tickets():
|
||||
"active_from_date": str(getattr(t, "active_from_date", "") or ""),
|
||||
"start_date": _format_datetime(t.start_date),
|
||||
"resolved_at": _format_datetime(t.resolved_at) if t.resolved_at else "",
|
||||
"active": (t.resolved_at is None and TicketScope.query.filter_by(ticket_id=t.id, resolved_at=None).first() is not None),
|
||||
"active": t.resolved_at is None,
|
||||
}
|
||||
)
|
||||
return jsonify({"status": "ok", "tickets": items})
|
||||
@ -184,7 +178,7 @@ def api_tickets():
|
||||
return jsonify({"status": "error", "message": "Forbidden."}), 403
|
||||
|
||||
payload = request.get_json(silent=True) or {}
|
||||
description = None # Description removed from New ticket UI; use remarks for additional context
|
||||
description = (payload.get("description") or "").strip() or None
|
||||
try:
|
||||
run_id = int(payload.get("job_run_id") or 0)
|
||||
except Exception:
|
||||
@ -200,68 +194,36 @@ def api_tickets():
|
||||
job = Job.query.get(run.job_id) if run else None
|
||||
|
||||
now = datetime.utcnow()
|
||||
ticket_code = (payload.get("ticket_code") or "").strip().upper()
|
||||
code = _next_ticket_code(now)
|
||||
|
||||
if not ticket_code:
|
||||
return jsonify({"status": "error", "message": "ticket_code is required."}), 400
|
||||
|
||||
# Validate format: TYYYYMMDD.####
|
||||
if not re.match(r"^T\d{8}\.\d{4}$", ticket_code):
|
||||
return jsonify({"status": "error", "message": "Invalid ticket_code format. Expected TYYYYMMDD.####."}), 400
|
||||
|
||||
existing = Ticket.query.filter_by(ticket_code=ticket_code).first()
|
||||
is_new = existing is None
|
||||
|
||||
# Create new ticket if it doesn't exist; otherwise reuse the existing one so the same
|
||||
# ticket number can be linked to multiple jobs and job runs.
|
||||
if existing:
|
||||
ticket = existing
|
||||
else:
|
||||
ticket = Ticket(
|
||||
ticket_code=ticket_code,
|
||||
title=None,
|
||||
description=description,
|
||||
active_from_date=_to_amsterdam_date(run.run_at) or _to_amsterdam_date(now) or now.date(),
|
||||
start_date=now,
|
||||
resolved_at=None,
|
||||
)
|
||||
ticket = Ticket(
|
||||
ticket_code=code,
|
||||
title=None,
|
||||
description=description,
|
||||
active_from_date=_to_amsterdam_date(run.run_at) or _to_amsterdam_date(now) or now.date(),
|
||||
start_date=now,
|
||||
resolved_at=None,
|
||||
)
|
||||
|
||||
try:
|
||||
if is_new:
|
||||
db.session.add(ticket)
|
||||
db.session.flush()
|
||||
db.session.add(ticket)
|
||||
db.session.flush()
|
||||
|
||||
# Ensure a scope exists for this job so alerts/popups can show the ticket code.
|
||||
scope = None
|
||||
if job and job.id:
|
||||
scope = TicketScope.query.filter_by(ticket_id=ticket.id, scope_type="job", job_id=job.id).first()
|
||||
# Minimal scope from job
|
||||
scope = TicketScope(
|
||||
ticket_id=ticket.id,
|
||||
scope_type="job",
|
||||
customer_id=job.customer_id if job else None,
|
||||
backup_software=job.backup_software if job else None,
|
||||
backup_type=job.backup_type if job else None,
|
||||
job_id=job.id if job else None,
|
||||
job_name_match=job.job_name if job else None,
|
||||
job_name_match_mode="exact",
|
||||
)
|
||||
db.session.add(scope)
|
||||
|
||||
if not scope:
|
||||
scope = TicketScope(
|
||||
ticket_id=ticket.id,
|
||||
scope_type="job",
|
||||
customer_id=job.customer_id if job else None,
|
||||
backup_software=job.backup_software if job else None,
|
||||
backup_type=job.backup_type if job else None,
|
||||
job_id=job.id if job else None,
|
||||
job_name_match=job.job_name if job else None,
|
||||
job_name_match_mode="exact",
|
||||
resolved_at=None,
|
||||
)
|
||||
db.session.add(scope)
|
||||
else:
|
||||
# Re-open this ticket for this job if it was previously resolved for this scope.
|
||||
scope.resolved_at = None
|
||||
scope.customer_id = job.customer_id if job else scope.customer_id
|
||||
scope.backup_software = job.backup_software if job else scope.backup_software
|
||||
scope.backup_type = job.backup_type if job else scope.backup_type
|
||||
scope.job_name_match = job.job_name if job else scope.job_name_match
|
||||
scope.job_name_match_mode = "exact"
|
||||
|
||||
# Link ticket to this job run (idempotent)
|
||||
if not TicketJobRun.query.filter_by(ticket_id=ticket.id, job_run_id=run.id).first():
|
||||
link = TicketJobRun(ticket_id=ticket.id, job_run_id=run.id, link_source="manual")
|
||||
db.session.add(link)
|
||||
link = TicketJobRun(ticket_id=ticket.id, job_run_id=run.id, link_source="manual")
|
||||
db.session.add(link)
|
||||
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
@ -288,8 +250,21 @@ def api_tickets():
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def api_ticket_update(ticket_id: int):
|
||||
# Editing tickets is not allowed. Resolve the old ticket and create a new one instead.
|
||||
return jsonify({"status": "error", "message": "Ticket editing is disabled. Resolve the old ticket and create a new one."}), 405
|
||||
if get_active_role() not in ("admin", "operator"):
|
||||
return jsonify({"status": "error", "message": "Forbidden."}), 403
|
||||
|
||||
ticket = Ticket.query.get_or_404(ticket_id)
|
||||
payload = request.get_json(silent=True) or {}
|
||||
if "description" in payload:
|
||||
ticket.description = (payload.get("description") or "").strip() or None
|
||||
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
return jsonify({"status": "error", "message": str(exc) or "Failed to update ticket."}), 500
|
||||
|
||||
return jsonify({"status": "ok"})
|
||||
|
||||
|
||||
@main_bp.route("/api/tickets/<int:ticket_id>/resolve", methods=["POST"])
|
||||
@ -300,68 +275,9 @@ def api_ticket_resolve(ticket_id: int):
|
||||
return jsonify({"status": "error", "message": "Forbidden."}), 403
|
||||
|
||||
ticket = Ticket.query.get_or_404(ticket_id)
|
||||
now = datetime.utcnow()
|
||||
|
||||
payload = request.get_json(silent=True) if request.is_json else {}
|
||||
try:
|
||||
run_id = int((payload or {}).get("job_run_id") or 0)
|
||||
except Exception:
|
||||
run_id = 0
|
||||
|
||||
# Job-scoped resolve (from popups / job details): resolve only for the job of the provided job_run_id
|
||||
if run_id > 0:
|
||||
run = JobRun.query.get(run_id)
|
||||
if not run:
|
||||
return jsonify({"status": "error", "message": "Job run not found."}), 404
|
||||
|
||||
job = Job.query.get(run.job_id) if run else None
|
||||
job_id = job.id if job else None
|
||||
|
||||
try:
|
||||
scope = None
|
||||
if job_id:
|
||||
scope = TicketScope.query.filter_by(ticket_id=ticket.id, scope_type="job", job_id=job_id).first()
|
||||
|
||||
if not scope:
|
||||
scope = TicketScope(
|
||||
ticket_id=ticket.id,
|
||||
scope_type="job",
|
||||
customer_id=job.customer_id if job else None,
|
||||
backup_software=job.backup_software if job else None,
|
||||
backup_type=job.backup_type if job else None,
|
||||
job_id=job_id,
|
||||
job_name_match=job.job_name if job else None,
|
||||
job_name_match_mode="exact",
|
||||
resolved_at=now,
|
||||
)
|
||||
db.session.add(scope)
|
||||
else:
|
||||
if scope.resolved_at is None:
|
||||
scope.resolved_at = now
|
||||
|
||||
# Keep the audit link to the run (idempotent)
|
||||
if not TicketJobRun.query.filter_by(ticket_id=ticket.id, job_run_id=run.id).first():
|
||||
db.session.add(TicketJobRun(ticket_id=ticket.id, job_run_id=run.id, link_source="manual"))
|
||||
|
||||
# If all scopes are resolved, also resolve the ticket globally (so the central list shows it as resolved)
|
||||
open_scope = TicketScope.query.filter_by(ticket_id=ticket.id, resolved_at=None).first()
|
||||
if open_scope is None and ticket.resolved_at is None:
|
||||
ticket.resolved_at = now
|
||||
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
return jsonify({"status": "error", "message": str(exc) or "Failed to resolve ticket."}), 500
|
||||
|
||||
return jsonify({"status": "ok", "resolved_at": _format_datetime(now)})
|
||||
|
||||
# Global resolve (from central ticket list): resolve ticket and all scopes
|
||||
if ticket.resolved_at is None:
|
||||
ticket.resolved_at = now
|
||||
|
||||
ticket.resolved_at = datetime.utcnow()
|
||||
try:
|
||||
# Resolve any still-open scopes
|
||||
TicketScope.query.filter_by(ticket_id=ticket.id, resolved_at=None).update({"resolved_at": now})
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
@ -370,9 +286,11 @@ def api_ticket_resolve(ticket_id: int):
|
||||
# If this endpoint is called from a regular HTML form submit (e.g. Tickets/Remarks page),
|
||||
# redirect back instead of showing raw JSON in the browser.
|
||||
if not request.is_json and "application/json" not in (request.headers.get("Accept") or ""):
|
||||
return redirect(request.referrer or url_for("main.tickets"))
|
||||
return redirect(request.referrer or url_for("main.tickets_page"))
|
||||
|
||||
return jsonify({"status": "ok", "resolved_at": _format_datetime(ticket.resolved_at)})
|
||||
|
||||
|
||||
return jsonify({"status": "ok", "resolved_at": _format_datetime(now)})
|
||||
@main_bp.route("/api/tickets/<int:ticket_id>/link-run", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
@ -502,8 +420,21 @@ def api_remarks():
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def api_remark_update(remark_id: int):
|
||||
# Editing remarks is not allowed. Resolve the old remark and create a new one instead.
|
||||
return jsonify({"status": "error", "message": "Remark editing is disabled. Resolve the old remark and create a new one."}), 405
|
||||
if get_active_role() not in ("admin", "operator"):
|
||||
return jsonify({"status": "error", "message": "Forbidden."}), 403
|
||||
|
||||
remark = Remark.query.get_or_404(remark_id)
|
||||
payload = request.get_json(silent=True) or {}
|
||||
if "body" in payload:
|
||||
remark.body = (payload.get("body") or "").strip() or ""
|
||||
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
return jsonify({"status": "error", "message": str(exc) or "Failed to update remark."}), 500
|
||||
|
||||
return jsonify({"status": "ok"})
|
||||
|
||||
|
||||
@main_bp.route("/api/remarks/<int:remark_id>/resolve", methods=["POST"])
|
||||
@ -558,4 +489,4 @@ def api_remark_link_run(remark_id: int):
|
||||
db.session.rollback()
|
||||
return jsonify({"status": "error", "message": str(exc) or "Failed to link run."}), 500
|
||||
|
||||
return jsonify({"status": "ok"})
|
||||
return jsonify({"status": "ok"})
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@ -100,15 +100,6 @@ def customers_delete(customer_id: int):
|
||||
customer = Customer.query.get_or_404(customer_id)
|
||||
|
||||
try:
|
||||
# Prevent FK violations and keep historical reporting intact.
|
||||
# Jobs are not deleted when removing a customer; they are simply unlinked.
|
||||
Job.query.filter_by(customer_id=customer.id).update({"customer_id": None})
|
||||
|
||||
# Ticket/remark scoping rows can reference customers directly (FK),
|
||||
# so remove those links first to allow the customer to be deleted.
|
||||
TicketScope.query.filter_by(customer_id=customer.id).delete(synchronize_session=False)
|
||||
RemarkScope.query.filter_by(customer_id=customer.id).delete(synchronize_session=False)
|
||||
|
||||
db.session.delete(customer)
|
||||
db.session.commit()
|
||||
flash("Customer deleted.", "success")
|
||||
|
||||
@ -1,5 +1,5 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
from .routes_shared import _format_datetime, _get_or_create_settings, _apply_overrides_to_run, _infer_schedule_map_from_runs, _infer_monthly_schedule_from_runs
|
||||
from .routes_shared import _format_datetime, _get_or_create_settings, _apply_overrides_to_run, _infer_schedule_map_from_runs
|
||||
|
||||
# Grace window for today's Expected/Missed transition.
|
||||
# A job is only marked Missed after the latest expected time plus this grace.
|
||||
@ -76,7 +76,6 @@ def daily_jobs():
|
||||
|
||||
jobs = (
|
||||
Job.query.join(Customer, isouter=True)
|
||||
.filter(Job.archived.is_(False))
|
||||
.order_by(Customer.name.asc().nullslast(), Job.backup_software.asc(), Job.backup_type.asc(), Job.job_name.asc())
|
||||
.all()
|
||||
)
|
||||
@ -85,23 +84,6 @@ def daily_jobs():
|
||||
for job in jobs:
|
||||
schedule_map = _infer_schedule_map_from_runs(job.id)
|
||||
expected_times = schedule_map.get(weekday_idx) or []
|
||||
|
||||
# If no weekly schedule is inferred (e.g. monthly jobs), try monthly inference.
|
||||
if not expected_times:
|
||||
monthly = _infer_monthly_schedule_from_runs(job.id)
|
||||
if monthly:
|
||||
dom = int(monthly.get("day_of_month") or 0)
|
||||
mtimes = monthly.get("times") or []
|
||||
# For months shorter than dom, treat the last day of month as the scheduled day.
|
||||
try:
|
||||
import calendar as _calendar
|
||||
last_dom = _calendar.monthrange(target_date.year, target_date.month)[1]
|
||||
except Exception:
|
||||
last_dom = target_date.day
|
||||
scheduled_dom = dom if (dom and dom <= last_dom) else last_dom
|
||||
if target_date.day == scheduled_dom:
|
||||
expected_times = list(mtimes)
|
||||
|
||||
if not expected_times:
|
||||
continue
|
||||
|
||||
|
||||
@ -4,14 +4,15 @@ from .routes_shared import _format_datetime
|
||||
|
||||
@main_bp.route("/feedback")
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "reporter", "viewer")
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def feedback_page():
|
||||
item_type = (request.args.get("type") or "").strip().lower()
|
||||
if item_type not in ("", "bug", "feature"):
|
||||
item_type = ""
|
||||
|
||||
# Default to showing only open items. Users can still switch to Resolved or All via the filter.
|
||||
status = (request.args.get("status") or "open").strip().lower()
|
||||
# Default to showing both open and resolved items. Resolved items should remain
|
||||
# visible for all users until an admin deletes them.
|
||||
status = (request.args.get("status") or "all").strip().lower()
|
||||
if status not in ("open", "resolved", "all"):
|
||||
status = "all"
|
||||
|
||||
@ -45,9 +46,6 @@ def feedback_page():
|
||||
else:
|
||||
order_sql = "vote_count DESC, fi.created_at DESC"
|
||||
|
||||
# Always keep resolved items at the bottom when mixing statuses.
|
||||
order_sql = "CASE WHEN fi.status = 'resolved' THEN 1 ELSE 0 END, " + order_sql
|
||||
|
||||
sql = text(
|
||||
f"""
|
||||
SELECT
|
||||
@ -110,7 +108,7 @@ def feedback_page():
|
||||
|
||||
@main_bp.route("/feedback/new", methods=["GET", "POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "reporter", "viewer")
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def feedback_new():
|
||||
if request.method == "POST":
|
||||
item_type = (request.form.get("item_type") or "").strip().lower()
|
||||
@ -145,7 +143,7 @@ def feedback_new():
|
||||
|
||||
@main_bp.route("/feedback/<int:item_id>")
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "reporter", "viewer")
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def feedback_detail(item_id: int):
|
||||
item = FeedbackItem.query.get_or_404(item_id)
|
||||
if item.deleted_at is not None:
|
||||
@ -174,19 +172,6 @@ def feedback_detail(item_id: int):
|
||||
resolved_by = User.query.get(item.resolved_by_user_id)
|
||||
resolved_by_name = resolved_by.username if resolved_by else ""
|
||||
|
||||
|
||||
replies = (
|
||||
FeedbackReply.query.filter(FeedbackReply.feedback_item_id == item.id)
|
||||
.order_by(FeedbackReply.created_at.asc())
|
||||
.all()
|
||||
)
|
||||
|
||||
reply_user_ids = sorted({int(r.user_id) for r in replies})
|
||||
reply_users = (
|
||||
User.query.filter(User.id.in_(reply_user_ids)).all() if reply_user_ids else []
|
||||
)
|
||||
reply_user_map = {int(u.id): (u.username or "") for u in reply_users}
|
||||
|
||||
return render_template(
|
||||
"main/feedback_detail.html",
|
||||
item=item,
|
||||
@ -194,46 +179,12 @@ def feedback_detail(item_id: int):
|
||||
resolved_by_name=resolved_by_name,
|
||||
vote_count=int(vote_count),
|
||||
user_voted=bool(user_voted),
|
||||
replies=replies,
|
||||
reply_user_map=reply_user_map,
|
||||
)
|
||||
|
||||
@main_bp.route("/feedback/<int:item_id>/reply", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "reporter", "viewer")
|
||||
def feedback_reply(item_id: int):
|
||||
item = FeedbackItem.query.get_or_404(item_id)
|
||||
if item.deleted_at is not None:
|
||||
abort(404)
|
||||
|
||||
if (item.status or "").strip().lower() != "open":
|
||||
flash("Only open feedback items can be replied to.", "warning")
|
||||
return redirect(url_for("main.feedback_detail", item_id=item.id))
|
||||
|
||||
message = (request.form.get("message") or "").strip()
|
||||
if not message:
|
||||
flash("Reply message is required.", "danger")
|
||||
return redirect(url_for("main.feedback_detail", item_id=item.id))
|
||||
|
||||
reply = FeedbackReply(
|
||||
feedback_item_id=int(item.id),
|
||||
user_id=int(current_user.id),
|
||||
message=message,
|
||||
created_at=datetime.utcnow(),
|
||||
)
|
||||
db.session.add(reply)
|
||||
db.session.commit()
|
||||
|
||||
flash("Reply added.", "success")
|
||||
return redirect(url_for("main.feedback_detail", item_id=item.id))
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
@main_bp.route("/feedback/<int:item_id>/vote", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "reporter", "viewer")
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def feedback_vote(item_id: int):
|
||||
item = FeedbackItem.query.get_or_404(item_id)
|
||||
if item.deleted_at is not None:
|
||||
|
||||
@ -1,14 +1,7 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
from .routes_shared import _format_datetime, _log_admin_event, _send_mail_message_eml_download
|
||||
|
||||
from ..email_utils import extract_best_html_from_eml, is_effectively_blank_html
|
||||
from ..parsers.veeam import extract_vspc_active_alarms_companies
|
||||
from ..models import MailObject
|
||||
|
||||
import time
|
||||
import re
|
||||
import html as _html
|
||||
|
||||
|
||||
@main_bp.route("/inbox")
|
||||
@login_required
|
||||
@ -76,8 +69,6 @@ def inbox():
|
||||
has_prev=has_prev,
|
||||
has_next=has_next,
|
||||
customers=customer_rows,
|
||||
can_bulk_delete=(get_active_role() in ("admin", "operator")),
|
||||
is_admin=(get_active_role() == "admin"),
|
||||
)
|
||||
|
||||
|
||||
@ -118,24 +109,11 @@ def inbox_message_detail(message_id: int):
|
||||
),
|
||||
}
|
||||
|
||||
def _is_blank_text(s):
|
||||
return s is None or (isinstance(s, str) and s.strip() == "")
|
||||
|
||||
html_body = getattr(msg, "html_body", None)
|
||||
text_body = getattr(msg, "text_body", None)
|
||||
|
||||
# For legacy messages: if the Graph body is empty/whitespace but the real report
|
||||
# is an HTML attachment in the stored EML, extract and render it.
|
||||
if is_effectively_blank_html(html_body) and _is_blank_text(text_body) and getattr(msg, "eml_blob", None):
|
||||
extracted = extract_best_html_from_eml(getattr(msg, "eml_blob", None))
|
||||
if extracted:
|
||||
html_body = extracted
|
||||
|
||||
if not is_effectively_blank_html(html_body):
|
||||
body_html = html_body
|
||||
elif not _is_blank_text(text_body):
|
||||
if getattr(msg, "html_body", None):
|
||||
body_html = msg.html_body
|
||||
elif getattr(msg, "text_body", None):
|
||||
escaped = (
|
||||
text_body.replace("&", "&")
|
||||
msg.text_body.replace("&", "&")
|
||||
.replace("<", "<")
|
||||
.replace(">", ">")
|
||||
)
|
||||
@ -154,52 +132,7 @@ def inbox_message_detail(message_id: int):
|
||||
for obj in MailObject.query.filter_by(mail_message_id=msg.id).order_by(MailObject.object_name.asc()).all()
|
||||
]
|
||||
|
||||
# VSPC multi-company emails (e.g. "Active alarms summary") may not store parsed objects yet.
|
||||
# Extract company names from the stored body so the UI can offer a dedicated mapping workflow.
|
||||
vspc_companies: list[str] = []
|
||||
vspc_company_defaults: dict[str, dict] = {}
|
||||
try:
|
||||
bsw = (getattr(msg, "backup_software", "") or "").strip().lower()
|
||||
btype = (getattr(msg, "backup_type", "") or "").strip().lower()
|
||||
jname = (getattr(msg, "job_name", "") or "").strip().lower()
|
||||
|
||||
if bsw == "veeam" and btype == "service provider console" and jname == "active alarms summary":
|
||||
raw = text_body if not _is_blank_text(text_body) else (html_body or "")
|
||||
vspc_companies = extract_vspc_active_alarms_companies(raw)
|
||||
|
||||
# For each company, prefill the UI with the existing customer mapping if we already have a job for it.
|
||||
# This avoids re-mapping known companies and keeps the message actionable in the Inbox.
|
||||
if vspc_companies:
|
||||
for company in vspc_companies:
|
||||
norm_from, store_backup, store_type, _store_job = build_job_match_key(msg)
|
||||
company_job_name = f"{(msg.job_name or 'Active alarms summary').strip()} | {company}".strip()
|
||||
tmp_msg = MailMessage(
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
)
|
||||
job = find_matching_job(tmp_msg)
|
||||
if job and getattr(job, "customer_id", None):
|
||||
c = Customer.query.get(int(job.customer_id))
|
||||
if c:
|
||||
vspc_company_defaults[company] = {
|
||||
"customer_id": int(c.id),
|
||||
"customer_name": c.name,
|
||||
}
|
||||
except Exception:
|
||||
vspc_companies = []
|
||||
vspc_company_defaults = {}
|
||||
|
||||
|
||||
return jsonify({
|
||||
"status": "ok",
|
||||
"meta": meta,
|
||||
"body_html": body_html,
|
||||
"objects": objects,
|
||||
"vspc_companies": vspc_companies,
|
||||
"vspc_company_defaults": vspc_company_defaults,
|
||||
})
|
||||
return jsonify({"status": "ok", "meta": meta, "body_html": body_html, "objects": objects})
|
||||
|
||||
|
||||
@main_bp.route("/inbox/message/<int:message_id>/eml")
|
||||
@ -332,409 +265,6 @@ def inbox_message_approve(message_id: int):
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
|
||||
@main_bp.route("/inbox/<int:message_id>/approve_vspc_companies", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator")
|
||||
def inbox_message_approve_vspc_companies(message_id: int):
|
||||
msg = MailMessage.query.get_or_404(message_id)
|
||||
|
||||
# Only allow approval from inbox
|
||||
if getattr(msg, "location", "inbox") != "inbox":
|
||||
flash("This message is no longer in the Inbox and cannot be approved here.", "warning")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
mappings_json = (request.form.get("company_mappings_json") or "").strip()
|
||||
try:
|
||||
mappings = json.loads(mappings_json) if mappings_json else []
|
||||
except Exception:
|
||||
flash("Invalid company mappings payload.", "danger")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
if mappings is None:
|
||||
mappings = []
|
||||
|
||||
if not isinstance(mappings, list):
|
||||
flash("Invalid company mappings payload.", "danger")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# Validate message type (best-effort guard)
|
||||
if (getattr(msg, "backup_software", None) or "").strip() != "Veeam" or (getattr(msg, "backup_type", None) or "").strip() != "Service Provider Console":
|
||||
flash("This approval method is only valid for Veeam Service Provider Console summary emails.", "danger")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# Determine companies present in this message (only alarms > 0).
|
||||
html_body = getattr(msg, "html_body", None)
|
||||
text_body = getattr(msg, "text_body", None)
|
||||
raw_for_companies = text_body if (text_body and str(text_body).strip()) else (html_body or "")
|
||||
companies_present = extract_vspc_active_alarms_companies(raw_for_companies)
|
||||
|
||||
if not companies_present:
|
||||
flash("No companies could be detected in this VSPC summary email.", "danger")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# Resolve existing mappings from already-created per-company jobs.
|
||||
existing_map: dict[str, int] = {}
|
||||
for company in companies_present:
|
||||
norm_from, store_backup, store_type, _store_job = build_job_match_key(msg)
|
||||
company_job_name = f"{(msg.job_name or 'Active alarms summary').strip()} | {company}".strip()
|
||||
tmp_msg = MailMessage(
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
)
|
||||
job = find_matching_job(tmp_msg)
|
||||
if job and getattr(job, "customer_id", None):
|
||||
try:
|
||||
existing_map[company] = int(job.customer_id)
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
# Resolve mappings provided by the user from the popup.
|
||||
provided_map: dict[str, int] = {}
|
||||
for item in mappings:
|
||||
if not isinstance(item, dict):
|
||||
continue
|
||||
company = (item.get("company") or "").strip()
|
||||
customer_id_raw = str(item.get("customer_id") or "").strip()
|
||||
if not company or not customer_id_raw:
|
||||
continue
|
||||
|
||||
try:
|
||||
customer_id = int(customer_id_raw)
|
||||
except ValueError:
|
||||
continue
|
||||
|
||||
customer = Customer.query.get(customer_id)
|
||||
if not customer:
|
||||
continue
|
||||
|
||||
provided_map[company] = int(customer.id)
|
||||
|
||||
# Persist mapping immediately by creating/updating the per-company job.
|
||||
# This ensures already mapped companies are shown next time, even if approval is blocked.
|
||||
norm_from, store_backup, store_type, _store_job = build_job_match_key(msg)
|
||||
company_job_name = f"{(msg.job_name or 'Active alarms summary').strip()} | {company}".strip()
|
||||
|
||||
tmp_msg = MailMessage(
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
)
|
||||
job = find_matching_job(tmp_msg)
|
||||
if job:
|
||||
if job.customer_id != customer.id:
|
||||
job.customer_id = customer.id
|
||||
else:
|
||||
job = Job(
|
||||
customer_id=customer.id,
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
active=True,
|
||||
auto_approve=True,
|
||||
)
|
||||
db.session.add(job)
|
||||
db.session.flush()
|
||||
|
||||
# Commit any mapping updates so they are visible immediately in the UI.
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception:
|
||||
db.session.rollback()
|
||||
flash("Could not save company mappings due to a database error.", "danger")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# Final mapping resolution: existing job mappings + any newly provided ones.
|
||||
final_map: dict[str, int] = dict(existing_map)
|
||||
final_map.update(provided_map)
|
||||
|
||||
missing_companies = [c for c in companies_present if c not in final_map]
|
||||
mapped_companies = [c for c in companies_present if c in final_map]
|
||||
|
||||
if not mapped_companies:
|
||||
# Nothing to approve yet; user must map at least one company.
|
||||
missing_str = ", ".join(missing_companies[:10])
|
||||
if len(missing_companies) > 10:
|
||||
missing_str += f" (+{len(missing_companies) - 10} more)"
|
||||
flash(
|
||||
(
|
||||
"Please map at least one company before approving."
|
||||
+ (f" Missing: {missing_str}" if missing_str else "")
|
||||
),
|
||||
"danger",
|
||||
)
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
def _is_error_status(value: str | None) -> bool:
|
||||
v = (value or "").strip().lower()
|
||||
return v in {"error", "failed", "critical"} or v.startswith("fail")
|
||||
|
||||
created_runs: list[JobRun] = []
|
||||
skipped_existing = 0
|
||||
first_job: Job | None = None
|
||||
|
||||
# Create runs for mapped companies only. If some companies remain unmapped,
|
||||
# the message stays in the Inbox so the user can map the remainder later.
|
||||
for company in mapped_companies:
|
||||
customer_id = int(final_map[company])
|
||||
customer = Customer.query.get(customer_id)
|
||||
if not customer:
|
||||
continue
|
||||
|
||||
norm_from, store_backup, store_type, _store_job = build_job_match_key(msg)
|
||||
company_job_name = f"{(msg.job_name or 'Active alarms summary').strip()} | {company}".strip()
|
||||
tmp_msg = MailMessage(
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
)
|
||||
job = find_matching_job(tmp_msg)
|
||||
if job:
|
||||
if job.customer_id != customer.id:
|
||||
job.customer_id = customer.id
|
||||
else:
|
||||
job = Job(
|
||||
customer_id=customer.id,
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
active=True,
|
||||
auto_approve=True,
|
||||
)
|
||||
db.session.add(job)
|
||||
db.session.flush()
|
||||
|
||||
if not first_job:
|
||||
first_job = job
|
||||
|
||||
objs = (
|
||||
MailObject.query.filter(MailObject.mail_message_id == msg.id)
|
||||
.filter(MailObject.object_name.ilike(f"{company} | %"))
|
||||
.all()
|
||||
)
|
||||
saw_error = any(_is_error_status(o.status) for o in objs)
|
||||
saw_warning = any((o.status or "").strip().lower() == "warning" for o in objs)
|
||||
status = "Error" if saw_error else ("Warning" if saw_warning else (msg.overall_status or "Success"))
|
||||
|
||||
# De-duplicate: do not create multiple runs for the same (mail_message_id, job_id).
|
||||
run = JobRun.query.filter(JobRun.job_id == job.id, JobRun.mail_message_id == msg.id).first()
|
||||
if run:
|
||||
skipped_existing += 1
|
||||
else:
|
||||
run = JobRun(
|
||||
job_id=job.id,
|
||||
mail_message_id=msg.id,
|
||||
run_at=(msg.received_at or getattr(msg, "parsed_at", None) or datetime.utcnow()),
|
||||
status=status or None,
|
||||
missed=False,
|
||||
)
|
||||
if hasattr(run, "remark"):
|
||||
run.remark = getattr(msg, "overall_message", None)
|
||||
|
||||
db.session.add(run)
|
||||
db.session.flush()
|
||||
created_runs.append(run)
|
||||
|
||||
# Persist objects for reporting (idempotent upsert; safe to repeat).
|
||||
try:
|
||||
persist_objects_for_approved_run_filtered(
|
||||
customer.id,
|
||||
job.id,
|
||||
run.id,
|
||||
msg.id,
|
||||
object_name_prefix=company,
|
||||
strip_prefix=True,
|
||||
)
|
||||
except Exception as exc:
|
||||
_log_admin_event(
|
||||
"object_persist_error",
|
||||
f"Filtered object persistence failed for message {msg.id} (company '{company}', job {job.id}, run {run.id}): {exc}",
|
||||
)
|
||||
|
||||
processed_total = len(created_runs) + skipped_existing
|
||||
if processed_total <= 0:
|
||||
flash("No runs could be created for this VSPC summary.", "danger")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# Commit created runs and any job mapping updates first.
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
flash("Could not approve this job due to a database error.", "danger")
|
||||
_log_admin_event("inbox_approve_error", f"Failed to approve VSPC message {msg.id}: {exc}")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
if missing_companies:
|
||||
# Keep message in Inbox until all companies are mapped, but keep the already
|
||||
# created runs for mapped companies.
|
||||
missing_str = ", ".join(missing_companies[:10])
|
||||
if len(missing_companies) > 10:
|
||||
missing_str += f" (+{len(missing_companies) - 10} more)"
|
||||
_log_admin_event(
|
||||
"inbox_approve_vspc_partial",
|
||||
f"Partially approved VSPC message {msg.id}: {processed_total} run(s) processed, missing={missing_str}",
|
||||
)
|
||||
flash(
|
||||
f"Approved {processed_total} mapped compan{'y' if processed_total == 1 else 'ies'}. Message stays in the Inbox until all companies are mapped. Missing: {missing_str}",
|
||||
"warning",
|
||||
)
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# All companies mapped: mark the message as approved and move it to History.
|
||||
msg.job_id = first_job.id if first_job else None
|
||||
if hasattr(msg, "approved"):
|
||||
msg.approved = True
|
||||
if hasattr(msg, "approved_at"):
|
||||
msg.approved_at = datetime.utcnow()
|
||||
if hasattr(msg, "approved_by_id"):
|
||||
msg.approved_by_id = current_user.id
|
||||
if hasattr(msg, "location"):
|
||||
msg.location = "history"
|
||||
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
flash("Could not finalize approval due to a database error.", "danger")
|
||||
_log_admin_event("inbox_approve_error", f"Failed to finalize VSPC approval for message {msg.id}: {exc}")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
# Best-effort: now that company jobs are mapped, auto-approve other inbox
|
||||
# messages of the same VSPC summary type whose companies are now all mapped.
|
||||
retro_approved_msgs = 0
|
||||
try:
|
||||
q = MailMessage.query
|
||||
if hasattr(MailMessage, "location"):
|
||||
q = q.filter(MailMessage.location == "inbox")
|
||||
q = q.filter(MailMessage.parse_result == "ok")
|
||||
q = q.filter(MailMessage.job_id.is_(None))
|
||||
q = q.filter(MailMessage.backup_software == "Veeam")
|
||||
q = q.filter(MailMessage.backup_type == "Service Provider Console")
|
||||
q = q.filter(MailMessage.job_name == (msg.job_name or "Active alarms summary"))
|
||||
q = q.filter(MailMessage.id != msg.id)
|
||||
candidates = q.order_by(MailMessage.received_at.desc().nullslast(), MailMessage.id.desc()).limit(25).all()
|
||||
|
||||
for other in candidates:
|
||||
nested = db.session.begin_nested()
|
||||
try:
|
||||
raw_other = (other.text_body or "").strip() or (other.html_body or "")
|
||||
companies = extract_vspc_active_alarms_companies(raw_other)
|
||||
if not companies:
|
||||
nested.commit()
|
||||
continue
|
||||
|
||||
jobs_by_company: dict[str, Job] = {}
|
||||
all_mapped = True
|
||||
for company in companies:
|
||||
norm_from, store_backup, store_type, _store_job = build_job_match_key(other)
|
||||
company_job_name = f"{(other.job_name or 'Active alarms summary').strip()} | {company}".strip()
|
||||
tmp = MailMessage(
|
||||
from_address=norm_from,
|
||||
backup_software=store_backup,
|
||||
backup_type=store_type,
|
||||
job_name=company_job_name,
|
||||
)
|
||||
with db.session.no_autoflush:
|
||||
j = find_matching_job(tmp)
|
||||
if not j or not getattr(j, "customer_id", None):
|
||||
all_mapped = False
|
||||
break
|
||||
if hasattr(j, "active") and not bool(j.active):
|
||||
all_mapped = False
|
||||
break
|
||||
if hasattr(j, "auto_approve") and not bool(j.auto_approve):
|
||||
all_mapped = False
|
||||
break
|
||||
jobs_by_company[company] = j
|
||||
|
||||
if not all_mapped:
|
||||
nested.commit()
|
||||
continue
|
||||
|
||||
first_job2: Job | None = None
|
||||
for company, job2 in jobs_by_company.items():
|
||||
if not first_job2:
|
||||
first_job2 = job2
|
||||
|
||||
objs2 = (
|
||||
MailObject.query.filter(MailObject.mail_message_id == other.id)
|
||||
.filter(MailObject.object_name.ilike(f"{company} | %"))
|
||||
.all()
|
||||
)
|
||||
saw_error2 = any(_is_error_status(o.status) for o in objs2)
|
||||
saw_warning2 = any((o.status or "").strip().lower() == "warning" for o in objs2)
|
||||
status2 = "Error" if saw_error2 else ("Warning" if saw_warning2 else (other.overall_status or "Success"))
|
||||
|
||||
run2 = JobRun.query.filter(JobRun.job_id == job2.id, JobRun.mail_message_id == other.id).first()
|
||||
if not run2:
|
||||
run2 = JobRun(
|
||||
job_id=job2.id,
|
||||
mail_message_id=other.id,
|
||||
run_at=(other.received_at or getattr(other, "parsed_at", None) or datetime.utcnow()),
|
||||
status=status2 or None,
|
||||
missed=False,
|
||||
)
|
||||
if hasattr(run2, "remark"):
|
||||
run2.remark = getattr(other, "overall_message", None)
|
||||
db.session.add(run2)
|
||||
db.session.flush()
|
||||
|
||||
# Persist objects per company
|
||||
try:
|
||||
persist_objects_for_approved_run_filtered(
|
||||
int(job2.customer_id),
|
||||
int(job2.id),
|
||||
int(run2.id),
|
||||
int(other.id),
|
||||
object_name_prefix=company,
|
||||
strip_prefix=True,
|
||||
)
|
||||
except Exception as exc:
|
||||
_log_admin_event(
|
||||
"object_persist_error",
|
||||
f"Filtered object persistence failed for message {other.id} (company '{company}', job {job2.id}, run {run2.id}): {exc}",
|
||||
)
|
||||
|
||||
other.job_id = first_job2.id if first_job2 else None
|
||||
if hasattr(other, "approved"):
|
||||
other.approved = True
|
||||
if hasattr(other, "approved_at"):
|
||||
other.approved_at = datetime.utcnow()
|
||||
if hasattr(other, "approved_by_id"):
|
||||
other.approved_by_id = current_user.id
|
||||
if hasattr(other, "location"):
|
||||
other.location = "history"
|
||||
|
||||
nested.commit()
|
||||
retro_approved_msgs += 1
|
||||
except Exception:
|
||||
try:
|
||||
nested.rollback()
|
||||
except Exception:
|
||||
db.session.rollback()
|
||||
|
||||
db.session.commit()
|
||||
except Exception:
|
||||
try:
|
||||
db.session.rollback()
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
_log_admin_event(
|
||||
"inbox_approve_vspc",
|
||||
f"Approved VSPC message {msg.id} into {processed_total} run(s) (job_id={msg.job_id}), retro_approved={retro_approved_msgs}",
|
||||
)
|
||||
flash(f"Approved VSPC summary into {processed_total} run(s).", "success")
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
|
||||
|
||||
@main_bp.route("/inbox/message/<int:message_id>/delete", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator")
|
||||
@ -766,62 +296,6 @@ def inbox_message_delete(message_id: int):
|
||||
return redirect(url_for("main.inbox"))
|
||||
|
||||
|
||||
|
||||
|
||||
@main_bp.post("/api/inbox/delete")
|
||||
@login_required
|
||||
@roles_required("admin", "operator")
|
||||
def api_inbox_bulk_delete():
|
||||
"""Bulk delete inbox messages (soft delete -> move to Deleted)."""
|
||||
data = request.get_json(silent=True) or {}
|
||||
message_ids = data.get("message_ids") or []
|
||||
|
||||
try:
|
||||
message_ids = [int(x) for x in message_ids]
|
||||
except Exception:
|
||||
return jsonify({"status": "error", "message": "Invalid message_ids."}), 400
|
||||
|
||||
if not message_ids:
|
||||
return jsonify({"status": "ok", "updated": 0, "skipped": 0, "missing": 0})
|
||||
|
||||
msgs = MailMessage.query.filter(MailMessage.id.in_(message_ids)).all()
|
||||
msg_map = {int(m.id): m for m in msgs}
|
||||
|
||||
now = datetime.utcnow()
|
||||
updated = 0
|
||||
skipped = 0
|
||||
missing = 0
|
||||
|
||||
for mid in message_ids:
|
||||
msg = msg_map.get(int(mid))
|
||||
if not msg:
|
||||
missing += 1
|
||||
continue
|
||||
|
||||
if getattr(msg, "location", "inbox") != "inbox":
|
||||
skipped += 1
|
||||
continue
|
||||
|
||||
if hasattr(msg, "location"):
|
||||
msg.location = "deleted"
|
||||
if hasattr(msg, "deleted_at"):
|
||||
msg.deleted_at = now
|
||||
if hasattr(msg, "deleted_by_user_id"):
|
||||
msg.deleted_by_user_id = current_user.id
|
||||
|
||||
updated += 1
|
||||
|
||||
try:
|
||||
db.session.commit()
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
_log_admin_event("inbox_bulk_delete_error", f"Failed to bulk delete inbox messages {message_ids}: {exc}")
|
||||
return jsonify({"status": "error", "message": "Database error while deleting messages."}), 500
|
||||
|
||||
_log_admin_event("inbox_bulk_delete", f"Deleted inbox messages: {message_ids}")
|
||||
return jsonify({"status": "ok", "updated": updated, "skipped": skipped, "missing": missing})
|
||||
|
||||
|
||||
@main_bp.route("/inbox/deleted")
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
@ -982,95 +456,6 @@ def inbox_reparse_all():
|
||||
and getattr(msg, "parse_result", None) == "ok"
|
||||
and getattr(msg, "job_id", None) is None
|
||||
):
|
||||
# Special case: VSPC Active Alarms summary can contain multiple companies.
|
||||
bsw = (getattr(msg, "backup_software", "") or "").strip().lower()
|
||||
btype = (getattr(msg, "backup_type", "") or "").strip().lower()
|
||||
jname = (getattr(msg, "job_name", "") or "").strip().lower()
|
||||
|
||||
if bsw == "veeam" and btype == "service provider console" and jname == "active alarms summary":
|
||||
raw = (getattr(msg, "text_body", None) or "").strip() or (getattr(msg, "html_body", None) or "")
|
||||
companies = extract_vspc_active_alarms_companies(raw)
|
||||
|
||||
if companies:
|
||||
def _is_error_status(value: str | None) -> bool:
|
||||
v = (value or "").strip().lower()
|
||||
return v in {"error", "failed", "critical"} or v.startswith("fail")
|
||||
|
||||
first_job = None
|
||||
mapped_count = 0
|
||||
created_any = False
|
||||
|
||||
for company in companies:
|
||||
tmp_msg = MailMessage(
|
||||
from_address=msg.from_address,
|
||||
backup_software=msg.backup_software,
|
||||
backup_type=msg.backup_type,
|
||||
job_name=f"{(msg.job_name or 'Active alarms summary').strip()} | {company}".strip(),
|
||||
)
|
||||
with db.session.no_autoflush:
|
||||
job = find_matching_job(tmp_msg)
|
||||
|
||||
if not job:
|
||||
continue
|
||||
if hasattr(job, "active") and not bool(job.active):
|
||||
continue
|
||||
if hasattr(job, "auto_approve") and not bool(job.auto_approve):
|
||||
continue
|
||||
|
||||
mapped_count += 1
|
||||
|
||||
objs = (
|
||||
MailObject.query.filter(MailObject.mail_message_id == msg.id)
|
||||
.filter(MailObject.object_name.ilike(f"{company} | %"))
|
||||
.all()
|
||||
)
|
||||
saw_error = any(_is_error_status(o.status) for o in objs)
|
||||
saw_warning = any((o.status or "").strip().lower() == "warning" for o in objs)
|
||||
status = "Error" if saw_error else ("Warning" if saw_warning else (msg.overall_status or "Success"))
|
||||
|
||||
run = JobRun(
|
||||
job_id=job.id,
|
||||
mail_message_id=msg.id,
|
||||
run_at=(msg.received_at or getattr(msg, "parsed_at", None) or datetime.utcnow()),
|
||||
status=status or None,
|
||||
missed=False,
|
||||
)
|
||||
|
||||
if hasattr(run, "remark"):
|
||||
run.remark = getattr(msg, "overall_message", None)
|
||||
|
||||
if hasattr(run, "storage_used_bytes") and hasattr(msg, "storage_used_bytes"):
|
||||
run.storage_used_bytes = msg.storage_used_bytes
|
||||
if hasattr(run, "storage_capacity_bytes") and hasattr(msg, "storage_capacity_bytes"):
|
||||
run.storage_capacity_bytes = msg.storage_capacity_bytes
|
||||
if hasattr(run, "storage_free_bytes") and hasattr(msg, "storage_free_bytes"):
|
||||
run.storage_free_bytes = msg.storage_free_bytes
|
||||
if hasattr(run, "storage_free_percent") and hasattr(msg, "storage_free_percent"):
|
||||
run.storage_free_percent = msg.storage_free_percent
|
||||
|
||||
db.session.add(run)
|
||||
db.session.flush()
|
||||
auto_approved_runs.append((job.customer_id, job.id, run.id, msg.id))
|
||||
created_any = True
|
||||
|
||||
if not first_job:
|
||||
first_job = job
|
||||
|
||||
if created_any and mapped_count == len(companies):
|
||||
msg.job_id = first_job.id if first_job else None
|
||||
if hasattr(msg, "approved"):
|
||||
msg.approved = True
|
||||
if hasattr(msg, "approved_at"):
|
||||
msg.approved_at = datetime.utcnow()
|
||||
if hasattr(msg, "approved_by_id"):
|
||||
msg.approved_by_id = None
|
||||
if hasattr(msg, "location"):
|
||||
msg.location = "history"
|
||||
auto_approved += 1
|
||||
|
||||
# Do not fall back to single-job matching for VSPC summary.
|
||||
continue
|
||||
|
||||
# Match approved job on: From + Backup + Type + Job name
|
||||
# Prevent session autoflush for every match lookup while we
|
||||
# are still updating many messages in a loop.
|
||||
@ -1251,7 +636,7 @@ def inbox_reparse_all():
|
||||
persisted_errors = 0
|
||||
for (customer_id, job_id, run_id, mail_message_id) in auto_approved_runs:
|
||||
try:
|
||||
persisted_objects += persist_objects_for_auto_run(
|
||||
persisted_objects += persist_objects_for_approved_run(
|
||||
customer_id, job_id, run_id, mail_message_id
|
||||
)
|
||||
except Exception as exc:
|
||||
|
||||
@ -16,7 +16,6 @@ def jobs():
|
||||
# Join with customers for display
|
||||
jobs = (
|
||||
Job.query
|
||||
.filter(Job.archived.is_(False))
|
||||
.outerjoin(Customer, Customer.id == Job.customer_id)
|
||||
.add_columns(
|
||||
Job.id,
|
||||
@ -56,89 +55,6 @@ def jobs():
|
||||
)
|
||||
|
||||
|
||||
@main_bp.route("/jobs/<int:job_id>/archive", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator")
|
||||
def archive_job(job_id: int):
|
||||
job = Job.query.get_or_404(job_id)
|
||||
|
||||
if job.archived:
|
||||
flash("Job is already archived.", "info")
|
||||
return redirect(url_for("main.jobs"))
|
||||
|
||||
job.archived = True
|
||||
job.archived_at = datetime.utcnow()
|
||||
job.archived_by_user_id = current_user.id
|
||||
db.session.commit()
|
||||
|
||||
try:
|
||||
log_admin_event("job_archived", f"Archived job {job.id}", details=f"job_name={job.job_name}")
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
flash("Job archived.", "success")
|
||||
return redirect(url_for("main.jobs"))
|
||||
|
||||
|
||||
@main_bp.route("/archived-jobs")
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
def archived_jobs():
|
||||
rows = (
|
||||
Job.query
|
||||
.filter(Job.archived.is_(True))
|
||||
.outerjoin(Customer, Customer.id == Job.customer_id)
|
||||
.add_columns(
|
||||
Job.id,
|
||||
Job.backup_software,
|
||||
Job.backup_type,
|
||||
Job.job_name,
|
||||
Job.archived_at,
|
||||
Customer.name.label("customer_name"),
|
||||
)
|
||||
.order_by(Customer.name.asc().nullslast(), Job.backup_software.asc(), Job.backup_type.asc(), Job.job_name.asc())
|
||||
.all()
|
||||
)
|
||||
|
||||
out = []
|
||||
for row in rows:
|
||||
out.append(
|
||||
{
|
||||
"id": row.id,
|
||||
"customer_name": getattr(row, "customer_name", "") or "",
|
||||
"backup_software": row.backup_software or "",
|
||||
"backup_type": row.backup_type or "",
|
||||
"job_name": row.job_name or "",
|
||||
"archived_at": _format_datetime(row.archived_at),
|
||||
}
|
||||
)
|
||||
|
||||
return render_template("main/archived_jobs.html", jobs=out)
|
||||
|
||||
|
||||
@main_bp.route("/jobs/<int:job_id>/unarchive", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
def unarchive_job(job_id: int):
|
||||
job = Job.query.get_or_404(job_id)
|
||||
if not job.archived:
|
||||
flash("Job is not archived.", "info")
|
||||
return redirect(url_for("main.archived_jobs"))
|
||||
|
||||
job.archived = False
|
||||
job.archived_at = None
|
||||
job.archived_by_user_id = None
|
||||
db.session.commit()
|
||||
|
||||
try:
|
||||
log_admin_event("job_unarchived", f"Unarchived job {job.id}", details=f"job_name={job.job_name}")
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
flash("Job restored.", "success")
|
||||
return redirect(url_for("main.archived_jobs"))
|
||||
|
||||
|
||||
@main_bp.route("/jobs/<int:job_id>")
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
@ -198,8 +114,8 @@ def job_detail(job_id: int):
|
||||
WHERE ts.job_id = :job_id
|
||||
AND t.active_from_date <= :max_date
|
||||
AND (
|
||||
COALESCE(ts.resolved_at, t.resolved_at) IS NULL
|
||||
OR ((COALESCE(ts.resolved_at, t.resolved_at) AT TIME ZONE 'UTC' AT TIME ZONE :ui_tz)::date) >= :min_date
|
||||
t.resolved_at IS NULL
|
||||
OR ((t.resolved_at AT TIME ZONE 'UTC' AT TIME ZONE :ui_tz)::date) >= :min_date
|
||||
)
|
||||
"""
|
||||
),
|
||||
@ -423,17 +339,25 @@ def job_delete(job_id: int):
|
||||
job = Job.query.get_or_404(job_id)
|
||||
|
||||
try:
|
||||
# Collect run IDs up-front for cleanup across dependent tables
|
||||
run_ids = [r.id for r in JobRun.query.filter_by(job_id=job.id).all()]
|
||||
# Collect run ids for FK cleanup in auxiliary tables that may not have ON DELETE CASCADE
|
||||
run_ids = []
|
||||
mail_message_ids = []
|
||||
|
||||
# Put any related mails back into the inbox and unlink from job
|
||||
msgs = MailMessage.query.filter(MailMessage.job_id == job.id).all()
|
||||
for msg in msgs:
|
||||
if hasattr(msg, "location"):
|
||||
msg.location = "inbox"
|
||||
msg.job_id = None
|
||||
for run in job.runs:
|
||||
if run.id is not None:
|
||||
run_ids.append(run.id)
|
||||
if run.mail_message_id:
|
||||
mail_message_ids.append(run.mail_message_id)
|
||||
|
||||
# Clean up tables that may not have ON DELETE CASCADE in older schemas.
|
||||
# Put related mails back into the inbox and unlink from job
|
||||
if mail_message_ids:
|
||||
msgs = MailMessage.query.filter(MailMessage.id.in_(mail_message_ids)).all()
|
||||
for msg in msgs:
|
||||
if hasattr(msg, "location"):
|
||||
msg.location = "inbox"
|
||||
msg.job_id = None
|
||||
|
||||
# Ensure run_object_links doesn't block job_runs deletion (older schemas may miss ON DELETE CASCADE)
|
||||
if run_ids:
|
||||
db.session.execute(
|
||||
text("DELETE FROM run_object_links WHERE run_id IN :run_ids").bindparams(
|
||||
@ -441,47 +365,13 @@ def job_delete(job_id: int):
|
||||
),
|
||||
{"run_ids": run_ids},
|
||||
)
|
||||
db.session.execute(
|
||||
text("DELETE FROM job_run_review_events WHERE run_id IN :run_ids").bindparams(
|
||||
bindparam("run_ids", expanding=True)
|
||||
),
|
||||
{"run_ids": run_ids},
|
||||
)
|
||||
db.session.execute(
|
||||
text("DELETE FROM ticket_job_runs WHERE job_run_id IN :run_ids").bindparams(
|
||||
bindparam("run_ids", expanding=True)
|
||||
),
|
||||
{"run_ids": run_ids},
|
||||
)
|
||||
db.session.execute(
|
||||
text("DELETE FROM remark_job_runs WHERE job_run_id IN :run_ids").bindparams(
|
||||
bindparam("run_ids", expanding=True)
|
||||
),
|
||||
{"run_ids": run_ids},
|
||||
)
|
||||
db.session.execute(
|
||||
text("DELETE FROM job_objects WHERE job_run_id IN :run_ids").bindparams(
|
||||
bindparam("run_ids", expanding=True)
|
||||
),
|
||||
{"run_ids": run_ids},
|
||||
)
|
||||
|
||||
# Overrides scoped to this job (object overrides)
|
||||
db.session.execute(text("UPDATE overrides SET job_id = NULL WHERE job_id = :job_id"), {"job_id": job.id})
|
||||
|
||||
# Ticket/Remark scopes may reference a specific job
|
||||
db.session.execute(text("UPDATE ticket_scopes SET job_id = NULL WHERE job_id = :job_id"), {"job_id": job.id})
|
||||
db.session.execute(text("UPDATE remark_scopes SET job_id = NULL WHERE job_id = :job_id"), {"job_id": job.id})
|
||||
|
||||
# Ensure job_object_links doesn't block jobs deletion (older schemas may miss ON DELETE CASCADE)
|
||||
db.session.execute(
|
||||
text("DELETE FROM job_object_links WHERE job_id = :job_id"),
|
||||
{"job_id": job.id},
|
||||
)
|
||||
|
||||
# Finally remove runs and the job itself
|
||||
if run_ids:
|
||||
db.session.execute(text("DELETE FROM job_runs WHERE job_id = :job_id"), {"job_id": job.id})
|
||||
if job.id is not None:
|
||||
db.session.execute(
|
||||
text("DELETE FROM job_object_links WHERE job_id = :job_id"),
|
||||
{"job_id": job.id},
|
||||
)
|
||||
|
||||
db.session.delete(job)
|
||||
db.session.commit()
|
||||
@ -491,4 +381,4 @@ def job_delete(job_id: int):
|
||||
print(f"[jobs] Failed to delete job: {exc}")
|
||||
flash("Failed to delete job.", "danger")
|
||||
|
||||
return redirect(url_for("main.jobs"))
|
||||
return redirect(url_for("main.jobs"))
|
||||
@ -1,139 +0,0 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
from .routes_shared import _format_datetime
|
||||
|
||||
from datetime import datetime
|
||||
|
||||
from sqlalchemy import or_
|
||||
|
||||
|
||||
def _parse_datetime_local(value: str):
|
||||
if not value:
|
||||
return None
|
||||
value = value.strip()
|
||||
if not value:
|
||||
return None
|
||||
try:
|
||||
# Accept HTML datetime-local values like 2026-01-08T10:30
|
||||
return datetime.fromisoformat(value)
|
||||
except Exception:
|
||||
return None
|
||||
|
||||
|
||||
@main_bp.route("/admin/mails")
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
def admin_all_mails():
|
||||
try:
|
||||
page = int(request.args.get("page", "1"))
|
||||
except ValueError:
|
||||
page = 1
|
||||
if page < 1:
|
||||
page = 1
|
||||
|
||||
per_page = 50
|
||||
|
||||
# Filters (AND-combined)
|
||||
from_q = (request.args.get("from_q", "") or "").strip()
|
||||
subject_q = (request.args.get("subject_q", "") or "").strip()
|
||||
backup_q = (request.args.get("backup_q", "") or "").strip()
|
||||
type_q = (request.args.get("type_q", "") or "").strip()
|
||||
job_name_q = (request.args.get("job_name_q", "") or "").strip()
|
||||
received_from_raw = (request.args.get("received_from", "") or "").strip()
|
||||
received_to_raw = (request.args.get("received_to", "") or "").strip()
|
||||
only_unlinked = (request.args.get("only_unlinked", "") or "").strip().lower() in (
|
||||
"1",
|
||||
"true",
|
||||
"yes",
|
||||
"on",
|
||||
)
|
||||
|
||||
received_from = _parse_datetime_local(received_from_raw)
|
||||
received_to = _parse_datetime_local(received_to_raw)
|
||||
|
||||
query = MailMessage.query
|
||||
|
||||
# Text filters
|
||||
if from_q:
|
||||
query = query.filter(MailMessage.from_address.ilike(f"%{from_q}%"))
|
||||
if subject_q:
|
||||
query = query.filter(MailMessage.subject.ilike(f"%{subject_q}%"))
|
||||
if backup_q:
|
||||
query = query.filter(MailMessage.backup_software.ilike(f"%{backup_q}%"))
|
||||
if type_q:
|
||||
query = query.filter(MailMessage.backup_type.ilike(f"%{type_q}%"))
|
||||
if job_name_q:
|
||||
# Prefer stored job_name on message, but also match linked job name
|
||||
query = query.outerjoin(Job, Job.id == MailMessage.job_id).filter(
|
||||
or_(
|
||||
MailMessage.job_name.ilike(f"%{job_name_q}%"),
|
||||
Job.job_name.ilike(f"%{job_name_q}%"),
|
||||
)
|
||||
)
|
||||
|
||||
# Time window
|
||||
if received_from:
|
||||
query = query.filter(MailMessage.received_at >= received_from)
|
||||
if received_to:
|
||||
query = query.filter(MailMessage.received_at <= received_to)
|
||||
|
||||
# Linked/unlinked
|
||||
if only_unlinked:
|
||||
query = query.filter(MailMessage.job_id.is_(None))
|
||||
|
||||
total_items = query.count()
|
||||
total_pages = max(1, math.ceil(total_items / per_page)) if total_items else 1
|
||||
if page > total_pages:
|
||||
page = total_pages
|
||||
|
||||
messages = (
|
||||
query.order_by(
|
||||
MailMessage.received_at.desc().nullslast(),
|
||||
MailMessage.id.desc(),
|
||||
)
|
||||
.offset((page - 1) * per_page)
|
||||
.limit(per_page)
|
||||
.all()
|
||||
)
|
||||
|
||||
rows = []
|
||||
for msg in messages:
|
||||
linked = bool(msg.job_id)
|
||||
rows.append(
|
||||
{
|
||||
"id": msg.id,
|
||||
"from_address": msg.from_address or "",
|
||||
"subject": msg.subject or "",
|
||||
"received_at": _format_datetime(msg.received_at),
|
||||
"backup_software": msg.backup_software or "",
|
||||
"backup_type": msg.backup_type or "",
|
||||
"job_name": (msg.job_name or ""),
|
||||
"linked": linked,
|
||||
"parsed_at": _format_datetime(msg.parsed_at),
|
||||
"overall_status": msg.overall_status or "",
|
||||
"has_eml": bool(getattr(msg, "eml_stored_at", None)),
|
||||
}
|
||||
)
|
||||
|
||||
has_prev = page > 1
|
||||
has_next = page < total_pages
|
||||
|
||||
filter_params = {
|
||||
"from_q": from_q,
|
||||
"subject_q": subject_q,
|
||||
"backup_q": backup_q,
|
||||
"type_q": type_q,
|
||||
"job_name_q": job_name_q,
|
||||
"received_from": received_from_raw,
|
||||
"received_to": received_to_raw,
|
||||
"only_unlinked": "1" if only_unlinked else "",
|
||||
}
|
||||
|
||||
return render_template(
|
||||
"main/admin_all_mail.html",
|
||||
rows=rows,
|
||||
page=page,
|
||||
total_pages=total_pages,
|
||||
has_prev=has_prev,
|
||||
has_next=has_next,
|
||||
filter_params=filter_params,
|
||||
)
|
||||
@ -75,16 +75,7 @@ def overrides():
|
||||
if ov.match_status:
|
||||
crit.append(f"status == {ov.match_status}")
|
||||
if ov.match_error_contains:
|
||||
mode = (getattr(ov, "match_error_mode", None) or "contains").strip().lower()
|
||||
if mode == "exact":
|
||||
label = "error exact"
|
||||
elif mode == "starts_with":
|
||||
label = "error starts with"
|
||||
elif mode == "ends_with":
|
||||
label = "error ends with"
|
||||
else:
|
||||
label = "error contains"
|
||||
crit.append(f"{label} '{ov.match_error_contains}'")
|
||||
crit.append(f"error contains '{ov.match_error_contains}'")
|
||||
if crit:
|
||||
scope = scope + " [" + ", ".join(crit) + "]"
|
||||
|
||||
@ -104,13 +95,6 @@ def overrides():
|
||||
"comment": ov.comment or "",
|
||||
"match_status": ov.match_status or "",
|
||||
"match_error_contains": ov.match_error_contains or "",
|
||||
"match_error_mode": getattr(ov, "match_error_mode", None) or "",
|
||||
"backup_software": ov.backup_software or "",
|
||||
"backup_type": ov.backup_type or "",
|
||||
"job_id": ov.job_id or "",
|
||||
"object_name": ov.object_name or "",
|
||||
"start_at_raw": (ov.start_at.strftime("%Y-%m-%dT%H:%M") if ov.start_at else ""),
|
||||
"end_at_raw": (ov.end_at.strftime("%Y-%m-%dT%H:%M") if ov.end_at else ""),
|
||||
}
|
||||
)
|
||||
|
||||
@ -142,12 +126,6 @@ def overrides_create():
|
||||
|
||||
match_status = (request.form.get("match_status") or "").strip() or None
|
||||
match_error_contains = (request.form.get("match_error_contains") or "").strip() or None
|
||||
match_error_mode = (request.form.get("match_error_mode") or "").strip().lower() or None
|
||||
if match_error_contains:
|
||||
if match_error_mode not in ("contains", "exact", "starts_with", "ends_with"):
|
||||
match_error_mode = "contains"
|
||||
else:
|
||||
match_error_mode = None
|
||||
|
||||
start_at_str = request.form.get("start_at") or ""
|
||||
end_at_str = request.form.get("end_at") or ""
|
||||
@ -181,7 +159,6 @@ def overrides_create():
|
||||
object_name=object_name if level == "object" else None,
|
||||
match_status=match_status,
|
||||
match_error_contains=match_error_contains,
|
||||
match_error_mode=match_error_mode,
|
||||
treat_as_success=treat_as_success,
|
||||
active=True,
|
||||
comment=comment,
|
||||
@ -241,12 +218,6 @@ def overrides_update(override_id: int):
|
||||
|
||||
match_status = (request.form.get("match_status") or "").strip() or None
|
||||
match_error_contains = (request.form.get("match_error_contains") or "").strip() or None
|
||||
match_error_mode = (request.form.get("match_error_mode") or "").strip().lower() or None
|
||||
if match_error_contains:
|
||||
if match_error_mode not in ("contains", "exact", "starts_with", "ends_with"):
|
||||
match_error_mode = "contains"
|
||||
else:
|
||||
match_error_mode = None
|
||||
|
||||
start_at_str = request.form.get("start_at") or ""
|
||||
end_at_str = request.form.get("end_at") or ""
|
||||
@ -281,7 +252,6 @@ def overrides_update(override_id: int):
|
||||
ov.object_name = object_name if level == "object" else None
|
||||
ov.match_status = match_status
|
||||
ov.match_error_contains = match_error_contains
|
||||
ov.match_error_mode = match_error_mode
|
||||
ov.treat_as_success = treat_as_success
|
||||
ov.comment = comment
|
||||
ov.start_at = start_at
|
||||
|
||||
@ -1,16 +1,94 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
|
||||
# Keep the parser overview page in sync with the actual parser registry.
|
||||
from ..parsers.registry import PARSER_DEFINITIONS
|
||||
|
||||
@main_bp.route("/parsers")
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
def parsers_overview():
|
||||
parsers = sorted(
|
||||
PARSER_DEFINITIONS,
|
||||
key=lambda p: (p.get("order", 9999), p.get("backup_software", ""), p.get("name", "")),
|
||||
)
|
||||
# Only show what is currently implemented in code.
|
||||
# Currently implemented parsers:
|
||||
# - 3CX (Backup Complete notifications)
|
||||
# - Veeam (status mails in multiple variants)
|
||||
parsers = [
|
||||
{
|
||||
"name": "3CX backup complete",
|
||||
"backup_software": "3CX",
|
||||
"backup_types": [],
|
||||
"order": 10,
|
||||
"enabled": True,
|
||||
"match": {
|
||||
"subject_regex": r"^3CX Notification:\\s*Backup Complete\\s*-\\s*(.+)$",
|
||||
},
|
||||
"description": "Parses 3CX backup notifications (Backup Complete).",
|
||||
"examples": [
|
||||
{
|
||||
"subject": "3CX Notification: Backup Complete - PBX01",
|
||||
"from_address": "noreply@3cx.local",
|
||||
"body_snippet": "Backup name: PBX01_2025-12-17.zip",
|
||||
"parsed_result": {
|
||||
"backup_software": "3CX",
|
||||
"backup_type": "",
|
||||
"job_name": "PBX01",
|
||||
"objects": [
|
||||
{
|
||||
"name": "PBX01_2025-12-17.zip",
|
||||
"status": "Success",
|
||||
"error_message": "",
|
||||
}
|
||||
],
|
||||
},
|
||||
}
|
||||
],
|
||||
},
|
||||
{
|
||||
"name": "Veeam status mails",
|
||||
"backup_software": "Veeam",
|
||||
"backup_types": [
|
||||
"Backup Job",
|
||||
"Backup Copy Job",
|
||||
"Replica Job",
|
||||
"Replication job",
|
||||
"Configuration Backup",
|
||||
"Agent Backup job",
|
||||
"Veeam Backup for Microsoft 365",
|
||||
"Scale Out Back-up Repository",
|
||||
],
|
||||
"order": 20,
|
||||
"enabled": True,
|
||||
"match": {
|
||||
"subject_regex": r"\\[(Success|Warning|Failed)\\]\\s*(.+)$",
|
||||
},
|
||||
"description": "Parses Veeam status mails. Job name/type are preferably extracted from the HTML header to avoid subject suffix noise.",
|
||||
"examples": [
|
||||
{
|
||||
"subject": "[Warning] Daily-VM-Backup (3 objects) 1 warning",
|
||||
"from_address": "veeam@customer.local",
|
||||
"body_snippet": "Backup job: Daily-VM-Backup\\n...",
|
||||
"parsed_result": {
|
||||
"backup_software": "Veeam",
|
||||
"backup_type": "Backup job",
|
||||
"job_name": "Daily-VM-Backup",
|
||||
"objects": [
|
||||
{"name": "VM-APP01", "status": "Success", "error_message": ""},
|
||||
{"name": "VM-DB01", "status": "Warning", "error_message": "Low disk space"},
|
||||
],
|
||||
},
|
||||
},
|
||||
{
|
||||
"subject": "[Success] Offsite-Repository",
|
||||
"from_address": "veeam@customer.local",
|
||||
"body_snippet": "Backup Copy job: Offsite-Repository\\n...",
|
||||
"parsed_result": {
|
||||
"backup_software": "Veeam",
|
||||
"backup_type": "Backup Copy job",
|
||||
"job_name": "Offsite-Repository",
|
||||
"objects": [
|
||||
{"name": "Backup Copy Chain", "status": "Success", "error_message": ""}
|
||||
],
|
||||
},
|
||||
},
|
||||
],
|
||||
},
|
||||
]
|
||||
|
||||
return render_template(
|
||||
"main/parsers.html",
|
||||
|
||||
@ -1,13 +1,23 @@
|
||||
from .routes_shared import * # noqa: F401,F403
|
||||
from .routes_shared import _format_datetime
|
||||
|
||||
@main_bp.route("/remarks/<int:remark_id>", methods=["GET"])
|
||||
@main_bp.route("/remarks/<int:remark_id>", methods=["GET", "POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def remark_detail(remark_id: int):
|
||||
remark = Remark.query.get_or_404(remark_id)
|
||||
|
||||
# Remark editing is disabled. Resolve the old remark and create a new one instead.
|
||||
if request.method == "POST":
|
||||
if get_active_role() not in ("admin", "operator"):
|
||||
abort(403)
|
||||
remark.body = (request.form.get("body") or "").strip() or ""
|
||||
try:
|
||||
db.session.commit()
|
||||
flash("Remark updated.", "success")
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
flash(f"Failed to update remark: {exc}", "danger")
|
||||
return redirect(url_for("main.remark_detail", remark_id=remark.id))
|
||||
|
||||
scopes = RemarkScope.query.filter(RemarkScope.remark_id == remark.id).order_by(RemarkScope.id.asc()).all()
|
||||
|
||||
|
||||
@ -331,17 +331,14 @@ def build_report_columns_meta():
|
||||
def build_report_job_filters_meta():
|
||||
"""Build job filter metadata for reporting UIs.
|
||||
|
||||
Provides available backup_softwares and backup_types derived from jobs that have runs.
|
||||
Provides available backup_softwares and backup_types derived from active jobs.
|
||||
"""
|
||||
# Distinct values across jobs with runs (exclude known informational jobs).
|
||||
# Distinct values across active jobs (exclude known informational jobs).
|
||||
info_backup_types = {"license key"}
|
||||
|
||||
# Distinct values across jobs that actually have at least one run.
|
||||
rows = (
|
||||
db.session.query(Job.backup_software, Job.backup_type)
|
||||
.select_from(Job)
|
||||
.join(JobRun, JobRun.job_id == Job.id)
|
||||
.distinct()
|
||||
.filter(Job.active.is_(True))
|
||||
.all()
|
||||
)
|
||||
|
||||
@ -352,18 +349,9 @@ def build_report_job_filters_meta():
|
||||
for bs, bt in rows:
|
||||
bs_val = (bs or "").strip()
|
||||
bt_val = (bt or "").strip()
|
||||
# Exclude known informational types.
|
||||
if bt_val.lower() in info_backup_types:
|
||||
continue
|
||||
|
||||
# Synology DSM Updates are informational and should never appear in reports.
|
||||
if (bs_val or "").strip().lower() == "synology" and bt_val.lower() == "updates":
|
||||
continue
|
||||
|
||||
# QNAP firmware update notifications are informational and should never appear in reports.
|
||||
if (bs_val or "").strip().lower() == "qnap" and bt_val.lower() == "firmware update":
|
||||
continue
|
||||
|
||||
if bs_val:
|
||||
backup_softwares_set.add(bs_val)
|
||||
if bt_val:
|
||||
@ -385,7 +373,7 @@ def build_report_job_filters_meta():
|
||||
"backup_softwares": backup_softwares,
|
||||
"backup_types": backup_types,
|
||||
"by_backup_software": by_backup_software_out,
|
||||
"excluded_backup_types": ["License Key", "Updates (Synology)", "Firmware Update (QNAP)"],
|
||||
"excluded_backup_types": ["License Key"],
|
||||
}
|
||||
|
||||
|
||||
@ -508,11 +496,7 @@ def api_reports_generate(report_id: int):
|
||||
where_customer = ""
|
||||
params = {"rid": report_id, "start_ts": report.period_start, "end_ts": report.period_end}
|
||||
# Job filters from report_config
|
||||
where_filters = (
|
||||
" AND COALESCE(j.backup_type,'') NOT ILIKE 'license key' "
|
||||
" AND NOT (LOWER(COALESCE(j.backup_software,'')) = 'synology' AND LOWER(COALESCE(j.backup_type,'')) = 'updates') "
|
||||
" AND NOT (LOWER(COALESCE(j.backup_software,'')) = 'qnap' AND LOWER(COALESCE(j.backup_type,'')) = 'firmware update') "
|
||||
)
|
||||
where_filters = " AND COALESCE(j.backup_type,'') NOT ILIKE 'license key' "
|
||||
rc = _safe_json_dict(getattr(report, "report_config", None))
|
||||
filters = rc.get("filters") if isinstance(rc, dict) else None
|
||||
if isinstance(filters, dict):
|
||||
|
||||
@ -1,7 +1,5 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import calendar
|
||||
|
||||
from datetime import date, datetime, time, timedelta, timezone
|
||||
|
||||
from flask import jsonify, render_template, request
|
||||
@ -15,40 +13,19 @@ from .routes_shared import (
|
||||
_get_ui_timezone_name,
|
||||
_get_or_create_settings,
|
||||
_infer_schedule_map_from_runs,
|
||||
_infer_monthly_schedule_from_runs,
|
||||
_to_amsterdam_date,
|
||||
main_bp,
|
||||
roles_required,
|
||||
get_active_role,
|
||||
)
|
||||
from ..database import db
|
||||
from ..email_utils import extract_best_html_from_eml, is_effectively_blank_html
|
||||
from ..models import (
|
||||
Customer,
|
||||
Job,
|
||||
JobObject,
|
||||
JobRun,
|
||||
JobRunReviewEvent,
|
||||
MailMessage,
|
||||
MailObject,
|
||||
Override,
|
||||
User,
|
||||
)
|
||||
from ..models import Customer, Job, JobRun, JobRunReviewEvent, MailMessage, User
|
||||
|
||||
# Grace window for matching real runs to an expected schedule slot.
|
||||
# A run within +/- 1 hour of the inferred schedule time counts as fulfilling the slot.
|
||||
MISSED_GRACE_WINDOW = timedelta(hours=1)
|
||||
|
||||
|
||||
def _status_is_success(status: str | None) -> bool:
|
||||
s = (status or "").strip().lower()
|
||||
if not s:
|
||||
return False
|
||||
if "override" in s:
|
||||
return True
|
||||
return "success" in s
|
||||
|
||||
|
||||
def _utc_naive_from_local(dt_local: datetime) -> datetime:
|
||||
"""Convert a timezone-aware local datetime to UTC naive, matching DB convention."""
|
||||
if dt_local.tzinfo is None:
|
||||
@ -98,13 +75,7 @@ def _ensure_missed_runs_for_job(job: Job, start_from: date, end_inclusive: date)
|
||||
"""
|
||||
tz = _get_ui_timezone()
|
||||
schedule_map = _infer_schedule_map_from_runs(job.id) or {}
|
||||
has_weekly_times = any((schedule_map.get(i) or []) for i in range(7))
|
||||
|
||||
monthly = None
|
||||
if not has_weekly_times:
|
||||
monthly = _infer_monthly_schedule_from_runs(job.id)
|
||||
|
||||
if (not has_weekly_times) and (not monthly):
|
||||
if not schedule_map:
|
||||
return 0
|
||||
|
||||
today_local = _to_amsterdam_date(datetime.utcnow()) or datetime.utcnow().date()
|
||||
@ -113,8 +84,6 @@ def _ensure_missed_runs_for_job(job: Job, start_from: date, end_inclusive: date)
|
||||
|
||||
now_local_dt = datetime.now(tz) if tz else datetime.utcnow()
|
||||
|
||||
|
||||
now_utc_naive = _utc_naive_from_local(now_local_dt)
|
||||
# Remove any previously generated missed runs in this date window.
|
||||
# Missed runs must be based on learned schedule from real mail-reported runs.
|
||||
try:
|
||||
@ -142,8 +111,6 @@ def _ensure_missed_runs_for_job(job: Job, start_from: date, end_inclusive: date)
|
||||
inserted = 0
|
||||
d = start_from
|
||||
while d <= end_inclusive:
|
||||
if not has_weekly_times:
|
||||
break
|
||||
weekday = d.weekday()
|
||||
times = schedule_map.get(weekday) or []
|
||||
if not times:
|
||||
@ -166,15 +133,6 @@ def _ensure_missed_runs_for_job(job: Job, start_from: date, end_inclusive: date)
|
||||
|
||||
slot_utc_naive = _utc_naive_from_local(local_dt)
|
||||
|
||||
|
||||
|
||||
# Do not mark as missed until the full grace window has passed.
|
||||
|
||||
|
||||
if now_utc_naive <= (slot_utc_naive + MISSED_GRACE_WINDOW):
|
||||
|
||||
|
||||
continue
|
||||
# Consider any real run near the slot as fulfilling the schedule.
|
||||
# Also avoid duplicates if a missed run already exists.
|
||||
window_start = slot_utc_naive - MISSED_GRACE_WINDOW
|
||||
@ -210,91 +168,6 @@ def _ensure_missed_runs_for_job(job: Job, start_from: date, end_inclusive: date)
|
||||
|
||||
d = d + timedelta(days=1)
|
||||
|
||||
|
||||
# Monthly expected slots (fallback when no stable weekly schedule is detected)
|
||||
if (not has_weekly_times) and monthly:
|
||||
try:
|
||||
dom = int(monthly.get("day_of_month") or 0)
|
||||
except Exception:
|
||||
dom = 0
|
||||
times = monthly.get("times") or []
|
||||
|
||||
if dom > 0 and times:
|
||||
# Iterate months in the window [start_from, end_inclusive]
|
||||
cur = date(start_from.year, start_from.month, 1)
|
||||
end_marker = date(end_inclusive.year, end_inclusive.month, 1)
|
||||
|
||||
while cur <= end_marker:
|
||||
try:
|
||||
last_dom = calendar.monthrange(cur.year, cur.month)[1]
|
||||
except Exception:
|
||||
last_dom = 28
|
||||
scheduled_dom = dom if dom <= last_dom else last_dom
|
||||
scheduled_date = date(cur.year, cur.month, scheduled_dom)
|
||||
|
||||
if scheduled_date >= start_from and scheduled_date <= end_inclusive:
|
||||
for hhmm in times:
|
||||
hm = _parse_hhmm(hhmm)
|
||||
if not hm:
|
||||
continue
|
||||
hh, mm = hm
|
||||
|
||||
local_dt = datetime.combine(scheduled_date, time(hour=hh, minute=mm))
|
||||
if tz:
|
||||
local_dt = local_dt.replace(tzinfo=tz)
|
||||
|
||||
# Only generate missed runs for past slots.
|
||||
if local_dt > now_local_dt:
|
||||
continue
|
||||
|
||||
slot_utc_naive = _utc_naive_from_local(local_dt)
|
||||
|
||||
|
||||
|
||||
# Do not mark as missed until the full grace window has passed.
|
||||
|
||||
|
||||
if now_utc_naive <= (slot_utc_naive + MISSED_GRACE_WINDOW):
|
||||
|
||||
|
||||
continue
|
||||
window_start = slot_utc_naive - MISSED_GRACE_WINDOW
|
||||
window_end = slot_utc_naive + MISSED_GRACE_WINDOW
|
||||
|
||||
exists = (
|
||||
db.session.query(JobRun.id)
|
||||
.filter(
|
||||
JobRun.job_id == job.id,
|
||||
JobRun.run_at.isnot(None),
|
||||
or_(
|
||||
and_(JobRun.missed.is_(False), JobRun.mail_message_id.isnot(None)),
|
||||
and_(JobRun.missed.is_(True), JobRun.mail_message_id.is_(None)),
|
||||
),
|
||||
JobRun.run_at >= window_start,
|
||||
JobRun.run_at <= window_end,
|
||||
)
|
||||
.first()
|
||||
)
|
||||
if exists:
|
||||
continue
|
||||
|
||||
miss = JobRun(
|
||||
job_id=job.id,
|
||||
run_at=slot_utc_naive,
|
||||
status="Missed",
|
||||
missed=True,
|
||||
remark=None,
|
||||
mail_message_id=None,
|
||||
)
|
||||
db.session.add(miss)
|
||||
inserted += 1
|
||||
|
||||
# Next month
|
||||
if cur.month == 12:
|
||||
cur = date(cur.year + 1, 1, 1)
|
||||
else:
|
||||
cur = date(cur.year, cur.month + 1, 1)
|
||||
|
||||
if inserted:
|
||||
db.session.commit()
|
||||
return inserted
|
||||
@ -322,7 +195,7 @@ def run_checks_page():
|
||||
)
|
||||
last_reviewed_map = {int(jid): (dt if dt else None) for jid, dt in last_reviewed_rows}
|
||||
|
||||
jobs = Job.query.filter(Job.archived.is_(False)).all()
|
||||
jobs = Job.query.all()
|
||||
today_local = _to_amsterdam_date(datetime.utcnow()) or datetime.utcnow().date()
|
||||
|
||||
for job in jobs:
|
||||
@ -349,7 +222,6 @@ def run_checks_page():
|
||||
)
|
||||
.select_from(Job)
|
||||
.outerjoin(Customer, Customer.id == Job.customer_id)
|
||||
.filter(Job.archived.is_(False))
|
||||
)
|
||||
|
||||
# Runs to show in the overview: unreviewed (or all if admin toggle enabled)
|
||||
@ -536,8 +408,8 @@ def run_checks_page():
|
||||
WHERE ts.job_id = :job_id
|
||||
AND t.active_from_date <= :run_date
|
||||
AND (
|
||||
COALESCE(ts.resolved_at, t.resolved_at) IS NULL
|
||||
OR ((COALESCE(ts.resolved_at, t.resolved_at) AT TIME ZONE 'UTC' AT TIME ZONE :ui_tz)::date) >= :run_date
|
||||
t.resolved_at IS NULL
|
||||
OR ((t.resolved_at AT TIME ZONE 'UTC' AT TIME ZONE :ui_tz)::date) >= :run_date
|
||||
)
|
||||
LIMIT 1
|
||||
"""
|
||||
@ -639,34 +511,10 @@ def run_checks_details():
|
||||
"subject": msg.subject or "",
|
||||
"received_at": _format_datetime(msg.received_at),
|
||||
}
|
||||
def _is_blank_text(s):
|
||||
return s is None or (isinstance(s, str) and s.strip() == "")
|
||||
|
||||
html_body = getattr(msg, "html_body", None)
|
||||
text_body = getattr(msg, "text_body", None)
|
||||
|
||||
# Keep Run Checks consistent with Inbox/All Mail: if the Graph body is empty but the
|
||||
# real report is stored as an HTML attachment inside the EML, extract it.
|
||||
if is_effectively_blank_html(html_body) and _is_blank_text(text_body) and getattr(msg, "eml_blob", None):
|
||||
extracted = extract_best_html_from_eml(getattr(msg, "eml_blob", None))
|
||||
if extracted:
|
||||
html_body = extracted
|
||||
|
||||
if not is_effectively_blank_html(html_body):
|
||||
body_html = html_body
|
||||
elif not _is_blank_text(text_body):
|
||||
escaped = (
|
||||
text_body.replace("&", "&")
|
||||
.replace("<", "<")
|
||||
.replace(">", ">")
|
||||
)
|
||||
body_html = f"<pre>{escaped}</pre>"
|
||||
else:
|
||||
body_html = "<p>No message content stored.</p>"
|
||||
body_html = msg.html_body or ""
|
||||
has_eml = bool(getattr(msg, "eml_stored_at", None))
|
||||
|
||||
objects_payload = []
|
||||
# Preferred: read persisted objects for this run from run_object_links/customer_objects (Step 2).
|
||||
try:
|
||||
rows = (
|
||||
db.session.execute(
|
||||
@ -697,40 +545,7 @@ def run_checks_details():
|
||||
}
|
||||
)
|
||||
except Exception:
|
||||
# Fallback for older data / during upgrades
|
||||
try:
|
||||
objects = run.objects.order_by(JobObject.object_name.asc()).all()
|
||||
except Exception:
|
||||
objects = list(run.objects or [])
|
||||
|
||||
for obj in objects:
|
||||
objects_payload.append(
|
||||
{
|
||||
"name": obj.object_name,
|
||||
"type": getattr(obj, "object_type", "") or "",
|
||||
"status": obj.status or "",
|
||||
"error_message": obj.error_message or "",
|
||||
}
|
||||
)
|
||||
|
||||
# If no run-linked objects exist yet, fall back to objects parsed/stored on the mail message.
|
||||
if (not objects_payload) and msg:
|
||||
try:
|
||||
for mo in (
|
||||
MailObject.query.filter_by(mail_message_id=msg.id)
|
||||
.order_by(MailObject.object_name.asc())
|
||||
.all()
|
||||
):
|
||||
objects_payload.append(
|
||||
{
|
||||
"name": mo.object_name or "",
|
||||
"type": mo.object_type or "",
|
||||
"status": mo.status or "",
|
||||
"error_message": mo.error_message or "",
|
||||
}
|
||||
)
|
||||
except Exception:
|
||||
pass
|
||||
objects_payload = []
|
||||
|
||||
status_display = run.status or "-"
|
||||
try:
|
||||
@ -744,7 +559,6 @@ def run_checks_details():
|
||||
"run_at": _format_datetime(run.run_at) if run.run_at else "-",
|
||||
"status": status_display,
|
||||
"remark": run.remark or "",
|
||||
"overall_message": (getattr(msg, "overall_message", None) or "") if msg else "",
|
||||
"missed": bool(run.missed),
|
||||
"is_reviewed": bool(run.reviewed_at),
|
||||
"reviewed_at": _format_datetime(run.reviewed_at) if (get_active_role() == "admin" and run.reviewed_at) else "",
|
||||
@ -877,148 +691,3 @@ def api_run_checks_unmark_reviewed():
|
||||
|
||||
db.session.commit()
|
||||
return jsonify({"status": "ok", "updated": updated, "skipped": skipped})
|
||||
|
||||
|
||||
@main_bp.post("/api/run-checks/mark-success-override")
|
||||
@login_required
|
||||
@roles_required("admin", "operator")
|
||||
def api_run_checks_mark_success_override():
|
||||
"""Create a time-bounded override so the selected run is treated as Success (override)."""
|
||||
data = request.get_json(silent=True) or {}
|
||||
try:
|
||||
run_id = int(data.get("run_id") or 0)
|
||||
except Exception:
|
||||
run_id = 0
|
||||
|
||||
if run_id <= 0:
|
||||
return jsonify({"status": "error", "message": "Invalid run_id."}), 400
|
||||
|
||||
run = JobRun.query.get_or_404(run_id)
|
||||
job = Job.query.get_or_404(run.job_id)
|
||||
|
||||
# Do not allow overriding a missed placeholder run.
|
||||
if bool(getattr(run, "missed", False)):
|
||||
return jsonify({"status": "error", "message": "Missed runs cannot be marked as success."}), 400
|
||||
|
||||
# If it is already a success or already overridden, do nothing.
|
||||
if bool(getattr(run, "override_applied", False)):
|
||||
return jsonify({"status": "ok", "message": "Already overridden."})
|
||||
|
||||
if _status_is_success(getattr(run, "status", None)):
|
||||
return jsonify({"status": "ok", "message": "Already successful."})
|
||||
|
||||
# Build a tight validity window around this run.
|
||||
run_ts = getattr(run, "run_at", None) or getattr(run, "created_at", None) or datetime.utcnow()
|
||||
start_at = run_ts - timedelta(minutes=1)
|
||||
end_at = run_ts + timedelta(minutes=1)
|
||||
|
||||
comment = (data.get("comment") or "").strip()
|
||||
if not comment:
|
||||
# Keep it short and consistent; Operators will typically include a ticket number separately.
|
||||
comment = "Marked as success from Run Checks"
|
||||
comment = comment[:2000]
|
||||
|
||||
created_any = False
|
||||
|
||||
# Prefer object-level overrides (scoped to this job) to avoid impacting other jobs.
|
||||
obj_rows = []
|
||||
try:
|
||||
obj_rows = (
|
||||
db.session.execute(
|
||||
text(
|
||||
"""
|
||||
SELECT
|
||||
co.object_name AS object_name,
|
||||
rol.status AS status,
|
||||
rol.error_message AS error_message
|
||||
FROM run_object_links rol
|
||||
JOIN customer_objects co ON co.id = rol.customer_object_id
|
||||
WHERE rol.run_id = :run_id
|
||||
ORDER BY co.object_name ASC
|
||||
"""
|
||||
),
|
||||
{"run_id": run.id},
|
||||
)
|
||||
.mappings()
|
||||
.all()
|
||||
)
|
||||
except Exception:
|
||||
obj_rows = []
|
||||
|
||||
def _obj_is_problem(status: str | None) -> bool:
|
||||
s = (status or "").strip().lower()
|
||||
if not s:
|
||||
return False
|
||||
if "success" in s:
|
||||
return False
|
||||
if "override" in s:
|
||||
return False
|
||||
return True
|
||||
|
||||
for rr in obj_rows or []:
|
||||
obj_name = (rr.get("object_name") or "").strip()
|
||||
obj_status = (rr.get("status") or "").strip()
|
||||
if (not obj_name) or (not _obj_is_problem(obj_status)):
|
||||
continue
|
||||
|
||||
err = (rr.get("error_message") or "").strip()
|
||||
ov = Override(
|
||||
level="object",
|
||||
job_id=job.id,
|
||||
object_name=obj_name,
|
||||
match_status=(obj_status or None),
|
||||
match_error_contains=(err[:255] if err else None),
|
||||
match_error_mode=("contains" if err else None),
|
||||
treat_as_success=True,
|
||||
active=True,
|
||||
comment=comment,
|
||||
created_by=current_user.username,
|
||||
start_at=start_at,
|
||||
end_at=end_at,
|
||||
)
|
||||
db.session.add(ov)
|
||||
created_any = True
|
||||
|
||||
# If we couldn't build a safe object-scoped override, fall back to a very tight global override.
|
||||
if not created_any:
|
||||
match_error_contains = (getattr(run, "remark", None) or "").strip()
|
||||
if not match_error_contains:
|
||||
# As a last resort, try to match any error message from legacy objects.
|
||||
try:
|
||||
objs = list(run.objects) if hasattr(run, "objects") else []
|
||||
except Exception:
|
||||
objs = []
|
||||
for obj in objs or []:
|
||||
em = (getattr(obj, "error_message", None) or "").strip()
|
||||
if em:
|
||||
match_error_contains = em
|
||||
break
|
||||
|
||||
ov = Override(
|
||||
level="global",
|
||||
backup_software=job.backup_software or None,
|
||||
backup_type=job.backup_type or None,
|
||||
match_status=(getattr(run, "status", None) or None),
|
||||
match_error_contains=(match_error_contains[:255] if match_error_contains else None),
|
||||
match_error_mode=("contains" if match_error_contains else None),
|
||||
treat_as_success=True,
|
||||
active=True,
|
||||
comment=comment,
|
||||
created_by=current_user.username,
|
||||
start_at=start_at,
|
||||
end_at=end_at,
|
||||
)
|
||||
db.session.add(ov)
|
||||
created_any = True
|
||||
|
||||
db.session.commit()
|
||||
|
||||
# Recompute flags so the overview and modal reflect the override immediately.
|
||||
try:
|
||||
from .routes_shared import _recompute_override_flags_for_runs
|
||||
|
||||
_recompute_override_flags_for_runs(job_ids=[job.id], start_at=start_at, end_at=end_at, only_unreviewed=False)
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
return jsonify({"status": "ok", "message": "Override created."})
|
||||
|
||||
@ -169,7 +169,7 @@ def settings_objects_backfill():
|
||||
|
||||
for r in rows:
|
||||
try:
|
||||
repaired_objects += persist_objects_for_auto_run(
|
||||
repaired_objects += persist_objects_for_approved_run(
|
||||
int(r[2]), int(r[1]), int(r[0]), int(r[3])
|
||||
)
|
||||
repaired_runs += 1
|
||||
@ -586,15 +586,6 @@ def settings():
|
||||
news_admin_stats = {}
|
||||
|
||||
|
||||
users = User.query.order_by(User.username.asc()).all()
|
||||
|
||||
# Count users that have 'admin' among their assigned roles (comma-separated storage)
|
||||
admin_users_count = 0
|
||||
try:
|
||||
admin_users_count = sum(1 for u in users if "admin" in (getattr(u, "roles", None) or []))
|
||||
except Exception:
|
||||
admin_users_count = 0
|
||||
|
||||
return render_template(
|
||||
"main/settings.html",
|
||||
settings=settings,
|
||||
@ -603,8 +594,7 @@ def settings():
|
||||
free_disk_warning=free_disk_warning,
|
||||
has_client_secret=has_client_secret,
|
||||
tz_options=tz_options,
|
||||
users=users,
|
||||
admin_users_count=admin_users_count,
|
||||
users=User.query.order_by(User.username.asc()).all(),
|
||||
section=section,
|
||||
news_admin_items=news_admin_items,
|
||||
news_admin_stats=news_admin_stats,
|
||||
@ -925,53 +915,6 @@ def settings_users_reset_password(user_id: int):
|
||||
return redirect(url_for("main.settings", section="users"))
|
||||
|
||||
|
||||
@main_bp.route("/settings/users/<int:user_id>/roles", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
def settings_users_update_roles(user_id: int):
|
||||
user = User.query.get_or_404(user_id)
|
||||
|
||||
roles = [r.strip() for r in request.form.getlist("roles") if (r or "").strip()]
|
||||
roles = list(dict.fromkeys(roles))
|
||||
if not roles:
|
||||
roles = ["viewer"]
|
||||
|
||||
# Prevent removing the last remaining admin role
|
||||
removing_admin = ("admin" in user.roles) and ("admin" not in roles)
|
||||
if removing_admin:
|
||||
try:
|
||||
all_users = User.query.all()
|
||||
admin_count = sum(1 for u in all_users if "admin" in (getattr(u, "roles", None) or []))
|
||||
except Exception:
|
||||
admin_count = 0
|
||||
|
||||
if admin_count <= 1:
|
||||
flash("Cannot remove admin role from the last admin account.", "danger")
|
||||
return redirect(url_for("main.settings", section="users"))
|
||||
|
||||
old_roles = ",".join(user.roles)
|
||||
new_roles = ",".join(roles)
|
||||
user.role = new_roles
|
||||
|
||||
try:
|
||||
db.session.commit()
|
||||
flash(f"Roles for '{user.username}' have been updated.", "success")
|
||||
_log_admin_event("user_update_roles", f"User '{user.username}' roles changed from '{old_roles}' to '{new_roles}'.")
|
||||
|
||||
# If the updated user is currently logged in, make sure the active role stays valid.
|
||||
try:
|
||||
if getattr(current_user, "id", None) == user.id:
|
||||
current_user.set_active_role(user.roles[0])
|
||||
except Exception:
|
||||
pass
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
print(f"[settings-users] Failed to update roles: {exc}")
|
||||
flash("Failed to update roles.", "danger")
|
||||
|
||||
return redirect(url_for("main.settings", section="users"))
|
||||
|
||||
|
||||
@main_bp.route("/settings/users/<int:user_id>/delete", methods=["POST"])
|
||||
@login_required
|
||||
@roles_required("admin")
|
||||
@ -979,13 +922,8 @@ def settings_users_delete(user_id: int):
|
||||
user = User.query.get_or_404(user_id)
|
||||
|
||||
# Prevent deleting the last admin user
|
||||
if "admin" in user.roles:
|
||||
try:
|
||||
all_users = User.query.all()
|
||||
admin_count = sum(1 for u in all_users if "admin" in (getattr(u, "roles", None) or []))
|
||||
except Exception:
|
||||
admin_count = 0
|
||||
|
||||
if user.role == "admin":
|
||||
admin_count = User.query.filter_by(role="admin").count()
|
||||
if admin_count <= 1:
|
||||
flash("Cannot delete the last admin account.", "danger")
|
||||
return redirect(url_for("main.settings", section="general"))
|
||||
@ -1057,7 +995,7 @@ def settings_mail_import():
|
||||
persisted_errors = 0
|
||||
for (customer_id, job_id, run_id, mail_message_id) in auto_approved_runs:
|
||||
try:
|
||||
persisted_objects += persist_objects_for_auto_run(
|
||||
persisted_objects += persist_objects_for_approved_run(
|
||||
int(customer_id), int(job_id), int(run_id), int(mail_message_id)
|
||||
)
|
||||
except Exception as exc:
|
||||
|
||||
@ -6,7 +6,6 @@ import json
|
||||
import re
|
||||
import html as _html
|
||||
import math
|
||||
import calendar
|
||||
import datetime as datetime_module
|
||||
from functools import wraps
|
||||
|
||||
@ -51,7 +50,6 @@ from ..models import (
|
||||
RemarkJobRun,
|
||||
FeedbackItem,
|
||||
FeedbackVote,
|
||||
FeedbackReply,
|
||||
NewsItem,
|
||||
NewsRead,
|
||||
ReportDefinition,
|
||||
@ -60,7 +58,7 @@ from ..models import (
|
||||
)
|
||||
from ..mail_importer import run_manual_import, MailImportError
|
||||
from ..parsers import parse_mail_message
|
||||
from ..object_persistence import persist_objects_for_approved_run, persist_objects_for_auto_run
|
||||
from ..object_persistence import persist_objects_for_approved_run
|
||||
|
||||
|
||||
main_bp = Blueprint("main", __name__)
|
||||
@ -293,8 +291,7 @@ def _apply_overrides_to_run(job: Job, run: JobRun):
|
||||
try:
|
||||
mec = (getattr(ov, "match_error_contains", None) or "").strip()
|
||||
if mec:
|
||||
mem = (getattr(ov, "match_error_mode", None) or "contains").strip()
|
||||
parts.append(f"error_{mem}={mec}")
|
||||
parts.append(f"contains={mec}")
|
||||
except Exception:
|
||||
pass
|
||||
try:
|
||||
@ -343,40 +340,6 @@ def _apply_overrides_to_run(job: Job, run: JobRun):
|
||||
return False
|
||||
return needle.lower() in haystack.lower()
|
||||
|
||||
def _matches_error_text(haystack: str | None, needle: str | None, mode: str | None) -> bool:
|
||||
"""Match error text using a configured mode.
|
||||
|
||||
Modes:
|
||||
- contains (default)
|
||||
- exact
|
||||
- starts_with
|
||||
- ends_with
|
||||
|
||||
Matching is case-insensitive and trims surrounding whitespace.
|
||||
"""
|
||||
if not needle:
|
||||
return True
|
||||
if not haystack:
|
||||
return False
|
||||
|
||||
hs = (haystack or "").strip()
|
||||
nd = (needle or "").strip()
|
||||
if not hs:
|
||||
return False
|
||||
|
||||
hs_l = hs.lower()
|
||||
nd_l = nd.lower()
|
||||
m = (mode or "contains").strip().lower()
|
||||
|
||||
if m == "exact":
|
||||
return hs_l == nd_l
|
||||
if m in ("starts_with", "startswith", "start"):
|
||||
return hs_l.startswith(nd_l)
|
||||
if m in ("ends_with", "endswith", "end"):
|
||||
return hs_l.endswith(nd_l)
|
||||
# Default/fallback
|
||||
return nd_l in hs_l
|
||||
|
||||
def _matches_status(candidate: str | None, expected: str | None) -> bool:
|
||||
if not expected:
|
||||
return True
|
||||
@ -445,12 +408,12 @@ def _apply_overrides_to_run(job: Job, run: JobRun):
|
||||
|
||||
# Global overrides should match both the run-level remark and any object-level error messages.
|
||||
if ov.match_error_contains:
|
||||
if _matches_error_text(run.remark, ov.match_error_contains, getattr(ov, "match_error_mode", None)):
|
||||
if _contains(run.remark, ov.match_error_contains):
|
||||
return True
|
||||
|
||||
# Check persisted run-object error messages.
|
||||
for row in run_object_rows or []:
|
||||
if _matches_error_text(row.get("error_message"), ov.match_error_contains, getattr(ov, "match_error_mode", None)):
|
||||
if _contains(row.get("error_message"), ov.match_error_contains):
|
||||
return True
|
||||
|
||||
objs = []
|
||||
@ -459,7 +422,7 @@ def _apply_overrides_to_run(job: Job, run: JobRun):
|
||||
except Exception:
|
||||
objs = []
|
||||
for obj in objs or []:
|
||||
if _matches_error_text(getattr(obj, "error_message", None), ov.match_error_contains, getattr(ov, "match_error_mode", None)):
|
||||
if _contains(getattr(obj, "error_message", None), ov.match_error_contains):
|
||||
return True
|
||||
return False
|
||||
|
||||
@ -473,7 +436,7 @@ def _apply_overrides_to_run(job: Job, run: JobRun):
|
||||
continue
|
||||
if not _matches_status(row.get("status"), ov.match_status):
|
||||
continue
|
||||
if not _matches_error_text(row.get("error_message"), ov.match_error_contains, getattr(ov, "match_error_mode", None)):
|
||||
if not _contains(row.get("error_message"), ov.match_error_contains):
|
||||
continue
|
||||
return True
|
||||
|
||||
@ -488,7 +451,7 @@ def _apply_overrides_to_run(job: Job, run: JobRun):
|
||||
continue
|
||||
if not _matches_status(getattr(obj, "status", None), ov.match_status):
|
||||
continue
|
||||
if not _matches_error_text(getattr(obj, "error_message", None), ov.match_error_contains, getattr(ov, "match_error_mode", None)):
|
||||
if not _contains(getattr(obj, "error_message", None), ov.match_error_contains):
|
||||
continue
|
||||
return True
|
||||
|
||||
@ -648,13 +611,7 @@ def _infer_schedule_map_from_runs(job_id: int):
|
||||
"""Infer weekly schedule blocks (15-min) from historical runs.
|
||||
|
||||
Returns dict weekday->sorted list of 'HH:MM' strings in configured UI local time.
|
||||
|
||||
Notes:
|
||||
- Only considers real runs that came from mail reports (mail_message_id is not NULL).
|
||||
- Synthetic missed rows never influence schedule inference.
|
||||
- To reduce noise, a weekday/time bucket must occur at least MIN_OCCURRENCES times.
|
||||
"""
|
||||
MIN_OCCURRENCES = 3
|
||||
schedule = {i: [] for i in range(7)} # 0=Mon .. 6=Sun
|
||||
|
||||
# Certain job types are informational and should never participate in schedule
|
||||
@ -670,15 +627,10 @@ def _infer_schedule_map_from_runs(job_id: int):
|
||||
return schedule
|
||||
if bs == 'synology' and bt == 'account protection':
|
||||
return schedule
|
||||
if bs == 'synology' and bt == 'updates':
|
||||
return schedule
|
||||
if bs == 'qnap' and bt == 'firmware update':
|
||||
return schedule
|
||||
if bs == 'syncovery' and bt == 'syncovery':
|
||||
return schedule
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
try:
|
||||
# Only infer schedules from real runs that came from mail reports.
|
||||
# Synthetic "Missed" rows must never influence schedule inference.
|
||||
@ -700,13 +652,13 @@ def _infer_schedule_map_from_runs(job_id: int):
|
||||
if not runs:
|
||||
return schedule
|
||||
|
||||
# Convert run_at to UI local time and bucket into 15-minute blocks.
|
||||
# Convert run_at to UI local time and bucket into 15-minute blocks
|
||||
try:
|
||||
tz = _get_ui_timezone()
|
||||
except Exception:
|
||||
tz = None
|
||||
|
||||
counts = {i: {} for i in range(7)} # weekday -> { "HH:MM": count }
|
||||
seen = {i: set() for i in range(7)}
|
||||
for r in runs:
|
||||
if not r.run_at:
|
||||
continue
|
||||
@ -725,139 +677,14 @@ def _infer_schedule_map_from_runs(job_id: int):
|
||||
minute_bucket = (dt.minute // 15) * 15
|
||||
hh = dt.hour
|
||||
tstr = f"{hh:02d}:{minute_bucket:02d}"
|
||||
counts[wd][tstr] = int(counts[wd].get(tstr, 0)) + 1
|
||||
seen[wd].add(tstr)
|
||||
|
||||
for wd in range(7):
|
||||
# Keep only buckets that occur frequently enough.
|
||||
keep = [t for t, c in counts[wd].items() if int(c) >= MIN_OCCURRENCES]
|
||||
schedule[wd] = sorted(keep)
|
||||
schedule[wd] = sorted(seen[wd])
|
||||
|
||||
return schedule
|
||||
|
||||
|
||||
def _infer_monthly_schedule_from_runs(job_id: int):
|
||||
"""Infer a monthly schedule from historical runs.
|
||||
|
||||
Returns:
|
||||
dict with keys:
|
||||
- day_of_month (int)
|
||||
- times (list[str] of 'HH:MM' 15-min buckets)
|
||||
or None if not enough evidence.
|
||||
|
||||
Rules:
|
||||
- Uses only real mail-based runs (mail_message_id is not NULL) and excludes synthetic missed rows.
|
||||
- Requires at least MIN_OCCURRENCES occurrences for the inferred day-of-month.
|
||||
- Uses a simple cadence heuristic: typical gaps between runs must be >= 20 days to qualify as monthly.
|
||||
"""
|
||||
MIN_OCCURRENCES = 3
|
||||
|
||||
try:
|
||||
# Same "real run" rule as weekly inference.
|
||||
runs = (
|
||||
JobRun.query
|
||||
.filter(
|
||||
JobRun.job_id == job_id,
|
||||
JobRun.run_at.isnot(None),
|
||||
JobRun.missed.is_(False),
|
||||
JobRun.mail_message_id.isnot(None),
|
||||
)
|
||||
.order_by(JobRun.run_at.asc())
|
||||
.limit(500)
|
||||
.all()
|
||||
)
|
||||
except Exception:
|
||||
runs = []
|
||||
|
||||
if len(runs) < MIN_OCCURRENCES:
|
||||
return None
|
||||
|
||||
try:
|
||||
tz = _get_ui_timezone()
|
||||
except Exception:
|
||||
tz = None
|
||||
|
||||
# Convert and keep local datetimes.
|
||||
local_dts = []
|
||||
for r in runs:
|
||||
if not r.run_at:
|
||||
continue
|
||||
dt = r.run_at
|
||||
if tz is not None:
|
||||
try:
|
||||
if dt.tzinfo is None:
|
||||
dt = dt.replace(tzinfo=datetime_module.timezone.utc).astimezone(tz)
|
||||
else:
|
||||
dt = dt.astimezone(tz)
|
||||
except Exception:
|
||||
pass
|
||||
local_dts.append(dt)
|
||||
|
||||
if len(local_dts) < MIN_OCCURRENCES:
|
||||
return None
|
||||
|
||||
# Cadence heuristic: monthly jobs shouldn't look weekly.
|
||||
local_dts_sorted = sorted(local_dts)
|
||||
gaps = []
|
||||
for i in range(1, len(local_dts_sorted)):
|
||||
try:
|
||||
delta_days = (local_dts_sorted[i] - local_dts_sorted[i - 1]).total_seconds() / 86400.0
|
||||
if delta_days > 0:
|
||||
gaps.append(delta_days)
|
||||
except Exception:
|
||||
continue
|
||||
|
||||
if gaps:
|
||||
gaps_sorted = sorted(gaps)
|
||||
median_gap = gaps_sorted[len(gaps_sorted) // 2]
|
||||
# If it looks like a weekly/daily cadence, do not classify as monthly.
|
||||
if median_gap < 20.0:
|
||||
return None
|
||||
|
||||
# Count day-of-month occurrences and time buckets on that day.
|
||||
dom_counts = {}
|
||||
time_counts_by_dom = {} # dom -> { "HH:MM": count }
|
||||
for dt in local_dts:
|
||||
dom = int(dt.day)
|
||||
dom_counts[dom] = int(dom_counts.get(dom, 0)) + 1
|
||||
|
||||
minute_bucket = (dt.minute // 15) * 15
|
||||
tstr = f"{int(dt.hour):02d}:{int(minute_bucket):02d}"
|
||||
if dom not in time_counts_by_dom:
|
||||
time_counts_by_dom[dom] = {}
|
||||
time_counts_by_dom[dom][tstr] = int(time_counts_by_dom[dom].get(tstr, 0)) + 1
|
||||
|
||||
# Pick the most common day-of-month with enough occurrences.
|
||||
best_dom = None
|
||||
best_dom_count = 0
|
||||
for dom, c in dom_counts.items():
|
||||
if int(c) >= MIN_OCCURRENCES and int(c) > best_dom_count:
|
||||
best_dom = int(dom)
|
||||
best_dom_count = int(c)
|
||||
|
||||
if best_dom is None:
|
||||
return None
|
||||
|
||||
# Times on that day must also be stable. Keep frequent buckets; otherwise fall back to the top bucket.
|
||||
time_counts = time_counts_by_dom.get(best_dom) or {}
|
||||
keep_times = [t for t, c in time_counts.items() if int(c) >= MIN_OCCURRENCES]
|
||||
if not keep_times:
|
||||
# Fallback: choose the single most common time bucket for that day.
|
||||
best_t = None
|
||||
best_c = 0
|
||||
for t, c in time_counts.items():
|
||||
if int(c) > best_c:
|
||||
best_t = t
|
||||
best_c = int(c)
|
||||
if best_t:
|
||||
keep_times = [best_t]
|
||||
|
||||
keep_times = sorted(set(keep_times))
|
||||
if not keep_times:
|
||||
return None
|
||||
|
||||
return {"day_of_month": int(best_dom), "times": keep_times}
|
||||
|
||||
|
||||
def _schedule_map_to_desc(schedule_map):
|
||||
weekday_names = ["Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"]
|
||||
any_times = any(schedule_map.get(i) for i in range(7))
|
||||
|
||||
@ -270,13 +270,23 @@ def tickets_page():
|
||||
)
|
||||
|
||||
|
||||
@main_bp.route("/tickets/<int:ticket_id>", methods=["GET"])
|
||||
@main_bp.route("/tickets/<int:ticket_id>", methods=["GET", "POST"])
|
||||
@login_required
|
||||
@roles_required("admin", "operator", "viewer")
|
||||
def ticket_detail(ticket_id: int):
|
||||
ticket = Ticket.query.get_or_404(ticket_id)
|
||||
|
||||
# Ticket editing is disabled. Resolve the old ticket and create a new one instead.
|
||||
if request.method == "POST":
|
||||
if get_active_role() not in ("admin", "operator"):
|
||||
abort(403)
|
||||
ticket.description = (request.form.get("description") or "").strip() or None
|
||||
try:
|
||||
db.session.commit()
|
||||
flash("Ticket updated.", "success")
|
||||
except Exception as exc:
|
||||
db.session.rollback()
|
||||
flash(f"Failed to update ticket: {exc}", "danger")
|
||||
return redirect(url_for("main.ticket_detail", ticket_id=ticket.id))
|
||||
|
||||
# Scopes
|
||||
scopes = TicketScope.query.filter(TicketScope.ticket_id == ticket.id).order_by(TicketScope.id.asc()).all()
|
||||
|
||||
@ -378,7 +378,7 @@ def migrate_remarks_active_from_date() -> None:
|
||||
|
||||
|
||||
def migrate_overrides_match_columns() -> None:
|
||||
"""Add match_status / match_error columns to overrides table if missing."""
|
||||
"""Add match_status and match_error_contains columns to overrides table if missing."""
|
||||
engine = db.get_engine()
|
||||
inspector = inspect(engine)
|
||||
try:
|
||||
@ -397,25 +397,6 @@ def migrate_overrides_match_columns() -> None:
|
||||
print("[migrations] Adding overrides.match_error_contains column...")
|
||||
conn.execute(text('ALTER TABLE "overrides" ADD COLUMN match_error_contains VARCHAR(255)'))
|
||||
|
||||
if "match_error_mode" not in existing_columns:
|
||||
print("[migrations] Adding overrides.match_error_mode column...")
|
||||
conn.execute(text('ALTER TABLE "overrides" ADD COLUMN match_error_mode VARCHAR(20)'))
|
||||
|
||||
# Backfill mode for existing overrides that already have a match string.
|
||||
try:
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
UPDATE "overrides"
|
||||
SET match_error_mode = 'contains'
|
||||
WHERE (match_error_mode IS NULL OR match_error_mode = '')
|
||||
AND (match_error_contains IS NOT NULL AND match_error_contains <> '');
|
||||
"""
|
||||
)
|
||||
)
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
print("[migrations] migrate_overrides_match_columns completed.")
|
||||
|
||||
|
||||
@ -791,59 +772,17 @@ def run_migrations() -> None:
|
||||
migrate_mail_objects_table()
|
||||
migrate_object_persistence_tables()
|
||||
migrate_feedback_tables()
|
||||
migrate_feedback_replies_table()
|
||||
migrate_tickets_active_from_date()
|
||||
migrate_remarks_active_from_date()
|
||||
migrate_overrides_match_columns()
|
||||
migrate_job_runs_review_tracking()
|
||||
migrate_job_runs_override_metadata()
|
||||
migrate_jobs_archiving()
|
||||
migrate_news_tables()
|
||||
migrate_reporting_tables()
|
||||
migrate_reporting_report_config()
|
||||
print("[migrations] All migrations completed.")
|
||||
|
||||
|
||||
def migrate_jobs_archiving() -> None:
|
||||
"""Add archiving columns to jobs if missing.
|
||||
|
||||
Columns:
|
||||
- jobs.archived (BOOLEAN NOT NULL DEFAULT FALSE)
|
||||
- jobs.archived_at (TIMESTAMP NULL)
|
||||
- jobs.archived_by_user_id (INTEGER NULL)
|
||||
"""
|
||||
|
||||
table = "jobs"
|
||||
|
||||
try:
|
||||
engine = db.get_engine()
|
||||
except Exception as exc:
|
||||
print(f"[migrations] Could not get engine for jobs archiving migration: {exc}")
|
||||
return
|
||||
|
||||
inspector = inspect(engine)
|
||||
try:
|
||||
existing_columns = {col["name"] for col in inspector.get_columns(table)}
|
||||
except Exception as exc:
|
||||
print(f"[migrations] {table} table not found for jobs archiving migration, skipping: {exc}")
|
||||
return
|
||||
|
||||
with engine.begin() as conn:
|
||||
if "archived" not in existing_columns:
|
||||
print('[migrations] Adding jobs.archived column...')
|
||||
conn.execute(text('ALTER TABLE "jobs" ADD COLUMN archived BOOLEAN NOT NULL DEFAULT FALSE'))
|
||||
|
||||
if "archived_at" not in existing_columns:
|
||||
print('[migrations] Adding jobs.archived_at column...')
|
||||
conn.execute(text('ALTER TABLE "jobs" ADD COLUMN archived_at TIMESTAMP'))
|
||||
|
||||
if "archived_by_user_id" not in existing_columns:
|
||||
print('[migrations] Adding jobs.archived_by_user_id column...')
|
||||
conn.execute(text('ALTER TABLE "jobs" ADD COLUMN archived_by_user_id INTEGER'))
|
||||
|
||||
print("[migrations] migrate_jobs_archiving completed.")
|
||||
|
||||
|
||||
def migrate_reporting_report_config() -> None:
|
||||
"""Add report_definitions.report_config column if missing.
|
||||
|
||||
@ -998,40 +937,6 @@ def migrate_job_runs_review_tracking() -> None:
|
||||
print("[migrations] migrate_job_runs_review_tracking completed.")
|
||||
|
||||
|
||||
|
||||
|
||||
def migrate_feedback_replies_table() -> None:
|
||||
"""Ensure feedback reply table exists.
|
||||
|
||||
Table:
|
||||
- feedback_replies (messages on open feedback items)
|
||||
"""
|
||||
engine = db.get_engine()
|
||||
with engine.begin() as conn:
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
CREATE TABLE IF NOT EXISTS feedback_replies (
|
||||
id SERIAL PRIMARY KEY,
|
||||
feedback_item_id INTEGER NOT NULL REFERENCES feedback_items(id) ON DELETE CASCADE,
|
||||
user_id INTEGER NOT NULL REFERENCES users(id) ON DELETE CASCADE,
|
||||
message TEXT NOT NULL,
|
||||
created_at TIMESTAMP NOT NULL DEFAULT NOW()
|
||||
);
|
||||
"""
|
||||
)
|
||||
)
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
CREATE INDEX IF NOT EXISTS idx_feedback_replies_item_created_at
|
||||
ON feedback_replies (feedback_item_id, created_at);
|
||||
"""
|
||||
)
|
||||
)
|
||||
print("[migrations] Feedback replies table ensured.")
|
||||
|
||||
|
||||
def migrate_tickets_active_from_date() -> None:
|
||||
"""Ensure tickets.active_from_date exists and is populated.
|
||||
|
||||
@ -1191,39 +1096,6 @@ def migrate_object_persistence_tables() -> None:
|
||||
'''
|
||||
)
|
||||
)
|
||||
|
||||
# Ensure existing installations also have ON DELETE CASCADE on customer_objects.customer_id.
|
||||
# Older schemas created the FK without cascade, which blocks deleting customers.
|
||||
conn.execute(
|
||||
text(
|
||||
'''
|
||||
DO $$
|
||||
BEGIN
|
||||
IF EXISTS (
|
||||
SELECT 1
|
||||
FROM information_schema.table_constraints tc
|
||||
WHERE tc.table_name = 'customer_objects'
|
||||
AND tc.constraint_type = 'FOREIGN KEY'
|
||||
AND tc.constraint_name = 'customer_objects_customer_id_fkey'
|
||||
) THEN
|
||||
ALTER TABLE customer_objects
|
||||
DROP CONSTRAINT customer_objects_customer_id_fkey;
|
||||
END IF;
|
||||
|
||||
-- Recreate with cascade (idempotent via the drop above)
|
||||
ALTER TABLE customer_objects
|
||||
ADD CONSTRAINT customer_objects_customer_id_fkey
|
||||
FOREIGN KEY (customer_id)
|
||||
REFERENCES customers(id)
|
||||
ON DELETE CASCADE;
|
||||
EXCEPTION
|
||||
WHEN duplicate_object THEN
|
||||
-- Constraint already exists with the correct name.
|
||||
NULL;
|
||||
END $$;
|
||||
'''
|
||||
)
|
||||
)
|
||||
conn.execute(
|
||||
text(
|
||||
'CREATE INDEX IF NOT EXISTS idx_customer_objects_customer_name ON customer_objects (customer_id, object_name)'
|
||||
@ -1245,37 +1117,6 @@ def migrate_object_persistence_tables() -> None:
|
||||
'''
|
||||
)
|
||||
)
|
||||
|
||||
# Ensure existing installations also have ON DELETE CASCADE for customer_object_id.
|
||||
# Older schemas may have created the FK without cascade, blocking customer deletes.
|
||||
conn.execute(
|
||||
text(
|
||||
'''
|
||||
DO $$
|
||||
BEGIN
|
||||
IF EXISTS (
|
||||
SELECT 1
|
||||
FROM information_schema.table_constraints tc
|
||||
WHERE tc.table_name = 'job_object_links'
|
||||
AND tc.constraint_type = 'FOREIGN KEY'
|
||||
AND tc.constraint_name = 'job_object_links_customer_object_id_fkey'
|
||||
) THEN
|
||||
ALTER TABLE job_object_links
|
||||
DROP CONSTRAINT job_object_links_customer_object_id_fkey;
|
||||
END IF;
|
||||
|
||||
ALTER TABLE job_object_links
|
||||
ADD CONSTRAINT job_object_links_customer_object_id_fkey
|
||||
FOREIGN KEY (customer_object_id)
|
||||
REFERENCES customer_objects(id)
|
||||
ON DELETE CASCADE;
|
||||
EXCEPTION
|
||||
WHEN duplicate_object THEN
|
||||
NULL;
|
||||
END $$;
|
||||
'''
|
||||
)
|
||||
)
|
||||
conn.execute(
|
||||
text(
|
||||
'CREATE INDEX IF NOT EXISTS idx_job_object_links_job_id ON job_object_links (job_id)'
|
||||
@ -1303,36 +1144,6 @@ def migrate_object_persistence_tables() -> None:
|
||||
'''
|
||||
)
|
||||
)
|
||||
|
||||
# Ensure existing installations also have ON DELETE CASCADE for customer_object_id.
|
||||
conn.execute(
|
||||
text(
|
||||
'''
|
||||
DO $$
|
||||
BEGIN
|
||||
IF EXISTS (
|
||||
SELECT 1
|
||||
FROM information_schema.table_constraints tc
|
||||
WHERE tc.table_name = 'run_object_links'
|
||||
AND tc.constraint_type = 'FOREIGN KEY'
|
||||
AND tc.constraint_name = 'run_object_links_customer_object_id_fkey'
|
||||
) THEN
|
||||
ALTER TABLE run_object_links
|
||||
DROP CONSTRAINT run_object_links_customer_object_id_fkey;
|
||||
END IF;
|
||||
|
||||
ALTER TABLE run_object_links
|
||||
ADD CONSTRAINT run_object_links_customer_object_id_fkey
|
||||
FOREIGN KEY (customer_object_id)
|
||||
REFERENCES customer_objects(id)
|
||||
ON DELETE CASCADE;
|
||||
EXCEPTION
|
||||
WHEN duplicate_object THEN
|
||||
NULL;
|
||||
END $$;
|
||||
'''
|
||||
)
|
||||
)
|
||||
conn.execute(
|
||||
text(
|
||||
'CREATE INDEX IF NOT EXISTS idx_run_object_links_run_id ON run_object_links (run_id)'
|
||||
@ -1370,7 +1181,6 @@ def migrate_object_persistence_tables() -> None:
|
||||
job_id INTEGER REFERENCES jobs(id),
|
||||
job_name_match VARCHAR(255),
|
||||
job_name_match_mode VARCHAR(32),
|
||||
resolved_at TIMESTAMP,
|
||||
created_at TIMESTAMP NOT NULL
|
||||
);
|
||||
"""))
|
||||
@ -1384,12 +1194,6 @@ def migrate_object_persistence_tables() -> None:
|
||||
UNIQUE(ticket_id, job_run_id)
|
||||
);
|
||||
"""))
|
||||
# Ensure scope-level resolution exists for per-job ticket resolving
|
||||
conn.execute(text("ALTER TABLE ticket_scopes ADD COLUMN IF NOT EXISTS resolved_at TIMESTAMP"))
|
||||
conn.execute(text("CREATE INDEX IF NOT EXISTS idx_ticket_scopes_ticket_id ON ticket_scopes (ticket_id)"))
|
||||
conn.execute(text("CREATE INDEX IF NOT EXISTS idx_ticket_scopes_job_id ON ticket_scopes (job_id)"))
|
||||
conn.execute(text("CREATE INDEX IF NOT EXISTS idx_ticket_scopes_resolved_at ON ticket_scopes (resolved_at)"))
|
||||
|
||||
conn.execute(text("""
|
||||
CREATE TABLE IF NOT EXISTS remarks (
|
||||
id SERIAL PRIMARY KEY,
|
||||
|
||||
@ -156,8 +156,6 @@ class Override(db.Model):
|
||||
# Matching criteria on object status / error message
|
||||
match_status = db.Column(db.String(32), nullable=True)
|
||||
match_error_contains = db.Column(db.String(255), nullable=True)
|
||||
# Matching mode for error text: contains (default), exact, starts_with, ends_with
|
||||
match_error_mode = db.Column(db.String(20), nullable=True)
|
||||
|
||||
# Behaviour flags
|
||||
treat_as_success = db.Column(db.Boolean, nullable=False, default=True)
|
||||
@ -198,12 +196,6 @@ class Job(db.Model):
|
||||
auto_approve = db.Column(db.Boolean, nullable=False, default=True)
|
||||
active = db.Column(db.Boolean, nullable=False, default=True)
|
||||
|
||||
# Archived jobs are excluded from Daily Jobs and Run Checks.
|
||||
# JobRuns remain in the database and are still included in reporting.
|
||||
archived = db.Column(db.Boolean, nullable=False, default=False)
|
||||
archived_at = db.Column(db.DateTime, nullable=True)
|
||||
archived_by_user_id = db.Column(db.Integer, db.ForeignKey("users.id"), nullable=True)
|
||||
|
||||
created_at = db.Column(db.DateTime, default=datetime.utcnow, nullable=False)
|
||||
updated_at = db.Column(
|
||||
db.DateTime, default=datetime.utcnow, onupdate=datetime.utcnow, nullable=False
|
||||
@ -399,7 +391,6 @@ class TicketScope(db.Model):
|
||||
job_name_match = db.Column(db.String(255))
|
||||
job_name_match_mode = db.Column(db.String(32))
|
||||
created_at = db.Column(db.DateTime, default=datetime.utcnow, nullable=False)
|
||||
resolved_at = db.Column(db.DateTime)
|
||||
|
||||
|
||||
class TicketJobRun(db.Model):
|
||||
@ -497,20 +488,6 @@ class FeedbackVote(db.Model):
|
||||
)
|
||||
|
||||
|
||||
|
||||
|
||||
class FeedbackReply(db.Model):
|
||||
__tablename__ = "feedback_replies"
|
||||
|
||||
id = db.Column(db.Integer, primary_key=True)
|
||||
feedback_item_id = db.Column(
|
||||
db.Integer, db.ForeignKey("feedback_items.id", ondelete="CASCADE"), nullable=False
|
||||
)
|
||||
user_id = db.Column(db.Integer, db.ForeignKey("users.id"), nullable=False)
|
||||
message = db.Column(db.Text, nullable=False)
|
||||
created_at = db.Column(db.DateTime, default=datetime.utcnow, nullable=False)
|
||||
|
||||
|
||||
class NewsItem(db.Model):
|
||||
__tablename__ = "news_items"
|
||||
|
||||
@ -652,4 +629,4 @@ class ReportObjectSummary(db.Model):
|
||||
report = db.relationship(
|
||||
"ReportDefinition",
|
||||
backref=db.backref("object_summaries", lazy="dynamic", cascade="all, delete-orphan"),
|
||||
)
|
||||
)
|
||||
|
||||
@ -130,172 +130,3 @@ def persist_objects_for_approved_run(customer_id: int, job_id: int, run_id: int,
|
||||
|
||||
return processed
|
||||
|
||||
|
||||
def persist_objects_for_approved_run_filtered(
|
||||
customer_id: int,
|
||||
job_id: int,
|
||||
run_id: int,
|
||||
mail_message_id: int,
|
||||
*,
|
||||
object_name_prefix: str,
|
||||
strip_prefix: bool = True,
|
||||
) -> int:
|
||||
"""Persist a subset of mail_objects for a specific approved run.
|
||||
|
||||
This is used for multi-tenant / multi-customer summary emails where a single mail_message
|
||||
contains objects for multiple companies (e.g. Veeam VSPC Active Alarms summary).
|
||||
|
||||
Args:
|
||||
customer_id: Customer id for the target job.
|
||||
job_id: Job id for the target job.
|
||||
run_id: JobRun id.
|
||||
mail_message_id: MailMessage id that contains the parsed mail_objects.
|
||||
object_name_prefix: Company prefix (exact) used in mail_objects.object_name ("<company> | <object>").
|
||||
strip_prefix: If True, store object names without the "<company> | " prefix.
|
||||
|
||||
Returns:
|
||||
Number of processed objects.
|
||||
"""
|
||||
engine = db.get_engine()
|
||||
processed = 0
|
||||
|
||||
prefix = (object_name_prefix or "").strip()
|
||||
if not prefix:
|
||||
return 0
|
||||
|
||||
like_value = f"{prefix} | %"
|
||||
|
||||
with engine.begin() as conn:
|
||||
rows = conn.execute(
|
||||
text(
|
||||
"""
|
||||
SELECT object_name, object_type, status, error_message
|
||||
FROM mail_objects
|
||||
WHERE mail_message_id = :mail_message_id
|
||||
AND object_name LIKE :like_value
|
||||
ORDER BY id
|
||||
"""
|
||||
),
|
||||
{"mail_message_id": mail_message_id, "like_value": like_value},
|
||||
).fetchall()
|
||||
|
||||
for r in rows:
|
||||
raw_name = (r[0] or "").strip()
|
||||
if not raw_name:
|
||||
continue
|
||||
|
||||
object_name = raw_name
|
||||
if strip_prefix and object_name.startswith(f"{prefix} | "):
|
||||
object_name = object_name[len(prefix) + 3 :].strip()
|
||||
|
||||
if not object_name:
|
||||
continue
|
||||
|
||||
object_type = r[1]
|
||||
status = r[2]
|
||||
error_message = r[3]
|
||||
|
||||
# 1) Upsert customer_objects and get id (schema uses UNIQUE(customer_id, object_name))
|
||||
customer_object_id = conn.execute(
|
||||
text(
|
||||
"""
|
||||
INSERT INTO customer_objects (customer_id, object_name, object_type, first_seen_at, last_seen_at)
|
||||
VALUES (:customer_id, :object_name, :object_type, NOW(), NOW())
|
||||
ON CONFLICT (customer_id, object_name)
|
||||
DO UPDATE SET
|
||||
last_seen_at = NOW(),
|
||||
object_type = COALESCE(EXCLUDED.object_type, customer_objects.object_type)
|
||||
RETURNING id
|
||||
"""
|
||||
),
|
||||
{
|
||||
"customer_id": customer_id,
|
||||
"object_name": object_name,
|
||||
"object_type": object_type,
|
||||
},
|
||||
).scalar()
|
||||
|
||||
# 2) Upsert job_object_links (keep timestamps fresh)
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
INSERT INTO job_object_links (job_id, customer_object_id, first_seen_at, last_seen_at)
|
||||
VALUES (:job_id, :customer_object_id, NOW(), NOW())
|
||||
ON CONFLICT (job_id, customer_object_id)
|
||||
DO UPDATE SET last_seen_at = NOW()
|
||||
"""
|
||||
),
|
||||
{
|
||||
"job_id": job_id,
|
||||
"customer_object_id": customer_object_id,
|
||||
},
|
||||
)
|
||||
|
||||
# 3) Upsert run_object_links
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
INSERT INTO run_object_links (run_id, customer_object_id, status, error_message, observed_at)
|
||||
VALUES (:run_id, :customer_object_id, :status, :error_message, NOW())
|
||||
ON CONFLICT (run_id, customer_object_id)
|
||||
DO UPDATE SET
|
||||
status = EXCLUDED.status,
|
||||
error_message = EXCLUDED.error_message,
|
||||
observed_at = NOW()
|
||||
"""
|
||||
),
|
||||
{
|
||||
"run_id": run_id,
|
||||
"customer_object_id": customer_object_id,
|
||||
"status": status,
|
||||
"error_message": error_message,
|
||||
},
|
||||
)
|
||||
|
||||
processed += 1
|
||||
|
||||
_update_override_applied_for_run(job_id, run_id)
|
||||
return processed
|
||||
|
||||
|
||||
def persist_objects_for_auto_run(customer_id: int, job_id: int, run_id: int, mail_message_id: int) -> int:
|
||||
"""Persist objects for a run created by auto-approve logic.
|
||||
|
||||
For VSPC Active Alarms summary, objects are stored on the mail_message with
|
||||
a "<company> | <object>" prefix. Auto-approved runs are created per-company
|
||||
job ("Active alarms summary | <company>"). In that case we persist only the
|
||||
matching subset and strip the prefix so objects are correctly linked.
|
||||
"""
|
||||
|
||||
try:
|
||||
# Lazy import to avoid circular dependencies.
|
||||
from .models import Job # noqa
|
||||
|
||||
job = Job.query.get(int(job_id))
|
||||
if not job:
|
||||
return persist_objects_for_approved_run(customer_id, job_id, run_id, mail_message_id)
|
||||
|
||||
bsw = (getattr(job, "backup_software", "") or "").strip().lower()
|
||||
btype = (getattr(job, "backup_type", "") or "").strip().lower()
|
||||
jname = (getattr(job, "job_name", "") or "").strip()
|
||||
|
||||
if bsw == "veeam" and btype == "service provider console":
|
||||
# Expected format: "Active alarms summary | <company>"
|
||||
parts = [p.strip() for p in jname.split("|", 1)]
|
||||
if len(parts) == 2 and parts[0].strip().lower() == "active alarms summary" and parts[1]:
|
||||
company = parts[1]
|
||||
return persist_objects_for_approved_run_filtered(
|
||||
customer_id,
|
||||
job_id,
|
||||
run_id,
|
||||
mail_message_id,
|
||||
object_name_prefix=company,
|
||||
strip_prefix=True,
|
||||
)
|
||||
|
||||
except Exception:
|
||||
# Fall back to the generic behavior.
|
||||
pass
|
||||
|
||||
return persist_objects_for_approved_run(customer_id, job_id, run_id, mail_message_id)
|
||||
|
||||
|
||||
@ -13,8 +13,6 @@ from .nakivo import try_parse_nakivo
|
||||
from .veeam import try_parse_veeam
|
||||
from .rdrive import try_parse_rdrive
|
||||
from .syncovery import try_parse_syncovery
|
||||
from .ntfs_auditing import try_parse_ntfs_auditing
|
||||
from .qnap import try_parse_qnap
|
||||
|
||||
|
||||
def _sanitize_text(value: object) -> object:
|
||||
@ -45,25 +43,14 @@ def _store_mail_objects(msg: MailMessage, objects: List[Dict]) -> None:
|
||||
- error_message (optional)
|
||||
"""
|
||||
for item in objects or []:
|
||||
name = _sanitize_text(item.get("name") or "")
|
||||
if isinstance(name, str):
|
||||
name = name.strip()
|
||||
name = (item.get("name") or "").strip()
|
||||
if not name:
|
||||
continue
|
||||
object_type = (item.get("type") or item.get("object_type") or None)
|
||||
object_type = _sanitize_text(object_type)
|
||||
if isinstance(object_type, str):
|
||||
object_type = object_type.strip() or None
|
||||
|
||||
status = (item.get("status") or None) or None
|
||||
status = _sanitize_text(status)
|
||||
if isinstance(status, str):
|
||||
status = status.strip() or None
|
||||
|
||||
error_message = item.get("error_message") or None
|
||||
error_message = _sanitize_text(error_message)
|
||||
if isinstance(error_message, str):
|
||||
error_message = error_message.strip() or None
|
||||
db.session.add(
|
||||
MailObject(
|
||||
mail_message_id=msg.id,
|
||||
@ -107,8 +94,6 @@ def parse_mail_message(msg: MailMessage) -> None:
|
||||
|
||||
try:
|
||||
handled, result, objects = try_parse_3cx(msg)
|
||||
if not handled:
|
||||
handled, result, objects = try_parse_qnap(msg)
|
||||
if not handled:
|
||||
handled, result, objects = try_parse_synology(msg)
|
||||
if not handled:
|
||||
@ -121,8 +106,6 @@ def parse_mail_message(msg: MailMessage) -> None:
|
||||
handled, result, objects = try_parse_veeam(msg)
|
||||
if not handled:
|
||||
handled, result, objects = try_parse_syncovery(msg)
|
||||
if not handled:
|
||||
handled, result, objects = try_parse_ntfs_auditing(msg)
|
||||
except Exception as exc:
|
||||
msg.parse_result = "error"
|
||||
msg.parse_error = str(exc)[:500]
|
||||
|
||||
@ -1,89 +0,0 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import re
|
||||
from typing import Dict, Tuple, List
|
||||
|
||||
from ..models import MailMessage
|
||||
|
||||
|
||||
_HOSTNAME_RE = re.compile(r"""(?ix)
|
||||
\b
|
||||
(?:[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.)+
|
||||
(?:[a-z]{2,}|local)
|
||||
\b
|
||||
""")
|
||||
|
||||
_COUNTS_RE = re.compile(r"""(?x)
|
||||
[\u2193\u2191] # ↓ or ↑
|
||||
\s*
|
||||
(\d+)
|
||||
""")
|
||||
|
||||
|
||||
def _normalize_subject(subject: str) -> str:
|
||||
# Some senders use underscores as spaces in the subject.
|
||||
s = (subject or "").strip()
|
||||
s = s.replace("_", " ")
|
||||
s = re.sub(r"\s+", " ", s)
|
||||
return s.strip()
|
||||
|
||||
|
||||
def _extract_host(subject: str) -> str | None:
|
||||
subj = _normalize_subject(subject)
|
||||
lower = subj.lower()
|
||||
|
||||
idx = lower.find("file audits")
|
||||
if idx == -1:
|
||||
return None
|
||||
|
||||
prefix = subj[:idx].strip()
|
||||
# Some senders add a company prefix in front of the hostname, e.g. "Bouter btr-dc001.bouter.nl ...".
|
||||
# Extract the last hostname-looking token before "file audits".
|
||||
hosts = _HOSTNAME_RE.findall(prefix)
|
||||
if not hosts:
|
||||
return None
|
||||
|
||||
return hosts[-1].lower()
|
||||
|
||||
|
||||
def _extract_counts(subject: str) -> Tuple[int, int]:
|
||||
# Subject format: "<host> file audits ↓ 0 ↑ 29"
|
||||
# Not all senders include both arrows, so we parse what we can.
|
||||
subj = _normalize_subject(subject)
|
||||
nums = [int(x) for x in _COUNTS_RE.findall(subj)]
|
||||
down = nums[0] if len(nums) >= 1 else 0
|
||||
up = nums[1] if len(nums) >= 2 else 0
|
||||
return down, up
|
||||
|
||||
|
||||
def try_parse_ntfs_auditing(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
subject = getattr(msg, "subject", None) or ""
|
||||
|
||||
# Fast checks: this parser is subject-based.
|
||||
if "file audits" not in _normalize_subject(subject).lower():
|
||||
return False, {}, []
|
||||
|
||||
host = _extract_host(subject)
|
||||
if not host:
|
||||
return False, {}, []
|
||||
|
||||
down, up = _extract_counts(subject)
|
||||
|
||||
# If changes were detected, mark as Warning (auditing reports only changes).
|
||||
overall_status = "Warning" if (down > 0 or up > 0) else "Success"
|
||||
overall_message = None
|
||||
if overall_status == "Warning":
|
||||
overall_message = f"NTFS auditing detected file changes (deleted: {down}, changed: {up})."
|
||||
|
||||
job_name = f"{host} file audits"
|
||||
|
||||
result = {
|
||||
"backup_software": "NTFS Auditing",
|
||||
"backup_type": "Audit",
|
||||
"job_name": job_name,
|
||||
"overall_status": overall_status,
|
||||
"overall_message": overall_message,
|
||||
}
|
||||
|
||||
# This mail contains an attachment report; objects are not tracked.
|
||||
return True, result, []
|
||||
@ -1,100 +0,0 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import html
|
||||
import re
|
||||
from typing import Dict, Tuple, List
|
||||
|
||||
from ..models import MailMessage
|
||||
|
||||
|
||||
_SUBJECT_RE = re.compile(
|
||||
r"^\[(?P<severity>info|warning|error)\]\s*\[\s*firmware\s+update\s*\]\s*notification\s+from\s+your\s+device\s*:\s*(?P<host>.+)$",
|
||||
re.I,
|
||||
)
|
||||
|
||||
_NAS_NAME_RE = re.compile(r"\bNAS\s*Name\s*:\s*(?P<host>[^\n<]+)", re.I)
|
||||
_APP_NAME_RE = re.compile(r"\bApp\s*Name\s*:\s*(?P<app>[^\n<]+)", re.I)
|
||||
_CATEGORY_RE = re.compile(r"\bCategory\s*:\s*(?P<cat>[^\n<]+)", re.I)
|
||||
_MESSAGE_RE = re.compile(r"\bMessage\s*:\s*(?P<msg>.+)$", re.I | re.M)
|
||||
|
||||
_BR_RE = re.compile(r"<\s*br\s*/?\s*>", re.I)
|
||||
_TAG_RE = re.compile(r"<[^>]+>")
|
||||
_WS_RE = re.compile(r"[\t\r\f\v ]+")
|
||||
|
||||
|
||||
def _html_to_text(value: str) -> str:
|
||||
if not value:
|
||||
return ""
|
||||
s = value
|
||||
s = _BR_RE.sub("\n", s)
|
||||
s = _TAG_RE.sub("", s)
|
||||
s = html.unescape(s)
|
||||
s = s.replace("\u00a0", " ")
|
||||
# keep newlines, but normalize whitespace on each line
|
||||
lines = [(_WS_RE.sub(" ", ln)).strip() for ln in s.split("\n")]
|
||||
return "\n".join([ln for ln in lines if ln]).strip()
|
||||
|
||||
|
||||
def try_parse_qnap(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
"""Parse QNAP Notification Center e-mails.
|
||||
|
||||
Supported (informational):
|
||||
- Firmware Update notifications
|
||||
Subject: [Info][Firmware Update] Notification from your device: <HOST>
|
||||
|
||||
These notifications are informational: they should be visible in Run Checks,
|
||||
but they must not participate in schedule inference, missed/expected logic,
|
||||
or reporting.
|
||||
"""
|
||||
|
||||
subject = (getattr(msg, "subject", None) or "").strip()
|
||||
if not subject:
|
||||
return False, {}, []
|
||||
|
||||
m = _SUBJECT_RE.match(subject)
|
||||
if not m:
|
||||
return False, {}, []
|
||||
|
||||
host = (m.group("host") or "").strip()
|
||||
|
||||
html_body = getattr(msg, "html_body", None) or ""
|
||||
text_body = getattr(msg, "text_body", None) or getattr(msg, "body", None) or ""
|
||||
text = _html_to_text(html_body) if html_body else (text_body or "")
|
||||
|
||||
if text:
|
||||
m_host = _NAS_NAME_RE.search(text)
|
||||
if m_host:
|
||||
host = (m_host.group("host") or "").strip() or host
|
||||
|
||||
# Prefer the detailed 'Message:' line from the body.
|
||||
overall_message = None
|
||||
if text:
|
||||
m_msg = _MESSAGE_RE.search(text)
|
||||
if m_msg:
|
||||
overall_message = (m_msg.group("msg") or "").strip() or None
|
||||
|
||||
# If the body doesn't contain a dedicated message line, derive one.
|
||||
if not overall_message and text:
|
||||
parts: List[str] = []
|
||||
m_app = _APP_NAME_RE.search(text)
|
||||
if m_app:
|
||||
parts.append((m_app.group("app") or "").strip())
|
||||
m_cat = _CATEGORY_RE.search(text)
|
||||
if m_cat:
|
||||
parts.append((m_cat.group("cat") or "").strip())
|
||||
if parts:
|
||||
overall_message = " / ".join([p for p in parts if p]) or None
|
||||
|
||||
result: Dict = {
|
||||
"backup_software": "QNAP",
|
||||
"backup_type": "Firmware Update",
|
||||
"job_name": "Firmware Update",
|
||||
"overall_status": "Warning",
|
||||
"overall_message": overall_message,
|
||||
}
|
||||
|
||||
objects: List[Dict] = []
|
||||
if host:
|
||||
objects.append({"name": host, "status": "Warning"})
|
||||
|
||||
return True, result, objects
|
||||
@ -38,55 +38,6 @@ PARSER_DEFINITIONS = [
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
"name": "ntfs_auditing_audit",
|
||||
"backup_software": "NTFS Auditing",
|
||||
"backup_types": ["Audit"],
|
||||
"order": 220,
|
||||
"enabled": True,
|
||||
"match": {
|
||||
"from_contains": "auditing@",
|
||||
"subject_contains": "file audits",
|
||||
},
|
||||
"description": "Parses NTFS Auditing file audit report mails (attachment-based HTML reports).",
|
||||
"example": {
|
||||
"subject": "Bouter btr-dc001.bouter.nl file audits → 6 ↑ 12",
|
||||
"from_address": "auditing@bouter.nl",
|
||||
"body_snippet": "(empty body, HTML report in attachment)",
|
||||
"parsed_result": {
|
||||
"backup_software": "NTFS Auditing",
|
||||
"backup_type": "Audit",
|
||||
"job_name": "btr-dc001.bouter.nl file audits",
|
||||
"objects": [],
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
"name": "qnap_firmware_update",
|
||||
"backup_software": "QNAP",
|
||||
"backup_types": ["Firmware Update"],
|
||||
"order": 235,
|
||||
"enabled": True,
|
||||
"match": {
|
||||
"from_contains": "notifications@",
|
||||
"subject_contains": "Firmware Update",
|
||||
},
|
||||
"description": "Parses QNAP Notification Center firmware update notifications (informational; excluded from reporting and missing logic).",
|
||||
"example": {
|
||||
"subject": "[Info][Firmware Update] Notification from your device: BETSIES-NAS01",
|
||||
"from_address": "notifications@customer.tld",
|
||||
"body_snippet": "NAS Name: BETSIES-NAS01\n...\nMessage: ...",
|
||||
"parsed_result": {
|
||||
"backup_software": "QNAP",
|
||||
"backup_type": "Firmware Update",
|
||||
"job_name": "Firmware Update",
|
||||
"overall_status": "Warning",
|
||||
"objects": [
|
||||
{"name": "BETSIES-NAS01", "status": "Warning", "error_message": None}
|
||||
],
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
"name": "veeam_replication_job",
|
||||
"backup_software": "Veeam",
|
||||
|
||||
@ -1,7 +1,5 @@
|
||||
# --- Synology DSM Updates (informational, excluded from reporting) ---
|
||||
from __future__ import annotations
|
||||
|
||||
|
||||
import re
|
||||
from typing import Dict, Tuple, List, Optional
|
||||
|
||||
@ -14,52 +12,6 @@ from ..models import MailMessage
|
||||
# - Hyper Backup (Synology): task notifications from Hyper Backup
|
||||
# - Account Protection (Synology): DSM Account Protection lockout notifications
|
||||
|
||||
DSM_UPDATE_CANCELLED_PATTERNS = [
|
||||
"Automatische update van DSM is geannuleerd",
|
||||
"Automatic DSM update was cancelled",
|
||||
"Automatic update of DSM was cancelled",
|
||||
]
|
||||
|
||||
_DSM_UPDATE_CANCELLED_HOST_RE = re.compile(
|
||||
r"\b(?:geannuleerd\s+op|cancelled\s+on)\s+(?P<host>[A-Za-z0-9._-]+)\b",
|
||||
re.I,
|
||||
)
|
||||
|
||||
_DSM_UPDATE_FROM_HOST_RE = re.compile(r"\bVan\s+(?P<host>[A-Za-z0-9._-]+)\b", re.I)
|
||||
|
||||
|
||||
def _is_synology_dsm_update_cancelled(subject: str, text: str) -> bool:
|
||||
haystack = f"{subject}\n{text}".lower()
|
||||
return any(p.lower() in haystack for p in DSM_UPDATE_CANCELLED_PATTERNS)
|
||||
|
||||
|
||||
def _parse_synology_dsm_update_cancelled(subject: str, text: str) -> Tuple[bool, Dict, List[Dict]]:
|
||||
haystack = f"{subject}\n{text}"
|
||||
host = ""
|
||||
|
||||
m = _DSM_UPDATE_CANCELLED_HOST_RE.search(haystack)
|
||||
if m:
|
||||
host = (m.group("host") or "").strip()
|
||||
if not host:
|
||||
m = _DSM_UPDATE_FROM_HOST_RE.search(haystack)
|
||||
if m:
|
||||
host = (m.group("host") or "").strip()
|
||||
|
||||
# Informational job: show in Run Checks, but do not participate in schedules / reporting.
|
||||
result: Dict = {
|
||||
"backup_software": "Synology",
|
||||
"backup_type": "Updates",
|
||||
"job_name": "Synology Automatic Update",
|
||||
"overall_status": "Warning",
|
||||
"overall_message": "Automatic DSM update cancelled" + (f" ({host})" if host else ""),
|
||||
}
|
||||
|
||||
objects: List[Dict] = []
|
||||
if host:
|
||||
objects.append({"name": host, "status": "Warning"})
|
||||
|
||||
return True, result, objects
|
||||
|
||||
_BR_RE = re.compile(r"<\s*br\s*/?\s*>", re.I)
|
||||
_TAG_RE = re.compile(r"<[^>]+>")
|
||||
_WS_RE = re.compile(r"[\t\r\f\v ]+")
|
||||
@ -173,35 +125,23 @@ def _extract_totals(text: str) -> Tuple[int, int, int]:
|
||||
|
||||
_ABB_SUBJECT_RE = re.compile(r"\bactive\s+backup\s+for\s+business\b", re.I)
|
||||
|
||||
# Examples (NL):
|
||||
# Example (NL):
|
||||
# "De back-uptaak vSphere-Task-1 op KANTOOR-NEW is voltooid."
|
||||
# "Virtuele machine back-uptaak vSphere-Task-1 op KANTOOR-NEW is gedeeltelijk voltooid."
|
||||
# Examples (EN):
|
||||
# Example (EN):
|
||||
# "The backup task vSphere-Task-1 on KANTOOR-NEW has completed."
|
||||
# "Virtual machine backup task vSphere-Task-1 on KANTOOR-NEW partially completed."
|
||||
_ABB_COMPLETED_RE = re.compile(
|
||||
r"\b(?:virtuele\s+machine\s+)?(?:de\s+)?back-?up\s*taak\s+(?P<job>.+?)\s+op\s+(?P<host>[A-Za-z0-9._-]+)\s+is\s+(?P<status>voltooid|gedeeltelijk\s+voltooid)\b"
|
||||
r"|\b(?:virtual\s+machine\s+)?(?:the\s+)?back-?up\s+task\s+(?P<job_en>.+?)\s+on\s+(?P<host_en>[A-Za-z0-9._-]+)\s+(?:is\s+)?(?P<status_en>completed|finished|has\s+completed|partially\s+completed)\b",
|
||||
r"\b(?:de\s+)?back-?up\s*taak\s+(?P<job>.+?)\s+op\s+(?P<host>.+?)\s+is\s+voltooid\b"
|
||||
r"|\b(?:the\s+)?back-?up\s+task\s+(?P<job_en>.+?)\s+on\s+(?P<host_en>.+?)\s+(?:is\s+)?(?:completed|finished|has\s+completed)\b",
|
||||
re.I,
|
||||
)
|
||||
|
||||
_ABB_FAILED_RE = re.compile(
|
||||
r"\b(?:virtuele\s+machine\s+)?(?:de\s+)?back-?up\s*taak\s+.+?\s+op\s+.+?\s+is\s+mislukt\b"
|
||||
r"|\b(?:virtual\s+machine\s+)?(?:the\s+)?back-?up\s+task\s+.+?\s+on\s+.+?\s+(?:has\s+)?failed\b",
|
||||
r"\b(?:de\s+)?back-?up\s*taak\s+.+?\s+op\s+.+?\s+is\s+mislukt\b"
|
||||
r"|\b(?:the\s+)?back-?up\s+task\s+.+?\s+on\s+.+?\s+(?:has\s+)?failed\b",
|
||||
re.I,
|
||||
)
|
||||
|
||||
# Device list lines in body, e.g.
|
||||
# "Apparaatlijst (back-up gelukt): DC01, SQL01"
|
||||
# "Lijst met apparaten (back-up gelukt): DC01, SQL01"
|
||||
# "Apparaatlijst (back-up mislukt): FS01"
|
||||
# "Device list (backup succeeded): DC01, SQL01"
|
||||
# "List of devices (backup succeeded): DC01, SQL01"
|
||||
# "Device list (backup failed): FS01"
|
||||
_ABB_DEVICE_LIST_RE = re.compile(
|
||||
r"^\s*(?:Apparaatlijst|Lijst\s+met\s+apparaten|Device\s+list|List\s+of\s+devices)\s*(?:\((?P<kind>[^)]+)\))?\s*:\s*(?P<list>.*?)\s*$",
|
||||
re.I,
|
||||
)
|
||||
_ABB_DEVICE_LIST_RE = re.compile(r"^\s*(?:Apparaatlijst|Device\s+list)\s*:\s*(?P<list>.+?)\s*$", re.I)
|
||||
|
||||
|
||||
def _is_synology_active_backup_for_business(subject: str, text: str) -> bool:
|
||||
@ -222,60 +162,22 @@ def _parse_active_backup_for_business(subject: str, text: str) -> Tuple[bool, Di
|
||||
job_name = (m.group("job") or m.group("job_en") or "").strip()
|
||||
host = (m.group("host") or m.group("host_en") or "").strip()
|
||||
|
||||
# Determine overall status based on completion type and failure markers
|
||||
status_raw = (m.group("status") or m.group("status_en") or "").lower()
|
||||
|
||||
overall_status = "Success"
|
||||
overall_message = "Success"
|
||||
|
||||
# "gedeeltelijk voltooid" / "partially completed" should be treated as Warning
|
||||
if "gedeeltelijk" in status_raw or "partially" in status_raw:
|
||||
overall_status = "Warning"
|
||||
overall_message = "Partially completed"
|
||||
|
||||
# Explicit failure wording overrides everything
|
||||
if _ABB_FAILED_RE.search(haystack):
|
||||
overall_status = "Error"
|
||||
overall_message = "Failed"
|
||||
|
||||
# Collect device/object statuses while avoiding duplicates.
|
||||
# Prefer the most severe status when a device appears multiple times.
|
||||
severity = {"Error": 3, "Failed": 3, "Warning": 2, "Success": 1}
|
||||
device_status: Dict[str, str] = {}
|
||||
|
||||
objects: List[Dict] = []
|
||||
for line in (text or "").splitlines():
|
||||
mm = _ABB_DEVICE_LIST_RE.match(line.strip())
|
||||
if not mm:
|
||||
continue
|
||||
raw_list = (mm.group("list") or "").strip()
|
||||
|
||||
kind = (mm.group("kind") or "").lower()
|
||||
line_status = overall_status
|
||||
kind_is_specific = False
|
||||
if "gelukt" in kind or "succeeded" in kind or "success" in kind:
|
||||
line_status = "Success"
|
||||
kind_is_specific = True
|
||||
elif "mislukt" in kind or "failed" in kind or "error" in kind:
|
||||
line_status = "Error"
|
||||
kind_is_specific = True
|
||||
|
||||
# "DC01, SQL01"
|
||||
for name in [p.strip() for p in raw_list.split(",")]:
|
||||
if not name:
|
||||
continue
|
||||
prev = device_status.get(name)
|
||||
if prev is None:
|
||||
device_status[name] = line_status
|
||||
continue
|
||||
|
||||
# Do not override specific succeeded/failed lists with a generic "device list".
|
||||
if not kind_is_specific:
|
||||
continue
|
||||
|
||||
if severity.get(line_status, 0) > severity.get(prev, 0):
|
||||
device_status[name] = line_status
|
||||
|
||||
objects: List[Dict] = [{"name": n, "status": s} for n, s in device_status.items()]
|
||||
if name:
|
||||
objects.append({"name": name, "status": overall_status})
|
||||
|
||||
result = {
|
||||
"backup_software": "Synology",
|
||||
@ -483,12 +385,6 @@ def try_parse_synology(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
# If html_body is empty, treat text_body as already-normalized text.
|
||||
text = _html_to_text(html_body) if html_body else (text_body or "")
|
||||
|
||||
# DSM Updates (informational; no schedule; excluded from reporting)
|
||||
if _is_synology_dsm_update_cancelled(subject, text):
|
||||
ok, result, objects = _parse_synology_dsm_update_cancelled(subject, text)
|
||||
if ok:
|
||||
return True, result, objects
|
||||
|
||||
# DSM Account Protection (informational; no schedule)
|
||||
if _is_synology_account_protection(subject, text):
|
||||
ok, result, objects = _parse_account_protection(subject, text)
|
||||
|
||||
@ -6,61 +6,28 @@ from typing import Dict, Tuple, List
|
||||
from ..models import MailMessage
|
||||
|
||||
|
||||
def _normalize_text(text: str) -> str:
|
||||
text = (text or "").replace("\r\n", "\n").replace("\r", "\n")
|
||||
# Collapse excessive blank lines while keeping readability
|
||||
text = re.sub(r"\n{4,}", "\n\n\n", text)
|
||||
return text.strip()
|
||||
|
||||
|
||||
def try_parse_3cx(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
"""Parse 3CX notification e-mails.
|
||||
"""Parse 3CX backup notification e-mails.
|
||||
|
||||
Supported:
|
||||
- Backup Complete
|
||||
Subject: '3CX Notification: Backup Complete - <host>'
|
||||
Body contains: 'Backup name: <file>'
|
||||
|
||||
- SSL Certificate Renewal (informational)
|
||||
Subject: '3CX Notification: SSL Certificate Renewal - <host>'
|
||||
Body contains an informational message about the renewal.
|
||||
Expected:
|
||||
Subject: '3CX Notification: Backup Complete - <host>'
|
||||
Body contains: 'Backup name: <file>'
|
||||
"""
|
||||
subject = (msg.subject or "").strip()
|
||||
if not subject:
|
||||
return False, {}, []
|
||||
|
||||
# Backup complete
|
||||
m_backup = re.match(r"^3CX Notification:\s*Backup Complete\s*-\s*(.+)$", subject, flags=re.IGNORECASE)
|
||||
|
||||
# SSL certificate renewal (informational)
|
||||
m_ssl = re.match(
|
||||
r"^3CX Notification:\s*SSL Certificate Renewal\s*-\s*(.+)$",
|
||||
subject,
|
||||
flags=re.IGNORECASE,
|
||||
)
|
||||
|
||||
if not m_backup and not m_ssl:
|
||||
m = re.match(r"^3CX Notification:\s*Backup Complete\s*-\s*(.+)$", subject, flags=re.IGNORECASE)
|
||||
if not m:
|
||||
return False, {}, []
|
||||
|
||||
job_name = (m_backup or m_ssl).group(1).strip()
|
||||
job_name = m.group(1).strip()
|
||||
|
||||
body = (getattr(msg, "text_body", None) or getattr(msg, "body", None) or "")
|
||||
# Some sources store plain text in html_body; fall back if needed.
|
||||
if not body:
|
||||
body = getattr(msg, "html_body", None) or ""
|
||||
body = _normalize_text(body)
|
||||
|
||||
# SSL certificate renewal: store as a tracked informational run
|
||||
if m_ssl:
|
||||
result = {
|
||||
"backup_software": "3CX",
|
||||
"backup_type": "SSL Certificate",
|
||||
"job_name": job_name,
|
||||
"overall_status": "Success",
|
||||
"overall_message": body or None,
|
||||
}
|
||||
return True, result, []
|
||||
|
||||
# Backup complete
|
||||
backup_file = None
|
||||
m_file = re.search(r"^\s*Backup\s+name\s*:\s*(.+?)\s*$", body, flags=re.IGNORECASE | re.MULTILINE)
|
||||
if m_file:
|
||||
|
||||
@ -1,7 +1,6 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import re
|
||||
import html as _html
|
||||
from typing import Dict, Tuple, List, Optional
|
||||
|
||||
from ..models import MailMessage
|
||||
@ -18,311 +17,9 @@ VEEAM_BACKUP_TYPES = [
|
||||
"Veeam Backup for Microsoft 365",
|
||||
"Scale-out Backup Repository",
|
||||
"Health Check",
|
||||
"Cloud Connect Report",
|
||||
"Service Provider Console",
|
||||
]
|
||||
|
||||
|
||||
def normalize_vspc_company_name(name: str) -> str:
|
||||
"""Normalize a VSPC company name so it matches across HTML/text extraction and parsing."""
|
||||
n = _strip_html_tags(name or "")
|
||||
n = _html.unescape(n)
|
||||
n = n.replace("\xa0", " ")
|
||||
n = re.sub(r"\s+", " ", n).strip()
|
||||
return n
|
||||
|
||||
|
||||
def extract_vspc_active_alarms_companies(raw: str) -> List[str]:
|
||||
"""Best-effort extraction of company names from VSPC "Active alarms summary" bodies.
|
||||
|
||||
Only returns companies with alarms > 0.
|
||||
"""
|
||||
if not raw:
|
||||
return []
|
||||
|
||||
txt = raw
|
||||
if "<" in txt and ">" in txt:
|
||||
txt = re.sub(r"<[^>]+>", " ", txt)
|
||||
txt = _html.unescape(txt)
|
||||
txt = txt.replace("\xa0", " ")
|
||||
txt = re.sub(r"\s+", " ", txt).strip()
|
||||
|
||||
seen: set[str] = set()
|
||||
out: List[str] = []
|
||||
|
||||
for m in re.finditer(
|
||||
r"\bCompany:\s*([^\(\r\n]+?)\s*\(\s*alarms?\s*:\s*(\d+)\s*\)",
|
||||
txt,
|
||||
flags=re.IGNORECASE,
|
||||
):
|
||||
cname = normalize_vspc_company_name((m.group(1) or "").strip())
|
||||
try:
|
||||
alarms = int(m.group(2))
|
||||
except Exception:
|
||||
alarms = 0
|
||||
|
||||
if not cname or alarms <= 0:
|
||||
continue
|
||||
if cname in seen:
|
||||
continue
|
||||
seen.add(cname)
|
||||
out.append(cname)
|
||||
|
||||
return out
|
||||
|
||||
|
||||
def _parse_vspc_active_alarms_from_html(html: str) -> Tuple[List[Dict], str, Optional[str]]:
|
||||
"""Parse Veeam Service Provider Console (VSPC) Active Alarms summary emails.
|
||||
|
||||
The VSPC summary email can contain multiple companies. We keep this as a
|
||||
single Backupchecks run, but we prefix object names with the company name
|
||||
so alarms remain attributable per customer.
|
||||
|
||||
Returns: (objects, overall_status, overall_message)
|
||||
"""
|
||||
html = _normalize_html(html)
|
||||
if not html:
|
||||
return [], "Success", None
|
||||
|
||||
html_lower = html.lower()
|
||||
if "veeam service provider console" not in html_lower or "company" not in html_lower:
|
||||
return [], "Success", None
|
||||
|
||||
# Extract each company block and its first alarm table.
|
||||
# Company header example: "Company: AKR Performance (alarms: 2)"
|
||||
# Be defensive about line breaks (CR/LF) and HTML formatting.
|
||||
company_header_re = re.compile(
|
||||
r"(?is)company:\s*([^<\r\n]+?)\s*\(\s*alarms\s*:\s*(\d+)\s*\)"
|
||||
)
|
||||
|
||||
|
||||
# Build spans using HTML positions.
|
||||
headers = [(m.start(), m.end(), (m.group(1) or "").strip(), m.group(2)) for m in company_header_re.finditer(html)]
|
||||
if not headers:
|
||||
return [], "Success", None
|
||||
|
||||
objects: List[Dict] = []
|
||||
saw_failed = False
|
||||
saw_warning = False
|
||||
|
||||
for idx, (h_start, h_end, company_name, alarms_raw) in enumerate(headers):
|
||||
company_name = normalize_vspc_company_name(company_name)
|
||||
seg_start = h_end
|
||||
seg_end = headers[idx + 1][0] if idx + 1 < len(headers) else len(html)
|
||||
segment_html = html[seg_start:seg_end]
|
||||
|
||||
# Find the first table that looks like the Active Alarms table.
|
||||
m_table = re.search(r"(?is)<table[^>]*>.*?(Current\s*State).*?</table>", segment_html)
|
||||
if not m_table:
|
||||
continue
|
||||
table_html = m_table.group(0)
|
||||
|
||||
# Parse rows and cells.
|
||||
row_re = re.compile(r"(?is)<tr[^>]*>(.*?)</tr>")
|
||||
cell_re = re.compile(r"(?is)<t[dh][^>]*>(.*?)</t[dh]>")
|
||||
|
||||
rows = row_re.findall(table_html)
|
||||
if not rows:
|
||||
continue
|
||||
|
||||
# Determine column indexes from header row.
|
||||
colmap = {}
|
||||
header_cells = [_strip_html_tags(c).strip().lower() for c in cell_re.findall(rows[0])]
|
||||
for i, c in enumerate(header_cells):
|
||||
if c in {"current state", "currentstate"}:
|
||||
colmap["current_state"] = i
|
||||
elif c in {"object"}:
|
||||
colmap["object"] = i
|
||||
elif c in {"object type", "objecttype"}:
|
||||
colmap["object_type"] = i
|
||||
elif c in {"hostname"}:
|
||||
colmap["hostname"] = i
|
||||
elif c in {"time"}:
|
||||
colmap["time"] = i
|
||||
elif c in {"alarm name", "alarmname"}:
|
||||
colmap["alarm_name"] = i
|
||||
elif c in {"n. of repeats", "n.of repeats", "repeats"}:
|
||||
colmap["repeats"] = i
|
||||
elif c in {"alarm details", "alarmdetails", "details"}:
|
||||
colmap["alarm_details"] = i
|
||||
|
||||
# Basic validation: needs at least object + current state
|
||||
if "object" not in colmap or "current_state" not in colmap:
|
||||
continue
|
||||
|
||||
# Convert the entire company segment to text once for details matching.
|
||||
seg_text = _html_to_text_preserve_lines(segment_html)
|
||||
seg_lines = [ln.strip() for ln in (seg_text or "").splitlines() if ln.strip()]
|
||||
|
||||
for r in rows[1:]:
|
||||
cells = cell_re.findall(r)
|
||||
if not cells:
|
||||
continue
|
||||
plain = [_strip_html_tags(c).strip() for c in cells]
|
||||
|
||||
obj_name = plain[colmap["object"]].strip() if colmap["object"] < len(plain) else ""
|
||||
if not obj_name:
|
||||
continue
|
||||
|
||||
current_state = plain[colmap["current_state"]].strip() if colmap["current_state"] < len(plain) else ""
|
||||
obj_type = plain[colmap.get("object_type", -1)].strip() if colmap.get("object_type", -1) >= 0 and colmap.get("object_type", -1) < len(plain) else ""
|
||||
hostname = plain[colmap.get("hostname", -1)].strip() if colmap.get("hostname", -1) >= 0 and colmap.get("hostname", -1) < len(plain) else ""
|
||||
at_time = plain[colmap.get("time", -1)].strip() if colmap.get("time", -1) >= 0 and colmap.get("time", -1) < len(plain) else ""
|
||||
alarm_name = plain[colmap.get("alarm_name", -1)].strip() if colmap.get("alarm_name", -1) >= 0 and colmap.get("alarm_name", -1) < len(plain) else ""
|
||||
repeats = plain[colmap.get("repeats", -1)].strip() if colmap.get("repeats", -1) >= 0 and colmap.get("repeats", -1) < len(plain) else ""
|
||||
alarm_details = plain[colmap.get("alarm_details", -1)].strip() if colmap.get("alarm_details", -1) >= 0 and colmap.get("alarm_details", -1) < len(plain) else ""
|
||||
|
||||
state_lower = (current_state or "").lower()
|
||||
status = "Success"
|
||||
if state_lower in {"failed", "error", "critical"}:
|
||||
status = "Failed"
|
||||
saw_failed = True
|
||||
elif state_lower in {"warning", "warn"}:
|
||||
status = "Warning"
|
||||
saw_warning = True
|
||||
|
||||
# Prefer the explicit "Alarm Details" column if present.
|
||||
detail_line = alarm_details or None
|
||||
|
||||
# Otherwise try to find a more descriptive detail line in the company text.
|
||||
# Prefer lines that mention the object or alarm name and are long enough to be a real description.
|
||||
needles = [n for n in [obj_name, alarm_name] if n]
|
||||
if not detail_line:
|
||||
for ln in seg_lines:
|
||||
if len(ln) < 25:
|
||||
continue
|
||||
if any(n.lower() in ln.lower() for n in needles):
|
||||
detail_line = ln
|
||||
break
|
||||
|
||||
if not detail_line and alarm_name:
|
||||
# fallback: use alarm name with context
|
||||
parts = [alarm_name]
|
||||
ctx = []
|
||||
if hostname:
|
||||
ctx.append(f"Host: {hostname}")
|
||||
if at_time:
|
||||
ctx.append(f"Time: {at_time}")
|
||||
if repeats:
|
||||
ctx.append(f"Repeats: {repeats}")
|
||||
if ctx:
|
||||
parts.append("(" + ", ".join(ctx) + ")")
|
||||
detail_line = " ".join(parts).strip() or None
|
||||
|
||||
objects.append(
|
||||
{
|
||||
"name": f"{company_name} | {obj_name}" if company_name else obj_name,
|
||||
"type": obj_type or "Alarm",
|
||||
"status": status,
|
||||
"error_message": detail_line,
|
||||
}
|
||||
)
|
||||
|
||||
overall_status = "Success"
|
||||
if saw_failed:
|
||||
overall_status = "Failed"
|
||||
elif saw_warning:
|
||||
overall_status = "Warning"
|
||||
|
||||
overall_message = None
|
||||
return objects, overall_status, overall_message
|
||||
|
||||
|
||||
def _parse_cloud_connect_report_from_html(html: str) -> Tuple[List[Dict], str]:
|
||||
"""Parse Veeam Cloud Connect daily report (provider) HTML.
|
||||
|
||||
The report contains a "Backup" table with columns including:
|
||||
User | Repository Name | ...
|
||||
|
||||
Objects in our system are a combination of the "User" and "Repository Name"
|
||||
columns, separated by " | ".
|
||||
|
||||
Row background colour indicates status:
|
||||
- Red/pink rows: Failed/Error
|
||||
- Yellow/orange rows: Warning
|
||||
- White rows: Success
|
||||
|
||||
The row where the first cell is "TOTAL" is a summary row and is not an object.
|
||||
|
||||
Returns: (objects, overall_status)
|
||||
"""
|
||||
html = _normalize_html(html)
|
||||
if not html:
|
||||
return [], "Success"
|
||||
|
||||
# Find the Backup table block.
|
||||
m_table = re.search(r"(?is)<p[^>]*>\s*Backup\s*</p>\s*<table.*?</table>", html)
|
||||
if not m_table:
|
||||
return [], "Success"
|
||||
|
||||
table_html = m_table.group(0)
|
||||
|
||||
# Extract rows.
|
||||
row_pattern = re.compile(r"(?is)<tr([^>]*)>(.*?)</tr>")
|
||||
cell_pattern = re.compile(r"(?is)<t[dh][^>]*>(.*?)</t[dh]>")
|
||||
|
||||
objects: List[Dict] = []
|
||||
saw_failed = False
|
||||
saw_warning = False
|
||||
|
||||
for row_attr, row_inner in row_pattern.findall(table_html):
|
||||
cells = cell_pattern.findall(row_inner)
|
||||
if len(cells) < 3:
|
||||
continue
|
||||
|
||||
# Convert cells to plain text.
|
||||
plain = [_strip_html_tags(c).strip() for c in cells]
|
||||
if not plain:
|
||||
continue
|
||||
|
||||
# Skip header row.
|
||||
if plain[0].strip().lower() == "user":
|
||||
continue
|
||||
|
||||
user = (plain[0] or "").strip()
|
||||
repo_name = (plain[2] or "").strip()
|
||||
|
||||
# Skip summary row.
|
||||
if user.upper() == "TOTAL":
|
||||
continue
|
||||
|
||||
if not user and not repo_name:
|
||||
continue
|
||||
|
||||
# Determine status based on background colour.
|
||||
# Veeam uses inline styles like: background-color: #fb9895 (error)
|
||||
# and background-color: #ffd96c (warning).
|
||||
row_style = (row_attr or "")
|
||||
m_bg = re.search(r"(?i)background-color\s*:\s*([^;\"\s]+)", row_style)
|
||||
bg = (m_bg.group(1).strip().lower() if m_bg else "")
|
||||
|
||||
status = "Success"
|
||||
if bg in {"#fb9895", "#ff9999", "#f4cccc", "#ffb3b3"}:
|
||||
status = "Failed"
|
||||
saw_failed = True
|
||||
elif bg in {"#ffd96c", "#fff2cc", "#ffe599", "#f9cb9c"}:
|
||||
status = "Warning"
|
||||
saw_warning = True
|
||||
|
||||
name = f"{user} | {repo_name}".strip(" |")
|
||||
objects.append(
|
||||
{
|
||||
"name": name,
|
||||
"type": "Repository",
|
||||
"status": status,
|
||||
"error_message": None,
|
||||
}
|
||||
)
|
||||
|
||||
overall_status = "Success"
|
||||
if saw_failed:
|
||||
overall_status = "Failed"
|
||||
elif saw_warning:
|
||||
overall_status = "Warning"
|
||||
|
||||
return objects, overall_status
|
||||
|
||||
|
||||
def _strip_html_tags(value: str) -> str:
|
||||
"""Very small helper to strip HTML tags from a string."""
|
||||
if not value:
|
||||
@ -382,9 +79,7 @@ def _extract_configuration_job_overall_message(html: str) -> Optional[str]:
|
||||
for line in text.split("\n"):
|
||||
# Example:
|
||||
# 26-12-2025 10:00:23 Warning Skipping server certificate backup because encryption is disabled
|
||||
# 6-1-2026 10:00:16 Warning Skipping credentials backup because encryption is disabled
|
||||
# Veeam can format dates as either zero-padded (06-01-2026) or non-padded (6-1-2026).
|
||||
if re.match(r"^\d{1,2}-\d{1,2}-\d{4}\s+\d{2}:\d{2}:\d{2}\s+(Warning|Failed|Error)\b", line):
|
||||
if re.match(r"^\d{2}-\d{2}-\d{4}\s+\d{2}:\d{2}:\d{2}\s+(Warning|Failed|Error)\b", line):
|
||||
wanted_lines.append(line)
|
||||
|
||||
if not wanted_lines:
|
||||
@ -650,34 +345,12 @@ def _extract_m365_overall_details_message(html: str) -> Optional[str]:
|
||||
if not html:
|
||||
return None
|
||||
|
||||
html = _normalize_html(html)
|
||||
|
||||
# Strategy 1 (preferred): locate the "Details" header cell and then scan a small
|
||||
# window after it for a rowspan cell that contains the overall message.
|
||||
#
|
||||
# We intentionally avoid a single giant regex over the entire HTML body to keep
|
||||
# parsing fast and prevent worst-case backtracking on large messages.
|
||||
candidates: List[str] = []
|
||||
|
||||
hdr = re.search(r'(?is)<td[^>]*>\s*<b>\s*Details\s*</b>\s*</td>', html)
|
||||
if hdr:
|
||||
window = html[hdr.end() : hdr.end() + 6000]
|
||||
m = re.search(
|
||||
r'(?is)<td[^>]*rowspan\s*=\s*["\']?\s*(?:2|3|4|5|6|7|8|9|10)\s*["\']?[^>]*>(.*?)</td>',
|
||||
window,
|
||||
)
|
||||
if m:
|
||||
candidates = [m.group(1)]
|
||||
|
||||
# Strategy 2 (fallback): look for rowspan cells with rowspan >= 2.
|
||||
if not candidates:
|
||||
all_rowspans = re.findall(
|
||||
r'(?is)<td[^>]*rowspan\s*=\s*["\']?\s*([2-9]|10)\s*["\']?[^>]*>(.*?)</td>',
|
||||
html,
|
||||
)
|
||||
# re.findall above returns tuples (rowspan, content)
|
||||
candidates = [c[1] for c in all_rowspans] if all_rowspans else []
|
||||
|
||||
# Look for the summary "Details" cell (typically a header_td with rowspan).
|
||||
candidates = re.findall(
|
||||
r'<td[^>]*rowspan\s*=\s*["\']?\s*2\s*["\']?[^>]*>(.*?)</td>',
|
||||
html,
|
||||
flags=re.IGNORECASE | re.DOTALL,
|
||||
)
|
||||
if not candidates:
|
||||
return None
|
||||
|
||||
@ -1024,34 +697,6 @@ def _strip_retry_suffix(job_name: Optional[str]) -> Optional[str]:
|
||||
return cleaned or None
|
||||
|
||||
|
||||
def _strip_m365_combined_suffix(job_name: Optional[str]) -> Optional[str]:
|
||||
"""Remove the trailing "(Combined)" suffix from a Veeam M365 job name.
|
||||
|
||||
Veeam Backup for Microsoft 365 can send separate report emails where the
|
||||
job name is suffixed with "(Combined)" (e.g. "Tenant OneDrive (Combined)").
|
||||
Those should be treated as the same logical job as the non-suffixed name.
|
||||
"""
|
||||
if not job_name:
|
||||
return job_name
|
||||
|
||||
cleaned = re.sub(r"\s*\(\s*Combined\s*\)\s*$", "", job_name, flags=re.IGNORECASE).strip()
|
||||
return cleaned or None
|
||||
|
||||
|
||||
def _strip_full_suffix(job_name: Optional[str]) -> Optional[str]:
|
||||
"""Remove a trailing "(Full)" suffix from a Veeam job name.
|
||||
|
||||
Some Veeam installations create separate emails where the job name is
|
||||
suffixed with "(Full)" (e.g. "Backup VM DC01 (Full)"). Those should be
|
||||
treated as the same logical job as the non-suffixed name.
|
||||
"""
|
||||
if not job_name:
|
||||
return job_name
|
||||
|
||||
cleaned = re.sub(r"\s*\(\s*Full\s*\)\s*$", "", job_name, flags=re.IGNORECASE).strip()
|
||||
return cleaned or None
|
||||
|
||||
|
||||
def try_parse_veeam(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
"""Try to parse a Veeam backup report mail.
|
||||
|
||||
@ -1072,68 +717,17 @@ def try_parse_veeam(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
html_body = _normalize_html(getattr(msg, "html_body", None) or "")
|
||||
html_lower = html_body.lower()
|
||||
|
||||
# Veeam Cloud Connect provider daily report (no [Success]/[Warning] marker).
|
||||
is_cloud_connect_report = (
|
||||
"veeam cloud connect" in subject.lower()
|
||||
and "daily report" in subject.lower()
|
||||
and "repository name" in html_lower
|
||||
and "infrastructure status" in html_lower
|
||||
)
|
||||
|
||||
# Special-case: Veeam Backup for Microsoft 365 mails can come without a
|
||||
# subject marker. Detect via HTML and extract status from the banner.
|
||||
is_m365 = "veeam backup for microsoft 365" in html_lower
|
||||
|
||||
# VSPC Active Alarms summary (no [Success]/[Warning] marker).
|
||||
is_vspc_active_alarms = (
|
||||
("veeam service provider console" in html_lower)
|
||||
and ("active alarms" in html_lower or "active alarms summary" in subject.lower())
|
||||
and ("company:" in html_lower and "alarms" in html_lower)
|
||||
)
|
||||
|
||||
# If we cannot detect a status marker and this is not an M365 report,
|
||||
# we still try to parse when the subject strongly indicates a Veeam report.
|
||||
if not m_status and not m_finished and not is_m365 and not is_cloud_connect_report and not is_vspc_active_alarms:
|
||||
if not m_status and not m_finished and not is_m365:
|
||||
lowered = subject.lower()
|
||||
if not any(k in lowered for k in ["veeam", "cloud connect", "backup job", "backup copy job", "replica job", "configuration backup", "health check"]):
|
||||
if not any(k in lowered for k in ["veeam", "backup job", "backup copy job", "replica job", "configuration backup", "health check"]):
|
||||
return False, {}, []
|
||||
|
||||
# Handle Cloud Connect daily report early: overall status is derived from row colours.
|
||||
if is_cloud_connect_report:
|
||||
objects, overall_status = _parse_cloud_connect_report_from_html(html_body)
|
||||
|
||||
overall_message = None
|
||||
# Use the short subject summary when present, e.g. ": 2 Errors, 1 Warnings, 49 Successes".
|
||||
m_sum = re.search(r"(?i)daily\s+report\s*:\s*(.+)$", subject)
|
||||
if m_sum:
|
||||
overall_message = (m_sum.group(1) or "").strip() or None
|
||||
|
||||
result = {
|
||||
"backup_software": "Veeam",
|
||||
"backup_type": "Cloud Connect Report",
|
||||
"job_name": "Daily report",
|
||||
"overall_status": overall_status,
|
||||
}
|
||||
if overall_message:
|
||||
result["overall_message"] = overall_message
|
||||
|
||||
return True, result, objects
|
||||
|
||||
# Handle VSPC Active Alarms summary early.
|
||||
if is_vspc_active_alarms:
|
||||
objects, overall_status, overall_message = _parse_vspc_active_alarms_from_html(html_body)
|
||||
|
||||
result = {
|
||||
"backup_software": "Veeam",
|
||||
"backup_type": "Service Provider Console",
|
||||
"job_name": "Active alarms summary",
|
||||
"overall_status": overall_status,
|
||||
}
|
||||
if overall_message:
|
||||
result["overall_message"] = overall_message
|
||||
|
||||
return True, result, objects
|
||||
|
||||
if m_status:
|
||||
status_word = m_status.group(1)
|
||||
rest = m_status.group(2)
|
||||
@ -1258,15 +852,6 @@ def try_parse_veeam(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
# Do not let retry counters create distinct job names.
|
||||
job_name = _strip_retry_suffix(job_name)
|
||||
|
||||
# Veeam can append a "(Full)" suffix to the job name in some reports.
|
||||
# Strip it so full/non-full mails map to the same logical job.
|
||||
job_name = _strip_full_suffix(job_name)
|
||||
|
||||
# Veeam Backup for Microsoft 365 reports can add a "(Combined)" suffix.
|
||||
# Strip it so combined/non-combined mails map to the same job.
|
||||
if (backup_type or "") == "Veeam Backup for Microsoft 365":
|
||||
job_name = _strip_m365_combined_suffix(job_name)
|
||||
|
||||
# Health Check reports should always map to a stable job name.
|
||||
if (backup_type or '').lower() == 'health check':
|
||||
job_name = 'Health Check'
|
||||
@ -1281,7 +866,7 @@ def try_parse_veeam(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
result: Dict = {
|
||||
"backup_software": "Veeam",
|
||||
"backup_type": backup_type,
|
||||
"job_name": job_name,
|
||||
"job_name": _strip_retry_suffix(job_name),
|
||||
"overall_status": status_word,
|
||||
}
|
||||
|
||||
@ -1308,17 +893,8 @@ def try_parse_veeam(msg: MailMessage) -> Tuple[bool, Dict, List[Dict]]:
|
||||
|
||||
# Keep detailed overall message for non-success states, and always keep
|
||||
# the "Processing <object>" marker when present (used for overrides/rules).
|
||||
# Veeam Backup for Microsoft 365 can include a meaningful overall warning/info
|
||||
# even when the run is reported as Success (e.g. missing application
|
||||
# permissions/roles). Store it so it becomes visible in details and can be
|
||||
# used for overrides.
|
||||
is_m365 = (backup_type or "") == "Veeam Backup for Microsoft 365"
|
||||
if overall_message:
|
||||
if (
|
||||
status_word != "Success"
|
||||
or overall_message.lower().startswith("processing ")
|
||||
or is_m365
|
||||
):
|
||||
if status_word != "Success" or overall_message.lower().startswith("processing "):
|
||||
result["overall_message"] = overall_message
|
||||
|
||||
return True, result, objects
|
||||
|
||||
@ -14,76 +14,3 @@ main.dashboard-container {
|
||||
width: min(90vw, 1728px);
|
||||
max-width: 1728px;
|
||||
}
|
||||
|
||||
/* Prevent long detail values (e.g., email addresses) from overlapping other fields */
|
||||
.dl-compact dt {
|
||||
white-space: nowrap;
|
||||
}
|
||||
|
||||
.dl-compact .ellipsis-field {
|
||||
min-width: 0;
|
||||
overflow: hidden;
|
||||
text-overflow: ellipsis;
|
||||
white-space: nowrap;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
.dl-compact .ellipsis-field.is-expanded {
|
||||
overflow: visible;
|
||||
text-overflow: clip;
|
||||
white-space: normal;
|
||||
cursor: text;
|
||||
}
|
||||
|
||||
/* Markdown rendering (e.g., changelog page) */
|
||||
.markdown-content {
|
||||
overflow-wrap: anywhere;
|
||||
}
|
||||
|
||||
.markdown-content h1,
|
||||
.markdown-content h2,
|
||||
.markdown-content h3,
|
||||
.markdown-content h4,
|
||||
.markdown-content h5,
|
||||
.markdown-content h6 {
|
||||
margin-top: 1.25rem;
|
||||
margin-bottom: 0.75rem;
|
||||
}
|
||||
|
||||
.markdown-content p {
|
||||
margin-bottom: 0.75rem;
|
||||
}
|
||||
|
||||
.markdown-content ul,
|
||||
.markdown-content ol {
|
||||
margin-bottom: 0.75rem;
|
||||
}
|
||||
|
||||
.markdown-content pre {
|
||||
padding: 0.75rem;
|
||||
border-radius: 0.5rem;
|
||||
background: rgba(0, 0, 0, 0.05);
|
||||
overflow: auto;
|
||||
}
|
||||
|
||||
.markdown-content code {
|
||||
font-size: 0.95em;
|
||||
}
|
||||
|
||||
.markdown-content table {
|
||||
width: 100%;
|
||||
margin-bottom: 1rem;
|
||||
}
|
||||
|
||||
.markdown-content table th,
|
||||
.markdown-content table td {
|
||||
padding: 0.5rem;
|
||||
border-top: 1px solid rgba(0, 0, 0, 0.15);
|
||||
}
|
||||
|
||||
.markdown-content blockquote {
|
||||
border-left: 0.25rem solid rgba(0, 0, 0, 0.15);
|
||||
padding-left: 0.75rem;
|
||||
margin-left: 0;
|
||||
color: rgba(0, 0, 0, 0.7);
|
||||
}
|
||||
|
||||
@ -68,26 +68,10 @@
|
||||
<div class="collapse navbar-collapse" id="navbarNav">
|
||||
{% if current_user.is_authenticated %}
|
||||
<ul class="navbar-nav me-auto mb-2 mb-lg-0">
|
||||
{% if active_role == 'reporter' %}
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.reports') }}">Reports</a>
|
||||
</li>
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href='{{ url_for("main.changelog_page") }}'>Changelog</a>
|
||||
</li>
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.feedback_page') }}">Feedback</a>
|
||||
</li>
|
||||
{% else %}
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.inbox') }}">Inbox</a>
|
||||
</li>
|
||||
{% if active_role == 'admin' %}
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.admin_all_mails') }}">All Mail</a>
|
||||
</li>
|
||||
{% endif %}
|
||||
{% if active_role == 'admin' %}
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.inbox_deleted_mails') }}">Deleted mails</a>
|
||||
</li>
|
||||
@ -98,11 +82,6 @@
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.jobs') }}">Jobs</a>
|
||||
</li>
|
||||
{% if active_role == 'admin' %}
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.archived_jobs') }}">Archived Jobs</a>
|
||||
</li>
|
||||
{% endif %}
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.daily_jobs') }}">Daily Jobs</a>
|
||||
</li>
|
||||
@ -137,7 +116,6 @@
|
||||
<li class="nav-item">
|
||||
<a class="nav-link" href="{{ url_for('main.feedback_page') }}">Feedback</a>
|
||||
</li>
|
||||
{% endif %}
|
||||
</ul>
|
||||
<span class="navbar-text me-3">
|
||||
<a class="text-decoration-none" href="{{ url_for('main.user_settings') }}">
|
||||
@ -197,98 +175,5 @@
|
||||
</main>
|
||||
|
||||
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/js/bootstrap.bundle.min.js"></script>
|
||||
|
||||
<script>
|
||||
(function () {
|
||||
function isOverflowing(el) {
|
||||
try {
|
||||
return el && el.scrollWidth > el.clientWidth;
|
||||
} catch (e) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
function collapseExpandedEllipsis(root) {
|
||||
try {
|
||||
if (!root || !root.querySelectorAll) return;
|
||||
var expanded = root.querySelectorAll('.ellipsis-field.is-expanded');
|
||||
if (!expanded || !expanded.length) return;
|
||||
expanded.forEach(function (el) {
|
||||
el.classList.remove('is-expanded');
|
||||
setEllipsisTitle(el);
|
||||
});
|
||||
} catch (e) {
|
||||
// no-op
|
||||
}
|
||||
}
|
||||
|
||||
function setEllipsisTitle(el) {
|
||||
if (!el || el.classList.contains('is-expanded')) {
|
||||
return;
|
||||
}
|
||||
var txt = (el.textContent || '').trim();
|
||||
if (!txt) {
|
||||
el.removeAttribute('title');
|
||||
return;
|
||||
}
|
||||
if (isOverflowing(el)) {
|
||||
el.setAttribute('title', txt);
|
||||
} else {
|
||||
el.removeAttribute('title');
|
||||
}
|
||||
}
|
||||
|
||||
document.addEventListener('click', function (e) {
|
||||
var el = e.target;
|
||||
if (!el) return;
|
||||
if (!el.classList || !el.classList.contains('ellipsis-field')) return;
|
||||
// Ignore clicks on interactive children
|
||||
if (e.target.closest && e.target.closest('a, button, input, select, textarea, label')) return;
|
||||
el.classList.toggle('is-expanded');
|
||||
if (el.classList.contains('is-expanded')) {
|
||||
el.removeAttribute('title');
|
||||
} else {
|
||||
setEllipsisTitle(el);
|
||||
}
|
||||
});
|
||||
|
||||
document.addEventListener('dblclick', function (e) {
|
||||
var el = e.target;
|
||||
if (!el || !el.classList || !el.classList.contains('ellipsis-field')) return;
|
||||
// Expand on double click and select all text
|
||||
el.classList.add('is-expanded');
|
||||
el.removeAttribute('title');
|
||||
try {
|
||||
var range = document.createRange();
|
||||
range.selectNodeContents(el);
|
||||
var sel = window.getSelection();
|
||||
sel.removeAllRanges();
|
||||
sel.addRange(range);
|
||||
} catch (err) {
|
||||
// no-op
|
||||
}
|
||||
});
|
||||
|
||||
document.addEventListener('mouseover', function (e) {
|
||||
var el = e.target;
|
||||
if (!el || !el.classList || !el.classList.contains('ellipsis-field')) return;
|
||||
setEllipsisTitle(el);
|
||||
});
|
||||
|
||||
// Ensure expanded fields do not persist between popup/modal openings.
|
||||
document.addEventListener('show.bs.modal', function (e) {
|
||||
collapseExpandedEllipsis(e.target);
|
||||
});
|
||||
document.addEventListener('hidden.bs.modal', function (e) {
|
||||
collapseExpandedEllipsis(e.target);
|
||||
});
|
||||
document.addEventListener('show.bs.offcanvas', function (e) {
|
||||
collapseExpandedEllipsis(e.target);
|
||||
});
|
||||
document.addEventListener('hidden.bs.offcanvas', function (e) {
|
||||
collapseExpandedEllipsis(e.target);
|
||||
});
|
||||
})();
|
||||
</script>
|
||||
</body>
|
||||
</html>
|
||||
@ -1,362 +0,0 @@
|
||||
{% extends "layout/base.html" %}
|
||||
|
||||
<style>
|
||||
.modal-xxl { max-width: 98vw; }
|
||||
@media (min-width: 1400px) { .modal-xxl { max-width: 1400px; } }
|
||||
|
||||
#msg_body_container_iframe { height: 55vh; }
|
||||
#msg_objects_container { max-height: 25vh; overflow: auto; }
|
||||
|
||||
.filter-card .form-label { font-size: 0.85rem; }
|
||||
</style>
|
||||
|
||||
{# Pager macro must be defined before it is used #}
|
||||
{% macro pager(position, page, total_pages, has_prev, has_next, filter_params) -%}
|
||||
<div class="d-flex justify-content-between align-items-center my-2">
|
||||
<div>
|
||||
{% if has_prev %}
|
||||
<a class="btn btn-outline-secondary btn-sm" href="{{ url_for('main.admin_all_mails', page=page-1, **filter_params) }}">Previous</a>
|
||||
{% else %}
|
||||
<button class="btn btn-outline-secondary btn-sm" disabled>Previous</button>
|
||||
{% endif %}
|
||||
{% if has_next %}
|
||||
<a class="btn btn-outline-secondary btn-sm ms-2" href="{{ url_for('main.admin_all_mails', page=page+1, **filter_params) }}">Next</a>
|
||||
{% else %}
|
||||
<button class="btn btn-outline-secondary btn-sm ms-2" disabled>Next</button>
|
||||
{% endif %}
|
||||
</div>
|
||||
|
||||
<div class="d-flex align-items-center">
|
||||
<span class="me-2">Page {{ page }} of {{ total_pages }}</span>
|
||||
<form method="get" class="d-flex align-items-center mb-0">
|
||||
{% for k, v in filter_params.items() %}
|
||||
{% if v %}
|
||||
<input type="hidden" name="{{ k }}" value="{{ v }}" />
|
||||
{% endif %}
|
||||
{% endfor %}
|
||||
<label for="page_{{ position }}" class="form-label me-1 mb-0">Go to:</label>
|
||||
<input
|
||||
type="number"
|
||||
min="1"
|
||||
max="{{ total_pages }}"
|
||||
class="form-control form-control-sm me-1"
|
||||
id="page_{{ position }}"
|
||||
name="page"
|
||||
value="{{ page }}"
|
||||
style="width: 5rem;"
|
||||
/>
|
||||
<button type="submit" class="btn btn-primary btn-sm">Go</button>
|
||||
</form>
|
||||
</div>
|
||||
</div>
|
||||
{%- endmacro %}
|
||||
|
||||
{% block content %}
|
||||
<h2 class="mb-3">All Mail</h2>
|
||||
|
||||
<div class="card mb-3 filter-card">
|
||||
<div class="card-header d-flex justify-content-between align-items-center">
|
||||
<span>Search Filters</span>
|
||||
<div class="d-flex gap-3">
|
||||
<a class="small" href="{{ url_for('main.admin_all_mails') }}">Clear Filter Values</a>
|
||||
<button class="btn btn-primary btn-sm" type="submit" form="mailFilterForm">Search</button>
|
||||
</div>
|
||||
</div>
|
||||
<div class="card-body">
|
||||
<form id="mailFilterForm" method="get" action="{{ url_for('main.admin_all_mails') }}">
|
||||
<div class="row g-3">
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="from_q">From contains</label>
|
||||
<input class="form-control form-control-sm" type="text" id="from_q" name="from_q" value="{{ filter_params.from_q }}" />
|
||||
</div>
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="subject_q">Subject contains</label>
|
||||
<input class="form-control form-control-sm" type="text" id="subject_q" name="subject_q" value="{{ filter_params.subject_q }}" />
|
||||
</div>
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="backup_q">Backup contains</label>
|
||||
<input class="form-control form-control-sm" type="text" id="backup_q" name="backup_q" value="{{ filter_params.backup_q }}" />
|
||||
</div>
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="type_q">Type contains</label>
|
||||
<input class="form-control form-control-sm" type="text" id="type_q" name="type_q" value="{{ filter_params.type_q }}" />
|
||||
</div>
|
||||
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="job_name_q">Job name contains</label>
|
||||
<input class="form-control form-control-sm" type="text" id="job_name_q" name="job_name_q" value="{{ filter_params.job_name_q }}" />
|
||||
</div>
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="received_from">Received >=</label>
|
||||
<input class="form-control form-control-sm" type="datetime-local" id="received_from" name="received_from" value="{{ filter_params.received_from }}" />
|
||||
</div>
|
||||
<div class="col-12 col-lg-3">
|
||||
<label class="form-label" for="received_to">Received <=</label>
|
||||
<input class="form-control form-control-sm" type="datetime-local" id="received_to" name="received_to" value="{{ filter_params.received_to }}" />
|
||||
</div>
|
||||
<div class="col-12 col-lg-3 d-flex align-items-end">
|
||||
<div class="form-check">
|
||||
<input class="form-check-input" type="checkbox" id="only_unlinked" name="only_unlinked" value="1" {% if filter_params.only_unlinked %}checked{% endif %} />
|
||||
<label class="form-check-label" for="only_unlinked">Only unlinked</label>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</form>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{{ pager("top", page, total_pages, has_prev, has_next, filter_params) }}
|
||||
|
||||
<div class="table-responsive">
|
||||
<table class="table table-sm table-hover align-middle" id="mailAuditTable">
|
||||
<thead class="table-light">
|
||||
<tr>
|
||||
<th scope="col">Received</th>
|
||||
<th scope="col">From</th>
|
||||
<th scope="col">Subject</th>
|
||||
<th scope="col">Backup</th>
|
||||
<th scope="col">Type</th>
|
||||
<th scope="col">Job name</th>
|
||||
<th scope="col">Linked</th>
|
||||
<th scope="col">Parsed</th>
|
||||
<th scope="col">EML</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{% if rows %}
|
||||
{% for row in rows %}
|
||||
<tr class="mail-row" data-message-id="{{ row.id }}" style="cursor: pointer;">
|
||||
<td>{{ row.received_at }}</td>
|
||||
<td>{{ row.from_address }}</td>
|
||||
<td>{{ row.subject }}</td>
|
||||
<td>{{ row.backup_software }}</td>
|
||||
<td>{{ row.backup_type }}</td>
|
||||
<td>{{ row.job_name }}</td>
|
||||
<td>
|
||||
{% if row.linked %}
|
||||
<span class="badge bg-success">Linked</span>
|
||||
{% else %}
|
||||
<span class="badge bg-warning text-dark">Unlinked</span>
|
||||
{% endif %}
|
||||
</td>
|
||||
<td>{{ row.parsed_at }}</td>
|
||||
<td>
|
||||
{% if row.has_eml %}
|
||||
<a class="eml-download" href="{{ url_for('main.inbox_message_eml', message_id=row.id) }}" onclick="event.stopPropagation();">EML</a>
|
||||
{% endif %}
|
||||
</td>
|
||||
</tr>
|
||||
{% endfor %}
|
||||
{% else %}
|
||||
<tr>
|
||||
<td colspan="9" class="text-center text-muted py-3">No messages found.</td>
|
||||
</tr>
|
||||
{% endif %}
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
{{ pager("bottom", page, total_pages, has_prev, has_next, filter_params) }}
|
||||
|
||||
<div class="modal fade" id="mailMessageModal" tabindex="-1" aria-labelledby="mailMessageModalLabel" aria-hidden="true">
|
||||
<div class="modal-dialog modal-xl modal-dialog-scrollable modal-xxl">
|
||||
<div class="modal-content">
|
||||
<div class="modal-header">
|
||||
<h5 class="modal-title" id="mailMessageModalLabel">Message details</h5>
|
||||
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
|
||||
</div>
|
||||
<div class="modal-body">
|
||||
<div class="row">
|
||||
<div class="col-md-3">
|
||||
<dl class="row mb-0 dl-compact">
|
||||
<dt class="col-4">From</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_from"></dd>
|
||||
|
||||
<dt class="col-4">Backup</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_backup"></dd>
|
||||
|
||||
<dt class="col-4">Type</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_type"></dd>
|
||||
|
||||
<dt class="col-4">Job</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_job"></dd>
|
||||
|
||||
<dt class="col-4">Overall</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_overall"></dd>
|
||||
|
||||
<dt class="col-4">Customer</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_customer"></dd>
|
||||
|
||||
<dt class="col-4">Received</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_received"></dd>
|
||||
|
||||
<dt class="col-4">Parsed</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_parsed"></dd>
|
||||
|
||||
<dt class="col-4">Details</dt>
|
||||
<dd class="col-8" id="msg_overall_message" style="white-space: pre-wrap;"></dd>
|
||||
</dl>
|
||||
</div>
|
||||
|
||||
<div class="col-md-9">
|
||||
<div class="border rounded p-2 p-0" style="overflow:hidden;">
|
||||
<iframe id="msg_body_container_iframe" class="w-100" style="height:55vh; border:0; background:transparent;" sandbox="allow-popups allow-popups-to-escape-sandbox allow-top-navigation-by-user-activation"></iframe>
|
||||
</div>
|
||||
|
||||
<div class="mt-3">
|
||||
<div id="msg_objects_container"></div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="modal-footer">
|
||||
<button type="button" class="btn btn-secondary" data-bs-dismiss="modal">Close</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<script>
|
||||
(function () {
|
||||
function initAdminAllMailPopup() {
|
||||
var table = document.getElementById('mailAuditTable');
|
||||
var modalEl = document.getElementById('mailMessageModal');
|
||||
if (!table || !modalEl) return;
|
||||
|
||||
// base.html loads Bootstrap JS after the page content. Initialize after DOMContentLoaded
|
||||
// so bootstrap.Modal is guaranteed to be available.
|
||||
if (typeof bootstrap === 'undefined' || !bootstrap.Modal) return;
|
||||
|
||||
var modal = new bootstrap.Modal(modalEl);
|
||||
|
||||
function setText(id, value) {
|
||||
var el = document.getElementById(id);
|
||||
if (el) el.textContent = value || '';
|
||||
}
|
||||
|
||||
function objectSeverityRank(o) {
|
||||
var st = String((o && o.status) || '').trim().toLowerCase();
|
||||
var err = String((o && o.error_message) || '').trim();
|
||||
if (st === 'error' || st === 'failed' || st === 'failure' || err) return 0;
|
||||
if (st === 'warning') return 1;
|
||||
return 2;
|
||||
}
|
||||
|
||||
function sortObjects(objects) {
|
||||
return (objects || []).slice().sort(function (a, b) {
|
||||
var ra = objectSeverityRank(a);
|
||||
var rb = objectSeverityRank(b);
|
||||
if (ra !== rb) return ra - rb;
|
||||
|
||||
var na = String((a && a.name) || '').toLowerCase();
|
||||
var nb = String((b && b.name) || '').toLowerCase();
|
||||
if (na < nb) return -1;
|
||||
if (na > nb) return 1;
|
||||
|
||||
var ta = String((a && a.type) || '').toLowerCase();
|
||||
var tb = String((b && b.type) || '').toLowerCase();
|
||||
if (ta < tb) return -1;
|
||||
if (ta > tb) return 1;
|
||||
return 0;
|
||||
});
|
||||
}
|
||||
|
||||
function renderObjects(objects) {
|
||||
var container = document.getElementById('msg_objects_container');
|
||||
if (!container) return;
|
||||
container.innerHTML = '';
|
||||
|
||||
if (!objects || !objects.length) {
|
||||
container.innerHTML = '<div class="text-muted">No objects stored.</div>';
|
||||
return;
|
||||
}
|
||||
|
||||
var tableHtml = '<div class="table-responsive"><table class="table table-sm table-hover align-middle">' +
|
||||
'<thead class="table-light"><tr><th>Name</th><th>Type</th><th>Status</th><th>Error</th></tr></thead><tbody>';
|
||||
|
||||
var sorted = sortObjects(objects);
|
||||
|
||||
for (var i = 0; i < sorted.length; i++) {
|
||||
var o = sorted[i] || {};
|
||||
tableHtml += '<tr>' +
|
||||
'<td>' + (o.name || '') + '</td>' +
|
||||
'<td>' + (o.type || '') + '</td>' +
|
||||
'<td>' + (o.status || '') + '</td>' +
|
||||
'<td style="white-space: pre-wrap;">' + (o.error_message || '') + '</td>' +
|
||||
'</tr>';
|
||||
}
|
||||
|
||||
tableHtml += '</tbody></table></div>';
|
||||
container.innerHTML = tableHtml;
|
||||
}
|
||||
|
||||
function wrapMailHtml(html) {
|
||||
html = html || "";
|
||||
var trimmed = (typeof html === "string") ? html.trim() : "";
|
||||
var injection = '<meta charset="utf-8"><meta name="color-scheme" content="light"><meta name="supported-color-schemes" content="light"><meta name="viewport" content="width=device-width, initial-scale=1"><base target="_blank"><style>:root{color-scheme:light;}html{color-scheme:light;}body{margin:0;padding:8px;background:#fff;forced-color-adjust:none;-ms-high-contrast-adjust:none;}</style>';
|
||||
|
||||
function injectIntoFullDoc(doc) {
|
||||
var d = doc || "";
|
||||
if (/<head[^>]*>/i.test(d)) {
|
||||
return d.replace(/<head[^>]*>/i, function (m) { return m + injection; });
|
||||
}
|
||||
if (/<html[^>]*>/i.test(d)) {
|
||||
return d.replace(/<html[^>]*>/i, function (m) { return m + "<head>" + injection + "</head>"; });
|
||||
}
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + d + "</body></html>";
|
||||
}
|
||||
|
||||
if (trimmed.toLowerCase().indexOf("<!doctype") === 0 || trimmed.toLowerCase().indexOf("<html") === 0) {
|
||||
return injectIntoFullDoc(trimmed);
|
||||
}
|
||||
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + html + "</body></html>";
|
||||
}
|
||||
|
||||
function setIframeHtml(html) {
|
||||
var iframe = document.getElementById('msg_body_container_iframe');
|
||||
if (!iframe) return;
|
||||
iframe.srcdoc = wrapMailHtml(html || '<p>No message content stored.</p>');
|
||||
}
|
||||
|
||||
async function openMessage(messageId) {
|
||||
try {
|
||||
var res = await fetch('{{ url_for('main.inbox_message_detail', message_id=0) }}'.replace('/0', '/' + messageId));
|
||||
if (!res.ok) throw new Error('Failed to load message');
|
||||
var data = await res.json();
|
||||
if (!data || data.status !== 'ok') throw new Error('Invalid response');
|
||||
|
||||
var meta = data.meta || {};
|
||||
setText('msg_from', meta.from_address);
|
||||
setText('msg_backup', meta.backup_software);
|
||||
setText('msg_type', meta.backup_type);
|
||||
setText('msg_job', meta.job_name);
|
||||
setText('msg_overall', meta.overall_status);
|
||||
setText('msg_customer', meta.customer_name);
|
||||
setText('msg_received', meta.received_at);
|
||||
setText('msg_parsed', meta.parsed_at);
|
||||
setText('msg_overall_message', meta.overall_message);
|
||||
|
||||
setIframeHtml(data.body_html || "");
|
||||
renderObjects(data.objects);
|
||||
|
||||
modal.show();
|
||||
} catch (e) {
|
||||
alert('Unable to open message details.');
|
||||
}
|
||||
}
|
||||
|
||||
table.addEventListener('click', function (e) {
|
||||
var tr = e.target.closest('tr.mail-row');
|
||||
if (!tr) return;
|
||||
var id = tr.getAttribute('data-message-id');
|
||||
if (!id) return;
|
||||
openMessage(id);
|
||||
});
|
||||
}
|
||||
|
||||
document.addEventListener('DOMContentLoaded', initAdminAllMailPopup);
|
||||
})();
|
||||
</script>
|
||||
|
||||
{% endblock %}
|
||||
@ -1,45 +0,0 @@
|
||||
{% extends "layout/base.html" %}
|
||||
{% block content %}
|
||||
<h2 class="mb-3">Archived Jobs</h2>
|
||||
|
||||
<div class="table-responsive">
|
||||
<table class="table table-sm table-hover align-middle">
|
||||
<thead class="table-light">
|
||||
<tr>
|
||||
<th scope="col">Customer</th>
|
||||
<th scope="col">Backup</th>
|
||||
<th scope="col">Type</th>
|
||||
<th scope="col">Job name</th>
|
||||
<th scope="col">Archived at</th>
|
||||
<th scope="col" class="text-end">Actions</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{% if jobs %}
|
||||
{% for j in jobs %}
|
||||
<tr>
|
||||
<td>{{ j.customer_name }}</td>
|
||||
<td>{{ j.backup_software }}</td>
|
||||
<td>{{ j.backup_type }}</td>
|
||||
<td>
|
||||
<a class="text-decoration-none" href="{{ url_for('main.job_detail', job_id=j.id) }}">{{ j.job_name }}</a>
|
||||
</td>
|
||||
<td>{{ j.archived_at }}</td>
|
||||
<td class="text-end">
|
||||
<form method="post" action="{{ url_for('main.unarchive_job', job_id=j.id) }}" style="display:inline;">
|
||||
<button type="submit" class="btn btn-sm btn-outline-secondary">Restore</button>
|
||||
</form>
|
||||
</td>
|
||||
</tr>
|
||||
{% endfor %}
|
||||
{% else %}
|
||||
<tr>
|
||||
<td colspan="6" class="text-center text-muted py-3">
|
||||
No archived jobs found.
|
||||
</td>
|
||||
</tr>
|
||||
{% endif %}
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
{% endblock %}
|
||||
@ -4,29 +4,74 @@
|
||||
<div class="d-flex align-items-center justify-content-between mb-3">
|
||||
<div>
|
||||
<h1 class="h3 mb-1">Changelog</h1>
|
||||
<div class="text-body-secondary">Loaded live from the repository.</div>
|
||||
<div class="text-body-secondary">Product versions and changes.</div>
|
||||
</div>
|
||||
{% if changelog_source_url %}
|
||||
<div class="text-end">
|
||||
<a class="btn btn-sm btn-outline-secondary" href="{{ changelog_source_url }}" target="_blank" rel="noopener">
|
||||
View source
|
||||
</a>
|
||||
</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
|
||||
{% if changelog_error %}
|
||||
<div class="alert alert-warning" role="alert">
|
||||
{{ changelog_error }}
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
<div class="card">
|
||||
{# Completed (summary) #}
|
||||
<div class="card mb-4">
|
||||
<div class="card-header d-flex align-items-center justify-content-between">
|
||||
<div class="fw-semibold">Completed</div>
|
||||
<span class="badge text-bg-primary">History</span>
|
||||
</div>
|
||||
<div class="card-body">
|
||||
{% if changelog_html %}
|
||||
<div class="markdown-content">{{ changelog_html | safe }}</div>
|
||||
{% if changelog.completed_summary and changelog.completed_summary|length > 0 %}
|
||||
<div class="accordion" id="changelogCompletedAccordion">
|
||||
{% for item in changelog.completed_summary %}
|
||||
<div class="accordion-item">
|
||||
<h2 class="accordion-header" id="completedHeading{{ loop.index }}">
|
||||
<button class="accordion-button {% if not loop.first %}collapsed{% endif %}" type="button" data-bs-toggle="collapse" data-bs-target="#completedCollapse{{ loop.index }}" aria-expanded="{% if loop.first %}true{% else %}false{% endif %}" aria-controls="completedCollapse{{ loop.index }}">
|
||||
<span class="fw-semibold">v{{ item.version }}</span>
|
||||
</button>
|
||||
</h2>
|
||||
<div id="completedCollapse{{ loop.index }}" class="accordion-collapse collapse {% if loop.first %}show{% endif %}" aria-labelledby="completedHeading{{ loop.index }}" data-bs-parent="#changelogCompletedAccordion">
|
||||
<div class="accordion-body">
|
||||
{% if item.overview and item.overview|length > 0 %}
|
||||
{% for p in item.overview %}
|
||||
<p class="mb-2">{{ p }}</p>
|
||||
{% endfor %}
|
||||
{% endif %}
|
||||
|
||||
{% if item.categories and item.categories|length > 0 %}
|
||||
{% for cat in item.categories %}
|
||||
<div class="fw-semibold mb-2">{{ cat.category }}</div>
|
||||
|
||||
{# NOTE: 'items' is a dict key; use bracket notation to avoid calling dict.items() #}
|
||||
{% if cat['items'] and cat['items']|length > 0 %}
|
||||
{% for it in cat['items'] %}
|
||||
<div class="mb-3">
|
||||
{% if it.title %}
|
||||
<div class="fw-semibold">{{ it.title }}</div>
|
||||
{% endif %}
|
||||
{% if it.details and it.details|length > 0 %}
|
||||
<ul class="mb-0">
|
||||
{% for d in it.details %}
|
||||
<li>{{ d }}</li>
|
||||
{% endfor %}
|
||||
</ul>
|
||||
{% endif %}
|
||||
</div>
|
||||
{% endfor %}
|
||||
{% else %}
|
||||
<div class="text-body-secondary mb-3">No items in this section.</div>
|
||||
{% endif %}
|
||||
{% endfor %}
|
||||
{% elif item.highlights and item.highlights|length > 0 %}
|
||||
<ul class="mb-0">
|
||||
{% for h in item.highlights %}
|
||||
<li>{{ h }}</li>
|
||||
{% endfor %}
|
||||
</ul>
|
||||
{% else %}
|
||||
<div class="text-body-secondary">No details.</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
{% endfor %}
|
||||
</div>
|
||||
{% else %}
|
||||
<div class="text-body-secondary">No changelog content available.</div>
|
||||
<div class="text-body-secondary">No completed items.</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
@ -172,18 +172,18 @@
|
||||
<div id="dj_runs_list" class="list-group"></div>
|
||||
</div>
|
||||
<div class="col-md-9 dj-detail-col">
|
||||
<dl class="row mb-3 dl-compact">
|
||||
<dl class="row mb-3">
|
||||
<dt class="col-3">From</dt>
|
||||
<dd class="col-9 ellipsis-field" id="dj_from"></dd>
|
||||
<dd class="col-9" id="dj_from"></dd>
|
||||
|
||||
<dt class="col-3">Subject</dt>
|
||||
<dd class="col-9 ellipsis-field" id="dj_subject"></dd>
|
||||
<dd class="col-9" id="dj_subject"></dd>
|
||||
|
||||
<dt class="col-3">Received</dt>
|
||||
<dd class="col-9 ellipsis-field" id="dj_received"></dd>
|
||||
<dd class="col-9" id="dj_received"></dd>
|
||||
|
||||
<dt class="col-3">Status</dt>
|
||||
<dd class="col-9 ellipsis-field" id="dj_status"></dd>
|
||||
<dd class="col-9" id="dj_status"></dd>
|
||||
|
||||
<dt class="col-3">Remark</dt>
|
||||
<dd class="col-9" id="dj_remark" style="white-space: pre-wrap;"></dd>
|
||||
@ -200,9 +200,9 @@
|
||||
<button type="button" class="btn btn-sm btn-outline-primary" id="dj_ticket_save">Add</button>
|
||||
</div>
|
||||
<div class="mt-2">
|
||||
<input class="form-control form-control-sm" id="dj_ticket_code" type="text" placeholder="Ticket number (e.g., T20260106.0001)" />
|
||||
<textarea class="form-control form-control-sm" id="dj_ticket_description" rows="2" placeholder="Description (optional)"></textarea>
|
||||
</div>
|
||||
<div class="mt-2 small text-muted" id="dj_ticket_status"></div>
|
||||
<div class="mt-2 small text-muted" id="dj_ticket_status"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="col-12 col-lg-6">
|
||||
@ -234,6 +234,7 @@
|
||||
</div>
|
||||
|
||||
<div class="dj-objects-panel">
|
||||
<h6>Objects</h6>
|
||||
<div class="table-responsive dj-objects-scroll">
|
||||
<table class="table table-sm table-bordered" id="dj_objects_table">
|
||||
<thead class="table-light" style="position: sticky; top: 0; z-index: 1;">
|
||||
@ -292,59 +293,24 @@
|
||||
return "";
|
||||
}
|
||||
|
||||
function objectSeverityRank(o) {
|
||||
var st = String((o && o.status) || '').trim().toLowerCase();
|
||||
var err = String((o && o.error_message) || '').trim();
|
||||
if (st === 'error' || st === 'failed' || st === 'failure' || err) return 0;
|
||||
if (st === 'warning') return 1;
|
||||
return 2;
|
||||
}
|
||||
|
||||
function sortObjects(objects) {
|
||||
return (objects || []).slice().sort(function (a, b) {
|
||||
var ra = objectSeverityRank(a);
|
||||
var rb = objectSeverityRank(b);
|
||||
if (ra !== rb) return ra - rb;
|
||||
|
||||
var na = String((a && a.name) || '').toLowerCase();
|
||||
var nb = String((b && b.name) || '').toLowerCase();
|
||||
if (na < nb) return -1;
|
||||
if (na > nb) return 1;
|
||||
|
||||
var ta = String((a && a.type) || '').toLowerCase();
|
||||
var tb = String((b && b.type) || '').toLowerCase();
|
||||
if (ta < tb) return -1;
|
||||
if (ta > tb) return 1;
|
||||
return 0;
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
|
||||
function wrapMailHtml(html) {
|
||||
function wrapMailHtml(html) {
|
||||
html = html || "";
|
||||
var trimmed = (typeof html === "string") ? html.trim() : "";
|
||||
var injection = '<meta charset="utf-8"><meta name="color-scheme" content="light"><meta name="supported-color-schemes" content="light"><meta name="viewport" content="width=device-width, initial-scale=1"><base target="_blank"><style>:root{color-scheme:light;}html{color-scheme:light;}body{margin:0;padding:8px;background:#fff;forced-color-adjust:none;-ms-high-contrast-adjust:none;}</style>';
|
||||
|
||||
function injectIntoFullDoc(doc) {
|
||||
var d = doc || "";
|
||||
if (/<head[^>]*>/i.test(d)) {
|
||||
return d.replace(/<head[^>]*>/i, function (m) { return m + injection; });
|
||||
}
|
||||
if (/<html[^>]*>/i.test(d)) {
|
||||
return d.replace(/<html[^>]*>/i, function (m) { return m + "<head>" + injection + "</head>"; });
|
||||
}
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + d + "</body></html>";
|
||||
}
|
||||
|
||||
if (trimmed.toLowerCase().indexOf("<!doctype") === 0 || trimmed.toLowerCase().indexOf("<html") === 0) {
|
||||
return injectIntoFullDoc(trimmed);
|
||||
}
|
||||
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + html + "</body></html>";
|
||||
// Ensure we render the mail HTML with its own CSS, isolated from the site styling.
|
||||
return (
|
||||
"<!doctype html><html><head><meta charset=\"utf-8\">" +
|
||||
"<base target=\"_blank\">" +
|
||||
"</head><body style=\"margin:0; padding:8px;\">" +
|
||||
html +
|
||||
"</body></html>"
|
||||
);
|
||||
}
|
||||
|
||||
function escapeHtml(s) {
|
||||
var currentJobId = null;
|
||||
var currentRunId = null;
|
||||
|
||||
function escapeHtml(s) {
|
||||
return (s || "").toString()
|
||||
.replace(/&/g, "&")
|
||||
.replace(/</g, "<")
|
||||
@ -390,13 +356,27 @@ function escapeHtml(s) {
|
||||
'<div class="text-truncate">' +
|
||||
'<span class="me-1" title="Ticket">🎫</span>' +
|
||||
'<span class="fw-semibold">' + escapeHtml(t.ticket_code || '') + '</span>' +
|
||||
'<span class="ms-2 badge ' + (t.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status + '</span>' +
|
||||
'<span class="ms-2 badge ' + (t.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status + '</span>' +
|
||||
'</div>' +
|
||||
(t.description ? ('<div class="small text-muted mt-1">' + escapeHtml(t.description) + '</div>') : '') +
|
||||
'</div>' +
|
||||
'<div class="d-flex gap-1 flex-shrink-0">' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="toggle-edit-ticket" data-id="' + t.id + '" ' + (t.resolved_at ? 'disabled' : '') + '>Edit</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-success" data-action="resolve-ticket" data-id="' + t.id + '" ' + (t.resolved_at ? 'disabled' : '') + '>Resolve</button>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'<div class="mt-2" data-edit="ticket" style="display:none;">' +
|
||||
'<div class="row g-2">' +
|
||||
'<div class="col-12">' +
|
||||
'<textarea class="form-control form-control-sm" data-field="description" rows="2" placeholder="Description (optional)">' + escapeHtml(t.description || '') + '</textarea>' +
|
||||
'</div>' +
|
||||
'<div class="col-12 d-flex gap-2">' +
|
||||
'<button type="button" class="btn btn-sm btn-primary" data-action="save-ticket" data-id="' + t.id + '">Save</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="cancel-edit" data-id="' + t.id + '">Cancel</button>' +
|
||||
'<div class="small text-muted align-self-center" data-field="status"></div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>';
|
||||
});
|
||||
html += '</div></div>';
|
||||
@ -417,9 +397,22 @@ function escapeHtml(s) {
|
||||
(r.body ? ('<div class="small text-muted mt-1">' + escapeHtml(r.body) + '</div>') : '') +
|
||||
'</div>' +
|
||||
'<div class="d-flex gap-1 flex-shrink-0">' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="toggle-edit-remark" data-id="' + r.id + '" ' + (r.resolved_at ? 'disabled' : '') + '>Edit</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-success" data-action="resolve-remark" data-id="' + r.id + '" ' + (r.resolved_at ? 'disabled' : '') + '>Resolve</button>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'<div class="mt-2" data-edit="remark" style="display:none;">' +
|
||||
'<div class="row g-2">' +
|
||||
'<div class="col-12">' +
|
||||
'<textarea class="form-control form-control-sm" data-field="body" rows="2" placeholder="Body (required)">' + escapeHtml(r.body || '') + '</textarea>' +
|
||||
'</div>' +
|
||||
'<div class="col-12 d-flex gap-2">' +
|
||||
'<button type="button" class="btn btn-sm btn-primary" data-action="save-remark" data-id="' + r.id + '">Save</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="cancel-edit" data-id="' + r.id + '">Cancel</button>' +
|
||||
'<div class="small text-muted align-self-center" data-field="status"></div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>';
|
||||
});
|
||||
html += '</div></div>';
|
||||
@ -434,6 +427,8 @@ function escapeHtml(s) {
|
||||
var id = btn.getAttribute('data-id');
|
||||
if (!action || !id) return;
|
||||
|
||||
var wrapper = btn.closest('[data-alert-type]');
|
||||
|
||||
if (action === 'resolve-ticket') {
|
||||
if (!confirm('Mark ticket as resolved?')) return;
|
||||
apiJson('/api/tickets/' + encodeURIComponent(id) + '/resolve', {method: 'POST', body: '{}'})
|
||||
@ -444,6 +439,59 @@ function escapeHtml(s) {
|
||||
apiJson('/api/remarks/' + encodeURIComponent(id) + '/resolve', {method: 'POST', body: '{}'})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) { alert(e.message || 'Failed.'); });
|
||||
} else if (action === 'toggle-edit-ticket') {
|
||||
if (!wrapper) return;
|
||||
var edit = wrapper.querySelector('[data-edit="ticket"]');
|
||||
if (!edit) return;
|
||||
edit.style.display = (edit.style.display === 'none' || !edit.style.display) ? '' : 'none';
|
||||
} else if (action === 'toggle-edit-remark') {
|
||||
if (!wrapper) return;
|
||||
var edit2 = wrapper.querySelector('[data-edit="remark"]');
|
||||
if (!edit2) return;
|
||||
edit2.style.display = (edit2.style.display === 'none' || !edit2.style.display) ? '' : 'none';
|
||||
} else if (action === 'cancel-edit') {
|
||||
if (!wrapper) return;
|
||||
var editAny = wrapper.querySelector('[data-edit]');
|
||||
if (editAny) editAny.style.display = 'none';
|
||||
} else if (action === 'save-ticket') {
|
||||
if (!wrapper) return;
|
||||
var editT = wrapper.querySelector('[data-edit="ticket"]');
|
||||
if (!editT) return;
|
||||
var descEl = editT.querySelector('[data-field="description"]');
|
||||
var statusEl = editT.querySelector('[data-field="status"]');
|
||||
var descVal = descEl ? descEl.value : '';
|
||||
if (statusEl) statusEl.textContent = 'Saving...';
|
||||
apiJson('/api/tickets/' + encodeURIComponent(id), {
|
||||
method: 'PATCH',
|
||||
body: JSON.stringify({description: descVal})
|
||||
})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) {
|
||||
if (statusEl) statusEl.textContent = e.message || 'Failed.';
|
||||
else alert(e.message || 'Failed.');
|
||||
});
|
||||
} else if (action === 'save-remark') {
|
||||
if (!wrapper) return;
|
||||
var editR = wrapper.querySelector('[data-edit="remark"]');
|
||||
if (!editR) return;
|
||||
var bodyEl2 = editR.querySelector('[data-field="body"]');
|
||||
var statusEl2 = editR.querySelector('[data-field="status"]');
|
||||
var bodyVal2 = bodyEl2 ? bodyEl2.value : '';
|
||||
if (!bodyVal2 || !bodyVal2.trim()) {
|
||||
if (statusEl2) statusEl2.textContent = 'Body is required.';
|
||||
else alert('Body is required.');
|
||||
return;
|
||||
}
|
||||
if (statusEl2) statusEl2.textContent = 'Saving...';
|
||||
apiJson('/api/remarks/' + encodeURIComponent(id), {
|
||||
method: 'PATCH',
|
||||
body: JSON.stringify({body: bodyVal2})
|
||||
})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) {
|
||||
if (statusEl2) statusEl2.textContent = e.message || 'Failed.';
|
||||
else alert(e.message || 'Failed.');
|
||||
});
|
||||
}
|
||||
});
|
||||
});
|
||||
@ -480,8 +528,8 @@ function escapeHtml(s) {
|
||||
function bindInlineCreateForms() {
|
||||
var btnTicket = document.getElementById('dj_ticket_save');
|
||||
var btnRemark = document.getElementById('dj_remark_save');
|
||||
var tCode = document.getElementById('dj_ticket_code');
|
||||
var tStatus = document.getElementById('dj_ticket_status');
|
||||
var tDesc = document.getElementById('dj_ticket_description');
|
||||
var tStatus = document.getElementById('dj_ticket_status');
|
||||
var rBody = document.getElementById('dj_remark_body');
|
||||
var rStatus = document.getElementById('dj_remark_status');
|
||||
|
||||
@ -493,8 +541,8 @@ var tStatus = document.getElementById('dj_ticket_status');
|
||||
function setDisabled(disabled) {
|
||||
if (btnTicket) btnTicket.disabled = disabled;
|
||||
if (btnRemark) btnRemark.disabled = disabled;
|
||||
if (tCode) tCode.disabled = disabled;
|
||||
if (rBody) rBody.disabled = disabled;
|
||||
if (tDesc) tDesc.disabled = disabled;
|
||||
if (rBody) rBody.disabled = disabled;
|
||||
}
|
||||
|
||||
window.__djSetCreateDisabled = setDisabled;
|
||||
@ -504,25 +552,15 @@ if (rBody) rBody.disabled = disabled;
|
||||
btnTicket.addEventListener('click', function () {
|
||||
if (!currentRunId) { alert('Select a run first.'); return; }
|
||||
clearStatus();
|
||||
var ticket_code = tCode ? (tCode.value || '').trim().toUpperCase() : '';
|
||||
if (!ticket_code) {
|
||||
if (tStatus) tStatus.textContent = 'Ticket number is required.';
|
||||
else alert('Ticket number is required.');
|
||||
return;
|
||||
}
|
||||
if (!/^T\d{8}\.\d{4}$/.test(ticket_code)) {
|
||||
if (tStatus) tStatus.textContent = 'Invalid ticket number format. Expected TYYYYMMDD.####.';
|
||||
else alert('Invalid ticket number format. Expected TYYYYMMDD.####.');
|
||||
return;
|
||||
}
|
||||
var description = tDesc ? tDesc.value : '';
|
||||
if (tStatus) tStatus.textContent = 'Saving...';
|
||||
apiJson('/api/tickets', {
|
||||
method: 'POST',
|
||||
body: JSON.stringify({job_run_id: currentRunId, ticket_code: ticket_code})
|
||||
body: JSON.stringify({job_run_id: currentRunId, description: description})
|
||||
})
|
||||
.then(function () {
|
||||
if (tCode) tCode.value = '';
|
||||
if (tStatus) tStatus.textContent = '';
|
||||
if (tDesc) tDesc.value = '';
|
||||
if (tStatus) tStatus.textContent = '';
|
||||
loadAlerts(currentRunId);
|
||||
})
|
||||
.catch(function (e) {
|
||||
@ -640,7 +678,7 @@ if (tStatus) tStatus.textContent = '';
|
||||
|
||||
var tbody = document.querySelector("#dj_objects_table tbody");
|
||||
tbody.innerHTML = "";
|
||||
sortObjects(run.objects || []).forEach(function (obj) {
|
||||
(run.objects || []).forEach(function (obj) {
|
||||
var tr = document.createElement("tr");
|
||||
|
||||
var tdName = document.createElement("td");
|
||||
|
||||
@ -49,46 +49,6 @@
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="card mb-3">
|
||||
<div class="card-body">
|
||||
<h5 class="card-title mb-3">Replies</h5>
|
||||
{% if replies %}
|
||||
<div class="list-group list-group-flush">
|
||||
{% for r in replies %}
|
||||
<div class="list-group-item px-0">
|
||||
<div class="d-flex justify-content-between align-items-start">
|
||||
<strong>{{ reply_user_map.get(r.user_id, '') or ('User #' ~ r.user_id) }}</strong>
|
||||
<span class="text-muted" style="font-size: 0.85rem;">
|
||||
{{ r.created_at.strftime('%d-%m-%Y %H:%M:%S') if r.created_at else '' }}
|
||||
</span>
|
||||
</div>
|
||||
<div style="white-space: pre-wrap;">{{ r.message }}</div>
|
||||
</div>
|
||||
{% endfor %}
|
||||
</div>
|
||||
{% else %}
|
||||
<div class="text-muted">No replies yet.</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="card mb-3">
|
||||
<div class="card-body">
|
||||
<h5 class="card-title mb-3">Add reply</h5>
|
||||
{% if item.status == 'open' %}
|
||||
<form method="post" action="{{ url_for('main.feedback_reply', item_id=item.id) }}">
|
||||
<div class="mb-2">
|
||||
<textarea class="form-control" name="message" rows="4" required></textarea>
|
||||
</div>
|
||||
<button type="submit" class="btn btn-primary">Post reply</button>
|
||||
</form>
|
||||
{% else %}
|
||||
<div class="text-muted">Replies can only be added while the item is open.</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
|
||||
<div class="col-12 col-lg-4">
|
||||
<div class="card">
|
||||
<div class="card-body">
|
||||
|
||||
@ -56,26 +56,10 @@
|
||||
|
||||
{{ pager("top", page, total_pages, has_prev, has_next) }}
|
||||
|
||||
{% if can_bulk_delete %}
|
||||
<div class="d-flex justify-content-between align-items-center mb-2">
|
||||
<div class="btn-group">
|
||||
<button type="button" class="btn btn-sm btn-outline-danger" id="btn_inbox_delete_selected" disabled>Delete selected</button>
|
||||
</div>
|
||||
</div>
|
||||
<div class="small text-muted mb-2" id="inbox_status"></div>
|
||||
{% endif %}
|
||||
|
||||
|
||||
|
||||
<div class="table-responsive">
|
||||
<table class="table table-sm table-hover align-middle" id="inboxTable">
|
||||
<table class="table table-sm table-hover align-middle">
|
||||
<thead class="table-light">
|
||||
<tr>
|
||||
{% if can_bulk_delete %}
|
||||
<th scope="col" style="width: 34px;">
|
||||
<input class="form-check-input" type="checkbox" id="inbox_select_all" />
|
||||
</th>
|
||||
{% endif %}
|
||||
<th scope="col">From</th>
|
||||
<th scope="col">Subject</th>
|
||||
<th scope="col">Date / time</th>
|
||||
@ -91,11 +75,6 @@
|
||||
{% if rows %}
|
||||
{% for row in rows %}
|
||||
<tr class="inbox-row" data-message-id="{{ row.id }}" style="cursor: pointer;">
|
||||
{% if can_bulk_delete %}
|
||||
<td onclick="event.stopPropagation();">
|
||||
<input class="form-check-input inbox_row_cb" type="checkbox" value="{{ row.id }}" />
|
||||
</td>
|
||||
{% endif %}
|
||||
<td>{{ row.from_address }}</td>
|
||||
<td>{{ row.subject }}</td>
|
||||
<td>{{ row.received_at }}</td>
|
||||
@ -135,21 +114,21 @@
|
||||
<div class="modal-body">
|
||||
<div class="row">
|
||||
<div class="col-md-3">
|
||||
<dl class="row mb-0 dl-compact">
|
||||
<dl class="row mb-0">
|
||||
<dt class="col-4">From</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_from"></dd>
|
||||
<dd class="col-8" id="msg_from"></dd>
|
||||
|
||||
<dt class="col-4">Backup</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_backup"></dd>
|
||||
<dd class="col-8" id="msg_backup"></dd>
|
||||
|
||||
<dt class="col-4">Type</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_type"></dd>
|
||||
<dd class="col-8" id="msg_type"></dd>
|
||||
|
||||
<dt class="col-4">Job</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_job"></dd>
|
||||
<dd class="col-8" id="msg_job"></dd>
|
||||
|
||||
<dt class="col-4">Overall</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_overall"></dd>
|
||||
<dd class="col-8" id="msg_overall"></dd>
|
||||
|
||||
<dt class="col-4">Customer</dt>
|
||||
<dd class="col-8">
|
||||
@ -161,28 +140,28 @@
|
||||
{% endfor %}
|
||||
</datalist>
|
||||
{% else %}
|
||||
<span id="msg_customer_display" class="ellipsis-field"></span>
|
||||
<span id="msg_customer_display"></span>
|
||||
{% endif %}
|
||||
</dd>
|
||||
|
||||
<dt class="col-4">Received</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_received"></dd>
|
||||
<dd class="col-8" id="msg_received"></dd>
|
||||
|
||||
<dt class="col-4">Parsed</dt>
|
||||
<dd class="col-8 ellipsis-field" id="msg_parsed"></dd>
|
||||
<dd class="col-8" id="msg_parsed"></dd>
|
||||
|
||||
<dt class="col-4">Details</dt>
|
||||
<dd class="col-8" id="msg_overall_message" style="white-space: pre-wrap;"></dd>
|
||||
</dl>
|
||||
</div>
|
||||
|
||||
<div class="col-md-9">
|
||||
<div class="mb-2">
|
||||
<h6 class="mb-1">Details</h6>
|
||||
<div id="msg_overall_message" class="border rounded p-2" style="white-space: pre-wrap; max-height: 20vh; overflow: auto;"></div>
|
||||
</div>
|
||||
<div class="border rounded p-2 p-0" style="overflow:hidden;">
|
||||
<iframe id="msg_body_container_iframe" class="w-100" style="height:55vh; border:0; background:transparent;" sandbox="allow-popups allow-popups-to-escape-sandbox allow-top-navigation-by-user-activation"></iframe>
|
||||
</div>
|
||||
|
||||
<div class="mt-3">
|
||||
<h6>Objects</h6>
|
||||
<div id="msg_objects_container">
|
||||
<!-- Parsed objects will be rendered here -->
|
||||
</div>
|
||||
@ -195,8 +174,7 @@
|
||||
{% if current_user.is_authenticated and active_role in ["admin", "operator"] %}
|
||||
<form id="inboxApproveForm" method="POST" action="" class="me-auto mb-0">
|
||||
<input type="hidden" id="msg_customer_id" name="customer_id" value="" />
|
||||
<button type="submit" class="btn btn-primary" id="inboxApproveBtn">Approve job</button>
|
||||
<button type="button" class="btn btn-outline-primary ms-2 d-none" id="vspcMapCompaniesBtn">Map companies</button>
|
||||
<button type="submit" class="btn btn-primary">Approve job</button>
|
||||
</form>
|
||||
<form id="inboxDeleteForm" method="POST" action="" class="mb-0">
|
||||
<button type="submit" class="btn btn-outline-danger" onclick="return confirm('Delete this message from the Inbox?');">Delete</button>
|
||||
@ -208,198 +186,23 @@
|
||||
</div>
|
||||
</div>
|
||||
|
||||
|
||||
<!-- VSPC company mapping modal (for multi-company summary emails) -->
|
||||
<div class="modal fade" id="vspcCompanyMapModal" tabindex="-1" aria-labelledby="vspcCompanyMapModalLabel" aria-hidden="true">
|
||||
<div class="modal-dialog modal-lg modal-dialog-scrollable">
|
||||
<div class="modal-content">
|
||||
<div class="modal-header">
|
||||
<h5 class="modal-title" id="vspcCompanyMapModalLabel">Map companies to customers</h5>
|
||||
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
|
||||
</div>
|
||||
<form id="vspcCompanyMapForm" method="POST" action="">
|
||||
<div class="modal-body">
|
||||
<p class="mb-2">This message contains multiple companies. Map each company to a customer to approve.</p>
|
||||
|
||||
<datalist id="vspcCustomerList">
|
||||
{% for c in customers %}
|
||||
<option value="{{ c.name }}"></option>
|
||||
{% endfor %}
|
||||
</datalist>
|
||||
|
||||
<div class="table-responsive" style="max-height:55vh; overflow-y:auto;">
|
||||
<table class="table table-sm align-middle">
|
||||
<thead>
|
||||
<tr>
|
||||
<th style="width: 40%;">Company</th>
|
||||
<th style="width: 60%;">Customer</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody id="vspcCompanyMapTbody">
|
||||
<!-- rows injected by JS -->
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
<input type="hidden" id="vspc_company_mappings_json" name="company_mappings_json" value="" />
|
||||
</div>
|
||||
<div class="modal-footer">
|
||||
<button type="button" class="btn btn-secondary" data-bs-dismiss="modal">Cancel</button>
|
||||
<button type="submit" class="btn btn-primary">Approve mapped companies</button>
|
||||
</div>
|
||||
</form>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<script>
|
||||
(function () {
|
||||
var customers = {{ customers|tojson|safe }};
|
||||
|
||||
var table = document.getElementById('inboxTable');
|
||||
var selectAll = document.getElementById('inbox_select_all');
|
||||
var btnDeleteSelected = document.getElementById('btn_inbox_delete_selected');
|
||||
var statusEl = document.getElementById('inbox_status');
|
||||
|
||||
function getSelectedMessageIds() {
|
||||
if (!table) return [];
|
||||
var cbs = table.querySelectorAll('tbody .inbox_row_cb');
|
||||
var ids = [];
|
||||
cbs.forEach(function (cb) {
|
||||
if (cb.checked) ids.push(parseInt(cb.value, 10));
|
||||
});
|
||||
return ids.filter(function (x) { return Number.isFinite(x); });
|
||||
}
|
||||
|
||||
function refreshRowHighlights() {
|
||||
if (!table) return;
|
||||
var cbs = table.querySelectorAll('tbody .inbox_row_cb');
|
||||
cbs.forEach(function (cb) {
|
||||
var tr = cb.closest ? cb.closest('tr') : null;
|
||||
if (!tr) return;
|
||||
if (cb.checked) tr.classList.add('table-active');
|
||||
else tr.classList.remove('table-active');
|
||||
});
|
||||
}
|
||||
|
||||
function refreshSelectAll() {
|
||||
if (!selectAll || !table) return;
|
||||
var cbs = table.querySelectorAll('tbody .inbox_row_cb');
|
||||
var total = cbs.length;
|
||||
var checked = 0;
|
||||
cbs.forEach(function (cb) { if (cb.checked) checked++; });
|
||||
selectAll.indeterminate = checked > 0 && checked < total;
|
||||
selectAll.checked = total > 0 && checked === total;
|
||||
}
|
||||
|
||||
function updateBulkDeleteUi() {
|
||||
var ids = getSelectedMessageIds();
|
||||
refreshRowHighlights();
|
||||
if (btnDeleteSelected) btnDeleteSelected.disabled = ids.length === 0;
|
||||
if (statusEl) statusEl.textContent = ids.length ? (ids.length + ' selected') : '';
|
||||
refreshSelectAll();
|
||||
}
|
||||
|
||||
function postJson(url, payload) {
|
||||
return fetch(url, {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
credentials: 'same-origin',
|
||||
body: JSON.stringify(payload || {})
|
||||
}).then(function (r) {
|
||||
return r.json().then(function (data) { return { ok: r.ok, status: r.status, data: data }; });
|
||||
});
|
||||
}
|
||||
|
||||
if (selectAll && table) {
|
||||
function setAllSelection(checked) {
|
||||
var cbs = table.querySelectorAll('tbody .inbox_row_cb');
|
||||
cbs.forEach(function (cb) { cb.checked = !!checked; });
|
||||
selectAll.indeterminate = false;
|
||||
selectAll.checked = !!checked;
|
||||
setTimeout(function () {
|
||||
selectAll.indeterminate = false;
|
||||
selectAll.checked = !!checked;
|
||||
}, 0);
|
||||
updateBulkDeleteUi();
|
||||
}
|
||||
|
||||
selectAll.addEventListener('click', function (e) {
|
||||
e.stopPropagation();
|
||||
});
|
||||
|
||||
selectAll.addEventListener('change', function () {
|
||||
setAllSelection(selectAll.checked);
|
||||
});
|
||||
}
|
||||
|
||||
if (table) {
|
||||
table.addEventListener('change', function (e) {
|
||||
var t = e.target;
|
||||
if (t && t.classList && t.classList.contains('inbox_row_cb')) {
|
||||
updateBulkDeleteUi();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
if (btnDeleteSelected) {
|
||||
btnDeleteSelected.addEventListener('click', function () {
|
||||
var ids = getSelectedMessageIds();
|
||||
if (!ids.length) return;
|
||||
|
||||
var msg = 'Delete ' + ids.length + ' selected message' + (ids.length === 1 ? '' : 's') + ' from the Inbox?';
|
||||
if (!confirm(msg)) return;
|
||||
|
||||
if (statusEl) statusEl.textContent = 'Deleting...';
|
||||
|
||||
postJson('{{ url_for('main.api_inbox_bulk_delete') }}', { message_ids: ids })
|
||||
.then(function (res) {
|
||||
if (!res.ok || !res.data || res.data.status !== 'ok') {
|
||||
var err = (res.data && (res.data.message || res.data.error)) ? (res.data.message || res.data.error) : 'Request failed.';
|
||||
if (statusEl) statusEl.textContent = err;
|
||||
alert(err);
|
||||
return;
|
||||
}
|
||||
window.location.reload();
|
||||
})
|
||||
.catch(function () {
|
||||
var err = 'Request failed.';
|
||||
if (statusEl) statusEl.textContent = err;
|
||||
alert(err);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
// Initialize UI state
|
||||
updateBulkDeleteUi();
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
function wrapMailHtml(html) {
|
||||
function wrapMailHtml(html) {
|
||||
html = html || "";
|
||||
var trimmed = (typeof html === "string") ? html.trim() : "";
|
||||
var injection = '<meta charset="utf-8"><meta name="color-scheme" content="light"><meta name="supported-color-schemes" content="light"><meta name="viewport" content="width=device-width, initial-scale=1"><base target="_blank"><style>:root{color-scheme:light;}html{color-scheme:light;}body{margin:0;padding:8px;background:#fff;forced-color-adjust:none;-ms-high-contrast-adjust:none;}</style>';
|
||||
|
||||
function injectIntoFullDoc(doc) {
|
||||
var d = doc || "";
|
||||
if (/<head[^>]*>/i.test(d)) {
|
||||
return d.replace(/<head[^>]*>/i, function (m) { return m + injection; });
|
||||
}
|
||||
if (/<html[^>]*>/i.test(d)) {
|
||||
return d.replace(/<html[^>]*>/i, function (m) { return m + "<head>" + injection + "</head>"; });
|
||||
}
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + d + "</body></html>";
|
||||
}
|
||||
|
||||
if (trimmed.toLowerCase().indexOf("<!doctype") === 0 || trimmed.toLowerCase().indexOf("<html") === 0) {
|
||||
return injectIntoFullDoc(trimmed);
|
||||
}
|
||||
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + html + "</body></html>";
|
||||
// Ensure we render the mail HTML with its own CSS, isolated from the site styling.
|
||||
return (
|
||||
"<!doctype html><html><head><meta charset=\"utf-8\">" +
|
||||
"<base target=\"_blank\">" +
|
||||
"</head><body style=\"margin:0; padding:8px;\">" +
|
||||
html +
|
||||
"</body></html>"
|
||||
);
|
||||
}
|
||||
|
||||
function findCustomerIdByName(name) {
|
||||
if (!name) return null;
|
||||
for (var i = 0; i < customers.length; i++) {
|
||||
@ -417,39 +220,10 @@ function findCustomerIdByName(name) {
|
||||
return;
|
||||
}
|
||||
|
||||
function objectSeverityRank(o) {
|
||||
var st = String((o && o.status) || "").trim().toLowerCase();
|
||||
var err = String((o && o.error_message) || "").trim();
|
||||
if (st === "error" || st === "failed" || st === "failure" || err) return 0;
|
||||
if (st === "warning") return 1;
|
||||
return 2;
|
||||
}
|
||||
|
||||
function sortObjects(list) {
|
||||
return (list || []).slice().sort(function (a, b) {
|
||||
var ra = objectSeverityRank(a);
|
||||
var rb = objectSeverityRank(b);
|
||||
if (ra !== rb) return ra - rb;
|
||||
|
||||
var na = String((a && a.name) || "").toLowerCase();
|
||||
var nb = String((b && b.name) || "").toLowerCase();
|
||||
if (na < nb) return -1;
|
||||
if (na > nb) return 1;
|
||||
|
||||
var ta = String((a && a.type) || "").toLowerCase();
|
||||
var tb = String((b && b.type) || "").toLowerCase();
|
||||
if (ta < tb) return -1;
|
||||
if (ta > tb) return 1;
|
||||
return 0;
|
||||
});
|
||||
}
|
||||
|
||||
var sorted = sortObjects(objects);
|
||||
|
||||
var html = "<div class=\"table-responsive\"><table class=\"table table-sm table-bordered mb-0\">";
|
||||
html += "<thead><tr><th>Object</th><th>Type</th><th>Status</th><th>Error</th></tr></thead><tbody>";
|
||||
for (var i = 0; i < sorted.length; i++) {
|
||||
var o = sorted[i] || {};
|
||||
for (var i = 0; i < objects.length; i++) {
|
||||
var o = objects[i] || {};
|
||||
html += "<tr>";
|
||||
html += "<td>" + (o.name || "") + "</td>";
|
||||
html += "<td>" + (o.type || "") + "</td>";
|
||||
@ -504,132 +278,6 @@ function findCustomerIdByName(name) {
|
||||
|
||||
renderObjects(data.objects || []);
|
||||
|
||||
// VSPC multi-company mapping support (Active alarms summary)
|
||||
(function () {
|
||||
var mapBtn = document.getElementById("vspcMapCompaniesBtn");
|
||||
var approveBtn = document.getElementById("inboxApproveBtn");
|
||||
if (!mapBtn) return;
|
||||
|
||||
// reset
|
||||
mapBtn.classList.add("d-none");
|
||||
if (approveBtn) approveBtn.classList.remove("d-none");
|
||||
var ciReset = document.getElementById("msg_customer_input");
|
||||
if (ciReset) {
|
||||
ciReset.removeAttribute("disabled");
|
||||
ciReset.placeholder = "Select customer";
|
||||
}
|
||||
|
||||
var bsw = String(meta.backup_software || "").trim();
|
||||
var btype = String(meta.backup_type || "").trim();
|
||||
var jname = String(meta.job_name || "").trim();
|
||||
|
||||
if (bsw !== "Veeam" || btype !== "Service Provider Console" || jname !== "Active alarms summary") {
|
||||
return;
|
||||
}
|
||||
|
||||
var companies = (data.vspc_companies || meta.vspc_companies || []);
|
||||
var defaults = (data.vspc_company_defaults || {});
|
||||
if (!Array.isArray(companies)) companies = [];
|
||||
|
||||
// Fallback for older stored messages where companies were embedded in object names.
|
||||
if (!companies.length) {
|
||||
var objs = data.objects || [];
|
||||
var seen = {};
|
||||
objs.forEach(function (o) {
|
||||
var name = String((o && o.name) || "");
|
||||
var ix = name.indexOf(" | ");
|
||||
if (ix > 0) {
|
||||
var c = name.substring(0, ix).trim();
|
||||
if (c && !seen[c]) { seen[c] = true; companies.push(c); }
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
if (!companies.length) return;
|
||||
|
||||
// Show mapping button; hide regular approve
|
||||
mapBtn.classList.remove("d-none");
|
||||
if (approveBtn) approveBtn.classList.add("d-none");
|
||||
var ci = document.getElementById("msg_customer_input");
|
||||
if (ci) {
|
||||
ci.value = "";
|
||||
ci.setAttribute("disabled", "disabled");
|
||||
ci.placeholder = "Use \"Map companies\"";
|
||||
}
|
||||
|
||||
mapBtn.onclick = function () {
|
||||
var tbody = document.getElementById("vspcCompanyMapTbody");
|
||||
var form = document.getElementById("vspcCompanyMapForm");
|
||||
if (!tbody || !form) return;
|
||||
|
||||
// set form action
|
||||
form.action = "{{ url_for('main.inbox_message_approve_vspc_companies', message_id=0) }}".replace("0", String(meta.id || id));
|
||||
|
||||
// build rows
|
||||
tbody.innerHTML = "";
|
||||
companies.forEach(function (company) {
|
||||
var tr = document.createElement("tr");
|
||||
|
||||
var tdC = document.createElement("td");
|
||||
tdC.textContent = company;
|
||||
tr.appendChild(tdC);
|
||||
|
||||
var tdS = document.createElement("td");
|
||||
var inp = document.createElement("input");
|
||||
inp.type = "text";
|
||||
inp.className = "form-control form-control-sm";
|
||||
inp.setAttribute("list", "vspcCustomerList");
|
||||
inp.setAttribute("data-company", company);
|
||||
inp.placeholder = "Select customer";
|
||||
|
||||
// Prefill with existing mapping when available.
|
||||
try {
|
||||
var d = defaults && defaults[company];
|
||||
if (d && d.customer_name) {
|
||||
inp.value = String(d.customer_name);
|
||||
}
|
||||
} catch (e) {}
|
||||
tdS.appendChild(inp);
|
||||
tr.appendChild(tdS);
|
||||
|
||||
tbody.appendChild(tr);
|
||||
});
|
||||
|
||||
// clear hidden field
|
||||
var hidden = document.getElementById("vspc_company_mappings_json");
|
||||
if (hidden) hidden.value = "";
|
||||
|
||||
var mapModalEl = document.getElementById("vspcCompanyMapModal");
|
||||
if (mapModalEl && window.bootstrap) {
|
||||
var mm = bootstrap.Modal.getOrCreateInstance(mapModalEl);
|
||||
mm.show();
|
||||
}
|
||||
};
|
||||
|
||||
// Attach submit handler once
|
||||
var mapForm = document.getElementById("vspcCompanyMapForm");
|
||||
if (mapForm && !mapForm.getAttribute("data-bound")) {
|
||||
mapForm.setAttribute("data-bound", "1");
|
||||
mapForm.addEventListener("submit", function (ev) {
|
||||
var rows = document.querySelectorAll("#vspcCompanyMapTbody input[data-company]");
|
||||
var mappings = [];
|
||||
rows.forEach(function (inp) {
|
||||
var company = inp.getAttribute("data-company") || "";
|
||||
var cname = String(inp.value || "").trim();
|
||||
if (!company || !cname) return;
|
||||
|
||||
var cid = findCustomerIdByName(cname);
|
||||
if (!cid) return;
|
||||
mappings.push({ company: company, customer_id: cid });
|
||||
});
|
||||
|
||||
var hidden = document.getElementById("vspc_company_mappings_json");
|
||||
if (hidden) hidden.value = JSON.stringify(mappings);
|
||||
});
|
||||
}
|
||||
})();
|
||||
|
||||
|
||||
var customerName = meta.customer_name || "";
|
||||
var approveForm = document.getElementById("inboxApproveForm");
|
||||
|
||||
|
||||
@ -99,18 +99,18 @@
|
||||
<div class="modal-body">
|
||||
<div class="row">
|
||||
<div class="col-md-3">
|
||||
<dl class="row mb-0 dl-compact">
|
||||
<dl class="row mb-0">
|
||||
<dt class="col-4">From</dt>
|
||||
<dd class="col-8 ellipsis-field" id="dmsg_from"></dd>
|
||||
<dd class="col-8" id="dmsg_from"></dd>
|
||||
|
||||
<dt class="col-4">Received</dt>
|
||||
<dd class="col-8 ellipsis-field" id="dmsg_received"></dd>
|
||||
<dd class="col-8" id="dmsg_received"></dd>
|
||||
|
||||
<dt class="col-4">Deleted by</dt>
|
||||
<dd class="col-8 ellipsis-field" id="dmsg_deleted_by"></dd>
|
||||
<dd class="col-8" id="dmsg_deleted_by"></dd>
|
||||
|
||||
<dt class="col-4">Deleted at</dt>
|
||||
<dd class="col-8 ellipsis-field" id="dmsg_deleted_at"></dd>
|
||||
<dd class="col-8" id="dmsg_deleted_at"></dd>
|
||||
</dl>
|
||||
</div>
|
||||
|
||||
@ -130,30 +130,18 @@
|
||||
|
||||
<script>
|
||||
(function () {
|
||||
function wrapMailHtml(html) {
|
||||
function wrapMailHtml(html) {
|
||||
html = html || "";
|
||||
var trimmed = (typeof html === "string") ? html.trim() : "";
|
||||
var injection = '<meta charset="utf-8"><meta name="color-scheme" content="light"><meta name="supported-color-schemes" content="light"><meta name="viewport" content="width=device-width, initial-scale=1"><base target="_blank"><style>:root{color-scheme:light;}html{color-scheme:light;}body{margin:0;padding:8px;background:#fff;forced-color-adjust:none;-ms-high-contrast-adjust:none;}</style>';
|
||||
|
||||
function injectIntoFullDoc(doc) {
|
||||
var d = doc || "";
|
||||
if (/<head[^>]*>/i.test(d)) {
|
||||
return d.replace(/<head[^>]*>/i, function (m) { return m + injection; });
|
||||
}
|
||||
if (/<html[^>]*>/i.test(d)) {
|
||||
return d.replace(/<html[^>]*>/i, function (m) { return m + "<head>" + injection + "</head>"; });
|
||||
}
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + d + "</body></html>";
|
||||
}
|
||||
|
||||
if (trimmed.toLowerCase().indexOf("<!doctype") === 0 || trimmed.toLowerCase().indexOf("<html") === 0) {
|
||||
return injectIntoFullDoc(trimmed);
|
||||
}
|
||||
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + html + "</body></html>";
|
||||
return (
|
||||
"<!doctype html><html><head><meta charset=\"utf-8\">" +
|
||||
"<base target=\"_blank\">" +
|
||||
"</head><body style=\"margin:0; padding:8px;\">" +
|
||||
html +
|
||||
"</body></html>"
|
||||
);
|
||||
}
|
||||
|
||||
function attachHandlers() {
|
||||
function attachHandlers() {
|
||||
var emlLinks = document.querySelectorAll("a.eml-download");
|
||||
emlLinks.forEach(function (a) {
|
||||
a.addEventListener("click", function (ev) {
|
||||
|
||||
@ -4,18 +4,18 @@
|
||||
|
||||
<div class="card mb-3">
|
||||
<div class="card-body">
|
||||
<dl class="row mb-0 dl-compact">
|
||||
<dl class="row mb-0">
|
||||
<dt class="col-sm-3">Customer</dt>
|
||||
<dd class="col-sm-9 ellipsis-field">{{ job.customer.name if job.customer else "" }}</dd>
|
||||
<dd class="col-sm-9">{{ job.customer.name if job.customer else "" }}</dd>
|
||||
|
||||
<dt class="col-sm-3">Backup</dt>
|
||||
<dd class="col-sm-9 ellipsis-field">{{ job.backup_software }}</dd>
|
||||
<dd class="col-sm-9">{{ job.backup_software }}</dd>
|
||||
|
||||
<dt class="col-sm-3">Type</dt>
|
||||
<dd class="col-sm-9 ellipsis-field">{{ job.backup_type }}</dd>
|
||||
<dd class="col-sm-9">{{ job.backup_type }}</dd>
|
||||
|
||||
<dt class="col-sm-3">Job name</dt>
|
||||
<dd class="col-sm-9 ellipsis-field">{{ job.job_name }}</dd>
|
||||
<dd class="col-sm-9">{{ job.job_name }}</dd>
|
||||
|
||||
<dt class="col-sm-3">Tickets</dt>
|
||||
<dd class="col-sm-9">{{ ticket_open_count }} open / {{ ticket_total_count }} total</dd>
|
||||
@ -48,15 +48,9 @@
|
||||
</div>
|
||||
|
||||
{% if can_manage_jobs %}
|
||||
<div class="d-flex flex-wrap gap-2 mb-3">
|
||||
<form method="post" action="{{ url_for('main.archive_job', job_id=job.id) }}" class="mb-0" onsubmit="return confirm('Archive this job? No new runs are expected and it will be removed from Daily Jobs and Run Checks.');">
|
||||
<button type="submit" class="btn btn-outline-secondary">Archive</button>
|
||||
</form>
|
||||
|
||||
<form method="post" action="{{ url_for('main.job_delete', job_id=job.id) }}" class="mb-0" onsubmit="return confirm('Are you sure you want to delete this job? Related mails will be returned to the Inbox.');">
|
||||
<button type="submit" class="btn btn-outline-danger">Delete job</button>
|
||||
</form>
|
||||
</div>
|
||||
<form method="post" action="{{ url_for('main.job_delete', job_id=job.id) }}" class="mb-3" onsubmit="return confirm('Are you sure you want to delete this job? Related mails will be returned to the Inbox.');">
|
||||
<button type="submit" class="btn btn-outline-danger">Delete job</button>
|
||||
</form>
|
||||
{% endif %}
|
||||
|
||||
<h3 class="mt-4 mb-3">Job history</h3>
|
||||
@ -80,7 +74,7 @@
|
||||
<tbody>
|
||||
{% if history_rows %}
|
||||
{% for r in history_rows %}
|
||||
<tr{% if r.mail_message_id %} class="jobrun-row" data-message-id="{{ r.mail_message_id }}" data-run-id="{{ r.id }}" data-ticket-codes="{{ (r.ticket_codes or [])|tojson|forceescape }}" data-remark-items="{{ (r.remark_items or [])|tojson|forceescape }}" style="cursor: pointer;"{% endif %}>
|
||||
<tr{% if r.mail_message_id %} class="jobrun-row" data-message-id="{{ r.mail_message_id }}" data-ticket-codes="{{ (r.ticket_codes or [])|tojson|forceescape }}" data-remark-items="{{ (r.remark_items or [])|tojson|forceescape }}" style="cursor: pointer;"{% endif %}>
|
||||
<td>{{ r.run_day }}</td>
|
||||
<td>{{ r.run_at }}</td>
|
||||
{% set _s = (r.status or "")|lower %}
|
||||
@ -168,73 +162,49 @@
|
||||
<div class="modal-body">
|
||||
<div class="row">
|
||||
<div class="col-md-3">
|
||||
<dl class="row mb-0 dl-compact">
|
||||
<dl class="row mb-0">
|
||||
<dt class="col-4">From</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_from"></dd>
|
||||
<dd class="col-8" id="run_msg_from"></dd>
|
||||
|
||||
<dt class="col-4">Backup</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_backup"></dd>
|
||||
<dd class="col-8" id="run_msg_backup"></dd>
|
||||
|
||||
<dt class="col-4">Type</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_type"></dd>
|
||||
<dd class="col-8" id="run_msg_type"></dd>
|
||||
|
||||
<dt class="col-4">Ticket</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_ticket"></dd>
|
||||
<dd class="col-8" id="run_msg_ticket"></dd>
|
||||
|
||||
<dt class="col-4">Remark</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_remark"></dd>
|
||||
|
||||
<dt class="col-12 mt-2">Tickets & remarks</dt>
|
||||
<dd class="col-12">
|
||||
<div id="jhm_alerts" class="small"></div>
|
||||
|
||||
{% if can_manage_jobs %}
|
||||
<div class="border rounded p-2 mt-2">
|
||||
<div class="fw-semibold">New ticket</div>
|
||||
<div class="d-flex gap-2 mt-1">
|
||||
<input class="form-control form-control-sm" id="jhm_ticket_code" type="text" placeholder="Ticket number (e.g., T20260106.0001)" />
|
||||
<button type="button" class="btn btn-sm btn-outline-primary" id="jhm_ticket_save">Add</button>
|
||||
</div>
|
||||
<div class="mt-1 small text-muted" id="jhm_ticket_status"></div>
|
||||
|
||||
<div class="fw-semibold mt-2">New remark</div>
|
||||
<textarea class="form-control form-control-sm" id="jhm_remark_body" rows="2" placeholder="Remark"></textarea>
|
||||
<div class="d-flex justify-content-end mt-1">
|
||||
<button type="button" class="btn btn-sm btn-outline-primary" id="jhm_remark_save">Add</button>
|
||||
</div>
|
||||
<div class="mt-1 small text-muted" id="jhm_remark_status"></div>
|
||||
</div>
|
||||
{% endif %}
|
||||
</dd>
|
||||
<dd class="col-8" id="run_msg_remark"></dd>
|
||||
|
||||
<dt class="col-4">Job</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_job"></dd>
|
||||
<dd class="col-8" id="run_msg_job"></dd>
|
||||
|
||||
<dt class="col-4">Overall</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_overall"></dd>
|
||||
<dd class="col-8" id="run_msg_overall"></dd>
|
||||
|
||||
<dt class="col-4">Message</dt>
|
||||
<dd class="col-8" id="run_msg_overall_message" style="white-space: pre-wrap;"></dd>
|
||||
|
||||
<dt class="col-4">Customer</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_customer"></dd>
|
||||
<dd class="col-8" id="run_msg_customer"></dd>
|
||||
|
||||
<dt class="col-4">Received</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_received"></dd>
|
||||
<dd class="col-8" id="run_msg_received"></dd>
|
||||
|
||||
<dt class="col-4">Parsed</dt>
|
||||
<dd class="col-8 ellipsis-field" id="run_msg_parsed"></dd>
|
||||
<dd class="col-8" id="run_msg_parsed"></dd>
|
||||
</dl>
|
||||
|
||||
</div>
|
||||
|
||||
<div class="col-md-9">
|
||||
<div class="mb-2">
|
||||
<h6 class="mb-1">Details</h6>
|
||||
<div id="run_msg_overall_message" class="border rounded p-2" style="white-space: pre-wrap; max-height: 20vh; overflow: auto;"></div>
|
||||
</div>
|
||||
<div class="border rounded p-2 p-0" style="overflow:hidden;">
|
||||
<iframe id="run_msg_body_container_iframe" class="w-100" style="height:55vh; border:0; background:transparent;" sandbox="allow-popups allow-popups-to-escape-sandbox allow-top-navigation-by-user-activation"></iframe>
|
||||
</div>
|
||||
|
||||
<div class="mt-3">
|
||||
<h6>Objects</h6>
|
||||
<div id="run_msg_objects_container">
|
||||
<!-- Parsed objects will be rendered here -->
|
||||
</div>
|
||||
@ -285,220 +255,19 @@
|
||||
}
|
||||
|
||||
(function () {
|
||||
var currentRunId = null;
|
||||
|
||||
|
||||
function apiJson(url, opts) {
|
||||
opts = opts || {};
|
||||
opts.headers = opts.headers || {};
|
||||
opts.headers['Content-Type'] = 'application/json';
|
||||
return fetch(url, opts).then(function (r) {
|
||||
return r.json().then(function (j) {
|
||||
if (!r.ok || !j || j.status !== 'ok') {
|
||||
var msg = (j && j.message) ? j.message : ('Request failed (' + r.status + ')');
|
||||
throw new Error(msg);
|
||||
}
|
||||
return j;
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
function renderAlerts(payload) {
|
||||
var box = document.getElementById('jhm_alerts');
|
||||
if (!box) return;
|
||||
var tickets = (payload && payload.tickets) || [];
|
||||
var remarks = (payload && payload.remarks) || [];
|
||||
|
||||
if (!tickets.length && !remarks.length) {
|
||||
box.innerHTML = '<span class="text-muted">No tickets or remarks linked to this run.</span>';
|
||||
return;
|
||||
}
|
||||
|
||||
var html = '';
|
||||
|
||||
if (tickets.length) {
|
||||
html += '<div class="mb-2"><strong>Tickets</strong><div class="mt-1">';
|
||||
tickets.forEach(function (t) {
|
||||
var status = t.resolved_at ? 'Resolved' : 'Active';
|
||||
html += '<div class="mb-2 border rounded p-2" data-alert-type="ticket" data-id="' + t.id + '">' +
|
||||
'<div class="d-flex align-items-start justify-content-between gap-2">' +
|
||||
'<div class="flex-grow-1 min-w-0">' +
|
||||
'<div class="text-truncate">' +
|
||||
'<span class="me-1" title="Ticket">🎫</span>' +
|
||||
'<span class="fw-semibold">' + escapeHtml(t.ticket_code || '') + '</span>' +
|
||||
'<span class="ms-2 badge ' + (t.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status + '</span>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'<div class="d-flex gap-1 flex-shrink-0">' +
|
||||
'{% if can_manage_jobs %}' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-success" data-action="resolve-ticket" data-id="' + t.id + '" ' + (t.resolved_at ? 'disabled' : '') + '>Resolve</button>' +
|
||||
'{% endif %}' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>';
|
||||
});
|
||||
html += '</div></div>';
|
||||
}
|
||||
|
||||
if (remarks.length) {
|
||||
html += '<div class="mb-2"><strong>Remarks</strong><div class="mt-1">';
|
||||
remarks.forEach(function (r) {
|
||||
var status = r.resolved_at ? 'Resolved' : 'Active';
|
||||
html += '<div class="mb-2 border rounded p-2" data-alert-type="remark" data-id="' + r.id + '">' +
|
||||
'<div class="d-flex align-items-start justify-content-between gap-2">' +
|
||||
'<div class="flex-grow-1 min-w-0">' +
|
||||
'<div class="text-truncate">' +
|
||||
'<span class="me-1" title="Remark">💬</span>' +
|
||||
'<span class="fw-semibold">Remark</span>' +
|
||||
'<span class="ms-2 badge ' + (r.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status + '</span>' +
|
||||
'</div>' +
|
||||
(r.body ? ('<div class="small text-muted mt-1">' + escapeHtml(r.body) + '</div>') : '') +
|
||||
'</div>' +
|
||||
'<div class="d-flex gap-1 flex-shrink-0">' +
|
||||
'{% if can_manage_jobs %}' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-success" data-action="resolve-remark" data-id="' + r.id + '" ' + (r.resolved_at ? 'disabled' : '') + '>Resolve</button>' +
|
||||
'{% endif %}' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>';
|
||||
});
|
||||
html += '</div></div>';
|
||||
}
|
||||
|
||||
box.innerHTML = html;
|
||||
|
||||
Array.prototype.forEach.call(box.querySelectorAll('button[data-action]'), function (btn) {
|
||||
btn.addEventListener('click', function (ev) {
|
||||
ev.preventDefault();
|
||||
var action = btn.getAttribute('data-action');
|
||||
var id = btn.getAttribute('data-id');
|
||||
if (!action || !id) return;
|
||||
if (action === 'resolve-ticket') {
|
||||
if (!confirm('Mark ticket as resolved?')) return;
|
||||
apiJson('/api/tickets/' + encodeURIComponent(id) + '/resolve', {method: 'POST', body: '{}'})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) { alert(e.message || 'Failed.'); });
|
||||
} else if (action === 'resolve-remark') {
|
||||
if (!confirm('Mark remark as resolved?')) return;
|
||||
apiJson('/api/remarks/' + encodeURIComponent(id) + '/resolve', {method: 'POST', body: '{}'})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) { alert(e.message || 'Failed.'); });
|
||||
}
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
function loadAlerts(runId) {
|
||||
if (!runId) {
|
||||
renderAlerts({tickets: [], remarks: []});
|
||||
return;
|
||||
}
|
||||
fetch('/api/job-runs/' + encodeURIComponent(runId) + '/alerts')
|
||||
.then(function (r) { return r.json(); })
|
||||
.then(function (j) {
|
||||
if (!j || j.status !== 'ok') throw new Error((j && j.message) || 'Failed');
|
||||
renderAlerts(j);
|
||||
})
|
||||
.catch(function () {
|
||||
renderAlerts({tickets: [], remarks: []});
|
||||
});
|
||||
}
|
||||
|
||||
function bindInlineCreateForms() {
|
||||
var btnTicket = document.getElementById('jhm_ticket_save');
|
||||
var btnRemark = document.getElementById('jhm_remark_save');
|
||||
var tCode = document.getElementById('jhm_ticket_code');
|
||||
var tStatus = document.getElementById('jhm_ticket_status');
|
||||
var rBody = document.getElementById('jhm_remark_body');
|
||||
var rStatus = document.getElementById('jhm_remark_status');
|
||||
|
||||
function clearStatus() {
|
||||
if (tStatus) tStatus.textContent = '';
|
||||
if (rStatus) rStatus.textContent = '';
|
||||
}
|
||||
|
||||
if (btnTicket) {
|
||||
btnTicket.addEventListener('click', function () {
|
||||
if (!currentRunId) { alert('Select a run first.'); return; }
|
||||
clearStatus();
|
||||
var ticket_code = tCode ? (tCode.value || '').trim().toUpperCase() : '';
|
||||
if (!ticket_code) {
|
||||
if (tStatus) tStatus.textContent = 'Ticket number is required.';
|
||||
else alert('Ticket number is required.');
|
||||
return;
|
||||
}
|
||||
if (!/^T\d{8}\.\d{4}$/.test(ticket_code)) {
|
||||
if (tStatus) tStatus.textContent = 'Invalid ticket number format. Expected TYYYYMMDD.####.';
|
||||
else alert('Invalid ticket number format. Expected TYYYYMMDD.####.');
|
||||
return;
|
||||
}
|
||||
if (tStatus) tStatus.textContent = 'Saving...';
|
||||
apiJson('/api/tickets', {
|
||||
method: 'POST',
|
||||
body: JSON.stringify({job_run_id: currentRunId, ticket_code: ticket_code})
|
||||
})
|
||||
.then(function () {
|
||||
if (tCode) tCode.value = '';
|
||||
if (tStatus) tStatus.textContent = '';
|
||||
loadAlerts(currentRunId);
|
||||
})
|
||||
.catch(function (e) {
|
||||
if (tStatus) tStatus.textContent = e.message || 'Failed.';
|
||||
else alert(e.message || 'Failed.');
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
if (btnRemark) {
|
||||
btnRemark.addEventListener('click', function () {
|
||||
if (!currentRunId) { alert('Select a run first.'); return; }
|
||||
clearStatus();
|
||||
var body = rBody ? rBody.value : '';
|
||||
if (!body || !body.trim()) {
|
||||
if (rStatus) rStatus.textContent = 'Body is required.';
|
||||
else alert('Body is required.');
|
||||
return;
|
||||
}
|
||||
if (rStatus) rStatus.textContent = 'Saving...';
|
||||
apiJson('/api/remarks', {
|
||||
method: 'POST',
|
||||
body: JSON.stringify({job_run_id: currentRunId, body: body})
|
||||
})
|
||||
.then(function () {
|
||||
if (rBody) rBody.value = '';
|
||||
if (rStatus) rStatus.textContent = '';
|
||||
loadAlerts(currentRunId);
|
||||
})
|
||||
.catch(function (e) {
|
||||
if (rStatus) rStatus.textContent = e.message || 'Failed.';
|
||||
else alert(e.message || 'Failed.');
|
||||
});
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
function wrapMailHtml(html) {
|
||||
function wrapMailHtml(html) {
|
||||
html = html || "";
|
||||
var trimmed = (typeof html === "string") ? html.trim() : "";
|
||||
var injection = '<meta charset="utf-8"><meta name="color-scheme" content="light"><meta name="supported-color-schemes" content="light"><meta name="viewport" content="width=device-width, initial-scale=1"><base target="_blank"><style>:root{color-scheme:light;}html{color-scheme:light;}body{margin:0;padding:8px;background:#fff;forced-color-adjust:none;-ms-high-contrast-adjust:none;}</style>';
|
||||
|
||||
function injectIntoFullDoc(doc) {
|
||||
var d = doc || "";
|
||||
if (/<head[^>]*>/i.test(d)) {
|
||||
return d.replace(/<head[^>]*>/i, function (m) { return m + injection; });
|
||||
}
|
||||
if (/<html[^>]*>/i.test(d)) {
|
||||
return d.replace(/<html[^>]*>/i, function (m) { return m + "<head>" + injection + "</head>"; });
|
||||
}
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + d + "</body></html>";
|
||||
}
|
||||
|
||||
if (trimmed.toLowerCase().indexOf("<!doctype") === 0 || trimmed.toLowerCase().indexOf("<html") === 0) {
|
||||
return injectIntoFullDoc(trimmed);
|
||||
}
|
||||
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + html + "</body></html>";
|
||||
// Ensure we render the mail HTML with its own CSS, isolated from the site styling.
|
||||
return (
|
||||
"<!doctype html><html><head><meta charset=\"utf-8\">" +
|
||||
"<base target=\"_blank\">" +
|
||||
"</head><body style=\"margin:0; padding:8px;\">" +
|
||||
html +
|
||||
"</body></html>"
|
||||
);
|
||||
}
|
||||
|
||||
function renderObjects(objects) {
|
||||
var container = document.getElementById("run_msg_objects_container");
|
||||
if (!container) return;
|
||||
@ -508,47 +277,16 @@ function renderObjects(objects) {
|
||||
return;
|
||||
}
|
||||
|
||||
function objectSeverityRank(o) {
|
||||
var st = String((o && o.status) || "").trim().toLowerCase();
|
||||
var err = String((o && o.error_message) || "").trim();
|
||||
if (st === "error" || st === "failed" || st === "failure" || err) return 0;
|
||||
if (st === "warning") return 1;
|
||||
return 2;
|
||||
}
|
||||
|
||||
// Sort: errors first, then warnings, then the rest; within each group sort alphabetically.
|
||||
var sorted = (objects || []).slice().sort(function (a, b) {
|
||||
var ra = objectSeverityRank(a);
|
||||
var rb = objectSeverityRank(b);
|
||||
if (ra !== rb) return ra - rb;
|
||||
|
||||
var an = String((a && a.name) || "").toLowerCase();
|
||||
var bn = String((b && b.name) || "").toLowerCase();
|
||||
if (an < bn) return -1;
|
||||
if (an > bn) return 1;
|
||||
|
||||
var at = String((a && a.type) || "").toLowerCase();
|
||||
var bt = String((b && b.type) || "").toLowerCase();
|
||||
if (at < bt) return -1;
|
||||
if (at > bt) return 1;
|
||||
return 0;
|
||||
});
|
||||
|
||||
var html = "<div class=\"table-responsive\"><table class=\"table table-sm table-bordered mb-0\">";
|
||||
html += "<thead><tr><th>Object</th><th>Type</th><th>Status</th><th>Error</th></tr></thead><tbody>";
|
||||
for (var i = 0; i < sorted.length; i++) {
|
||||
var o = sorted[i] || {};
|
||||
for (var i = 0; i < objects.length; i++) {
|
||||
var o = objects[i] || {};
|
||||
html += "<tr>";
|
||||
html += "<td>" + escapeHtml(o.name || "") + "</td>";
|
||||
html += "<td>" + escapeHtml(o.type || "") + "</td>";
|
||||
|
||||
html += "<td>" + (o.name || "") + "</td>";
|
||||
html += "<td>" + (o.type || "") + "</td>";
|
||||
var d = statusDotClass(o.status);
|
||||
html += "<td class=\"status-text " + statusClass(o.status) + "\">" +
|
||||
(d ? ("<span class=\"status-dot " + d + " me-2\" aria-hidden=\"true\"></span>") : "") +
|
||||
escapeHtml(o.status || "") +
|
||||
"</td>";
|
||||
|
||||
html += "<td>" + escapeHtml(o.error_message || "") + "</td>";
|
||||
html += "<td class=\"status-text " + statusClass(o.status) + "\">" + (d ? ('<span class=\\\"status-dot ' + d + ' me-2\\\" aria-hidden=\\\"true\\\"></span>') : '') + escapeHtml(o.status || "") + "</td>";
|
||||
html += "<td>" + (o.error_message || "") + "</td>";
|
||||
html += "</tr>";
|
||||
}
|
||||
html += "</tbody></table></div>";
|
||||
@ -561,16 +299,10 @@ function renderObjects(objects) {
|
||||
if (!modalEl) return;
|
||||
var modal = new bootstrap.Modal(modalEl);
|
||||
|
||||
{% if can_manage_jobs %}
|
||||
bindInlineCreateForms();
|
||||
{% endif %}
|
||||
|
||||
rows.forEach(function (row) {
|
||||
row.addEventListener("click", function () {
|
||||
var messageId = row.getAttribute("data-message-id");
|
||||
var runId = row.getAttribute("data-run-id");
|
||||
if (!messageId) return;
|
||||
currentRunId = runId ? parseInt(runId, 10) : null;
|
||||
|
||||
fetch("{{ url_for('main.inbox_message_detail', message_id=0) }}".replace("0", messageId))
|
||||
.then(function (resp) {
|
||||
@ -638,8 +370,6 @@ function renderObjects(objects) {
|
||||
if (bodyFrame) bodyFrame.srcdoc = wrapMailHtml(data.body_html || "");
|
||||
|
||||
renderObjects(data.objects || []);
|
||||
|
||||
loadAlerts(currentRunId);
|
||||
modal.show();
|
||||
})
|
||||
.catch(function (err) {
|
||||
@ -653,4 +383,4 @@ function renderObjects(objects) {
|
||||
})();
|
||||
</script>
|
||||
|
||||
{% endblock %}
|
||||
{% endblock %}
|
||||
@ -15,7 +15,7 @@
|
||||
<tbody>
|
||||
{% if jobs %}
|
||||
{% for j in jobs %}
|
||||
<tr class="job-row" data-href="{{ url_for('main.job_detail', job_id=j.id) }}" style="cursor: pointer;">
|
||||
<tr style="cursor: pointer;" onclick="window.location='{{ url_for('main.job_detail', job_id=j.id) }}'">
|
||||
<td>{{ j.customer_name }}</td>
|
||||
<td>{{ j.backup_software }}</td>
|
||||
<td>{{ j.backup_type }}</td>
|
||||
@ -32,24 +32,4 @@
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
<script>
|
||||
(function () {
|
||||
function onRowClick(e) {
|
||||
// Don't navigate when clicking interactive elements inside the row.
|
||||
if (e.target.closest('a, button, input, select, textarea, label, form')) {
|
||||
return;
|
||||
}
|
||||
|
||||
var href = this.getAttribute('data-href');
|
||||
if (href) {
|
||||
window.location.href = href;
|
||||
}
|
||||
}
|
||||
|
||||
document.querySelectorAll('tr.job-row[data-href]').forEach(function (row) {
|
||||
row.addEventListener('click', onRowClick);
|
||||
});
|
||||
})();
|
||||
</script>
|
||||
{% endblock %}
|
||||
|
||||
@ -62,16 +62,7 @@
|
||||
</select>
|
||||
</div>
|
||||
<div class="col-md-3">
|
||||
<label for="ov_match_error_mode" class="form-label">Error match type</label>
|
||||
<select class="form-select" id="ov_match_error_mode" name="match_error_mode">
|
||||
<option value="contains">Contains</option>
|
||||
<option value="exact">Exact</option>
|
||||
<option value="starts_with">Starts with</option>
|
||||
<option value="ends_with">Ends with</option>
|
||||
</select>
|
||||
</div>
|
||||
<div class="col-md-3">
|
||||
<label for="ov_match_error_contains" class="form-label">Error text</label>
|
||||
<label for="ov_match_error_contains" class="form-label">Error contains</label>
|
||||
<input type="text" class="form-control" id="ov_match_error_contains" name="match_error_contains" placeholder="Text to match in error message">
|
||||
</div>
|
||||
<div class="col-md-3">
|
||||
@ -151,7 +142,6 @@
|
||||
data-ov-object-name="{{ ov.object_name or '' }}"
|
||||
data-ov-match-status="{{ ov.match_status or '' }}"
|
||||
data-ov-match-error-contains="{{ ov.match_error_contains or '' }}"
|
||||
data-ov-match-error-mode="{{ ov.match_error_mode or 'contains' }}"
|
||||
data-ov-treat-as-success="{{ 1 if ov.treat_as_success else 0 }}"
|
||||
data-ov-comment="{{ ov.comment or '' }}"
|
||||
data-ov-start-at="{{ ov.start_at_raw or '' }}"
|
||||
@ -200,7 +190,6 @@
|
||||
const jobField = document.getElementById('ov_job_id');
|
||||
const objectNameField = document.getElementById('ov_object_name');
|
||||
const matchStatusField = document.getElementById('ov_match_status');
|
||||
const matchErrorModeField = document.getElementById('ov_match_error_mode');
|
||||
const matchErrorContainsField = document.getElementById('ov_match_error_contains');
|
||||
const treatAsSuccessField = document.getElementById('ov_treat_success');
|
||||
const commentField = document.getElementById('ov_comment');
|
||||
@ -239,7 +228,6 @@
|
||||
setValue(jobField, btn.dataset.ovJobId || '');
|
||||
setValue(objectNameField, btn.dataset.ovObjectName || '');
|
||||
setValue(matchStatusField, btn.dataset.ovMatchStatus || '');
|
||||
setValue(matchErrorModeField, btn.dataset.ovMatchErrorMode || 'contains');
|
||||
setValue(matchErrorContainsField, btn.dataset.ovMatchErrorContains || '');
|
||||
if (treatAsSuccessField) treatAsSuccessField.checked = (btn.dataset.ovTreatAsSuccess === '1');
|
||||
setValue(commentField, btn.dataset.ovComment || '');
|
||||
|
||||
@ -16,19 +16,19 @@
|
||||
{% endif %}
|
||||
</div>
|
||||
|
||||
<div class="row g-3"> <div class="col-12">
|
||||
<form method="post" class="row g-3"> <div class="col-12">
|
||||
<label class="form-label">Body</label>
|
||||
<div class="form-control-plaintext border rounded p-2" style="min-height: 7rem; white-space: pre-wrap;">{{ remark.body or '' }}</div>
|
||||
<textarea class="form-control" name="body" rows="6">{{ remark.body or '' }}</textarea>
|
||||
</div>
|
||||
{% if active_role in ['admin','operator'] %}
|
||||
<div class="col-12">
|
||||
|
||||
<button class="btn btn-primary" type="submit">Save</button>
|
||||
{% if not remark.resolved_at %}
|
||||
<button class="btn btn-outline-success" type="button" onclick="if(confirm('Mark remark as resolved?')){fetch('{{ url_for('main.api_remark_resolve', remark_id=remark.id) }}',{method:'POST'}).then(()=>location.reload());}">Resolve</button>
|
||||
{% endif %}
|
||||
</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
</form>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
|
||||
@ -144,22 +144,9 @@
|
||||
overflow: auto;
|
||||
}
|
||||
|
||||
#runChecksModal #rcm_body_iframe {
|
||||
flex: 1 1 auto;
|
||||
min-height: 0;
|
||||
height: auto;
|
||||
}
|
||||
#runChecksModal .rcm-mail-panel {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
flex: 1 1 auto;
|
||||
min-height: 0;
|
||||
}
|
||||
#runChecksModal .rcm-objects-scroll {
|
||||
max-height: 25vh;
|
||||
overflow: auto;
|
||||
margin-top: 0.5rem;
|
||||
}
|
||||
#runChecksModal #rcm_body_iframe { height: 100%; }
|
||||
#runChecksModal .rcm-mail-panel { flex: 1 1 auto; min-height: 0; }
|
||||
#runChecksModal .rcm-objects-scroll { max-height: 25vh; overflow: auto; }
|
||||
</style>
|
||||
|
||||
<div class="modal fade" id="runChecksModal" tabindex="-1" aria-labelledby="runChecksModalLabel" aria-hidden="true">
|
||||
@ -190,21 +177,18 @@
|
||||
<div id="rcm_runs_list" class="list-group"></div>
|
||||
</div>
|
||||
<div class="col-md-9 rcm-detail-col">
|
||||
<dl class="row mb-3 dl-compact">
|
||||
<dl class="row mb-3">
|
||||
<dt class="col-3">From</dt>
|
||||
<dd class="col-9 ellipsis-field" id="rcm_from"></dd>
|
||||
<dd class="col-9" id="rcm_from"></dd>
|
||||
|
||||
<dt class="col-3">Subject</dt>
|
||||
<dd class="col-9 ellipsis-field" id="rcm_subject"></dd>
|
||||
<dd class="col-9" id="rcm_subject"></dd>
|
||||
|
||||
<dt class="col-3">Received</dt>
|
||||
<dd class="col-9 ellipsis-field" id="rcm_received"></dd>
|
||||
<dd class="col-9" id="rcm_received"></dd>
|
||||
|
||||
<dt class="col-3">Indicator</dt>
|
||||
<dd class="col-9 ellipsis-field" id="rcm_status"></dd>
|
||||
|
||||
<dt class="col-3">Overall remark</dt>
|
||||
<dd class="col-9" id="rcm_overall_message" style="white-space: pre-wrap;"></dd>
|
||||
<dd class="col-9" id="rcm_status"></dd>
|
||||
|
||||
<dt class="col-3">Remark</dt>
|
||||
<dd class="col-9" id="rcm_remark" style="white-space: pre-wrap;"></dd>
|
||||
@ -221,9 +205,9 @@
|
||||
<button type="button" class="btn btn-sm btn-outline-primary" id="rcm_ticket_save">Add</button>
|
||||
</div>
|
||||
<div class="mt-2">
|
||||
<input class="form-control form-control-sm" id="rcm_ticket_code" type="text" placeholder="Ticket number (e.g., T20260106.0001)" />
|
||||
</div>
|
||||
<div class="mt-2 small text-muted" id="rcm_ticket_status"></div>
|
||||
<textarea class="form-control form-control-sm" id="rcm_ticket_description" rows="2" placeholder="Description (optional)"></textarea>
|
||||
</div>
|
||||
<div class="mt-2 small text-muted" id="rcm_ticket_status"></div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="col-12 col-lg-6">
|
||||
@ -255,6 +239,7 @@
|
||||
</div>
|
||||
|
||||
<div>
|
||||
<h6>Objects</h6>
|
||||
<div class="table-responsive rcm-objects-scroll">
|
||||
<table class="table table-sm table-bordered" id="rcm_objects_table">
|
||||
<thead class="table-light" style="position: sticky; top: 0; z-index: 1;">
|
||||
@ -300,7 +285,6 @@
|
||||
var currentPayload = null;
|
||||
|
||||
var btnMarkAllReviewed = document.getElementById('rcm_mark_all_reviewed');
|
||||
var btnMarkSuccessOverride = document.getElementById('rcm_mark_success_override');
|
||||
|
||||
// Shift-click range selection for checkbox rows
|
||||
var lastCheckedCb = null;
|
||||
@ -338,57 +322,18 @@ function statusClass(status) {
|
||||
return "";
|
||||
}
|
||||
|
||||
function objectSeverityRank(o) {
|
||||
var st = String((o && o.status) || '').trim().toLowerCase();
|
||||
var err = String((o && o.error_message) || '').trim();
|
||||
if (st === 'error' || st === 'failed' || st === 'failure' || err) return 0;
|
||||
if (st === 'warning') return 1;
|
||||
return 2;
|
||||
}
|
||||
|
||||
function sortObjects(objects) {
|
||||
return (objects || []).slice().sort(function (a, b) {
|
||||
var ra = objectSeverityRank(a);
|
||||
var rb = objectSeverityRank(b);
|
||||
if (ra !== rb) return ra - rb;
|
||||
|
||||
var na = String((a && a.name) || '').toLowerCase();
|
||||
var nb = String((b && b.name) || '').toLowerCase();
|
||||
if (na < nb) return -1;
|
||||
if (na > nb) return 1;
|
||||
|
||||
var ta = String((a && a.type) || '').toLowerCase();
|
||||
var tb = String((b && b.type) || '').toLowerCase();
|
||||
if (ta < tb) return -1;
|
||||
if (ta > tb) return 1;
|
||||
return 0;
|
||||
});
|
||||
}
|
||||
|
||||
function wrapMailHtml(html) {
|
||||
function wrapMailHtml(html) {
|
||||
html = html || "";
|
||||
var trimmed = (typeof html === "string") ? html.trim() : "";
|
||||
var injection = '<meta charset="utf-8"><meta name="color-scheme" content="light"><meta name="supported-color-schemes" content="light"><meta name="viewport" content="width=device-width, initial-scale=1"><base target="_blank"><style>:root{color-scheme:light;}html{color-scheme:light;}body{margin:0;padding:8px;background:#fff;forced-color-adjust:none;-ms-high-contrast-adjust:none;}</style>';
|
||||
|
||||
function injectIntoFullDoc(doc) {
|
||||
var d = doc || "";
|
||||
if (/<head[^>]*>/i.test(d)) {
|
||||
return d.replace(/<head[^>]*>/i, function (m) { return m + injection; });
|
||||
}
|
||||
if (/<html[^>]*>/i.test(d)) {
|
||||
return d.replace(/<html[^>]*>/i, function (m) { return m + "<head>" + injection + "</head>"; });
|
||||
}
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + d + "</body></html>";
|
||||
}
|
||||
|
||||
if (trimmed.toLowerCase().indexOf("<!doctype") === 0 || trimmed.toLowerCase().indexOf("<html") === 0) {
|
||||
return injectIntoFullDoc(trimmed);
|
||||
}
|
||||
|
||||
return "<!doctype html><html><head>" + injection + "</head><body>" + html + "</body></html>";
|
||||
return (
|
||||
"<!doctype html><html><head><meta charset=\"utf-8\">" +
|
||||
"<base target=\"_blank\">" +
|
||||
"</head><body style=\"margin:0; padding:8px;\">" +
|
||||
html +
|
||||
"</body></html>"
|
||||
);
|
||||
}
|
||||
|
||||
function escapeHtml(s) {
|
||||
function escapeHtml(s) {
|
||||
return (s || "").toString()
|
||||
.replace(/&/g, "&")
|
||||
.replace(/</g, "<")
|
||||
@ -700,25 +645,6 @@ table.addEventListener('change', function (e) {
|
||||
});
|
||||
}
|
||||
|
||||
if (btnMarkSuccessOverride) {
|
||||
btnMarkSuccessOverride.addEventListener('click', function () {
|
||||
if (!currentRunId) return;
|
||||
btnMarkSuccessOverride.disabled = true;
|
||||
apiJson('/api/run-checks/mark-success-override', {
|
||||
method: 'POST',
|
||||
body: JSON.stringify({ run_id: currentRunId })
|
||||
})
|
||||
.then(function (j) {
|
||||
if (!j || j.status !== 'ok') throw new Error((j && j.message) || 'Failed');
|
||||
window.location.reload();
|
||||
})
|
||||
.catch(function (e) {
|
||||
alert((e && e.message) ? e.message : 'Failed to mark as success (override).');
|
||||
btnMarkSuccessOverride.disabled = false;
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
function renderAlerts(payload) {
|
||||
var box = document.getElementById('rcm_alerts');
|
||||
if (!box) return;
|
||||
@ -735,21 +661,33 @@ table.addEventListener('change', function (e) {
|
||||
html += '<div class="mb-2"><strong>Tickets</strong><div class="mt-1">';
|
||||
tickets.forEach(function (t) {
|
||||
var status = t.resolved_at ? 'Resolved' : 'Active';
|
||||
var ticketCode = (t.ticket_code || '').toString();
|
||||
html += '<div class="mb-2 border rounded p-2" data-alert-type="ticket" data-id="' + t.id + '">' +
|
||||
'<div class="d-flex align-items-start justify-content-between gap-2">' +
|
||||
'<div class="flex-grow-1 min-w-0">' +
|
||||
'<div class="text-truncate">' +
|
||||
'<span class="me-1" title="Ticket">🎫</span>' +
|
||||
'<span class="fw-semibold">' + escapeHtml(ticketCode) + '</span>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary ms-2 py-0 px-1" title="Copy ticket number" data-action="copy-ticket" data-code="' + escapeHtml(ticketCode) + '">⧉</button>' +
|
||||
'<span class="fw-semibold">' + escapeHtml(t.ticket_code || '') + '</span>' +
|
||||
'<span class="ms-2 badge ' + (t.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status + '</span>' +
|
||||
'</div>' +
|
||||
(t.description ? ('<div class="small text-muted mt-1">' + escapeHtml(t.description) + '</div>') : '') +
|
||||
'</div>' +
|
||||
'<div class="d-flex gap-1 flex-shrink-0">' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="toggle-edit-ticket" data-id="' + t.id + '" ' + (t.resolved_at ? 'disabled' : '') + '>Edit</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-success" data-action="resolve-ticket" data-id="' + t.id + '" ' + (t.resolved_at ? 'disabled' : '') + '>Resolve</button>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'<div class="mt-2" data-edit="ticket" style="display:none;">' +
|
||||
'<div class="row g-2">' +
|
||||
'<div class="col-12">' +
|
||||
'<textarea class="form-control form-control-sm" data-field="description" rows="2" placeholder="Description (optional)">' + escapeHtml(t.description || '') + '</textarea>' +
|
||||
'</div>' +
|
||||
'<div class="col-12 d-flex gap-2">' +
|
||||
'<button type="button" class="btn btn-sm btn-primary" data-action="save-ticket" data-id="' + t.id + '">Save</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="cancel-edit" data-id="' + t.id + '">Cancel</button>' +
|
||||
'<div class="small text-muted align-self-center" data-field="status"></div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>';
|
||||
});
|
||||
html += '</div></div>';
|
||||
@ -758,21 +696,34 @@ table.addEventListener('change', function (e) {
|
||||
if (remarks.length) {
|
||||
html += '<div class="mb-2"><strong>Remarks</strong><div class="mt-1">';
|
||||
remarks.forEach(function (r) {
|
||||
var status = r.resolved_at ? 'Resolved' : 'Active';
|
||||
var status2 = r.resolved_at ? 'Resolved' : 'Active';
|
||||
html += '<div class="mb-2 border rounded p-2" data-alert-type="remark" data-id="' + r.id + '">' +
|
||||
'<div class="d-flex align-items-start justify-content-between gap-2">' +
|
||||
'<div class="flex-grow-1 min-w-0">' +
|
||||
'<div class="text-truncate">' +
|
||||
'<span class="me-1" title="Remark">💬</span>' +
|
||||
'<span class="fw-semibold">Remark</span>' +
|
||||
'<span class="ms-2 badge ' + (r.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status + '</span>' +
|
||||
'<span class="ms-2 badge ' + (r.resolved_at ? 'bg-secondary' : 'bg-warning text-dark') + '">' + status2 + '</span>' +
|
||||
'</div>' +
|
||||
(r.body ? ('<div class="small text-muted mt-1">' + escapeHtml(r.body) + '</div>') : '') +
|
||||
'</div>' +
|
||||
'<div class="d-flex gap-1 flex-shrink-0">' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="toggle-edit-remark" data-id="' + r.id + '" ' + (r.resolved_at ? 'disabled' : '') + '>Edit</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-success" data-action="resolve-remark" data-id="' + r.id + '" ' + (r.resolved_at ? 'disabled' : '') + '>Resolve</button>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'<div class="mt-2" data-edit="remark" style="display:none;">' +
|
||||
'<div class="row g-2">' +
|
||||
'<div class="col-12">' +
|
||||
'<textarea class="form-control form-control-sm" data-field="body" rows="2" placeholder="Body (required)">' + escapeHtml(r.body || '') + '</textarea>' +
|
||||
'</div>' +
|
||||
'<div class="col-12 d-flex gap-2">' +
|
||||
'<button type="button" class="btn btn-sm btn-primary" data-action="save-remark" data-id="' + r.id + '">Save</button>' +
|
||||
'<button type="button" class="btn btn-sm btn-outline-secondary" data-action="cancel-edit" data-id="' + r.id + '">Cancel</button>' +
|
||||
'<div class="small text-muted align-self-center" data-field="status"></div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>' +
|
||||
'</div>';
|
||||
});
|
||||
html += '</div></div>';
|
||||
@ -785,29 +736,8 @@ table.addEventListener('change', function (e) {
|
||||
ev.preventDefault();
|
||||
var action = btn.getAttribute('data-action');
|
||||
var id = btn.getAttribute('data-id');
|
||||
if (!action) return;
|
||||
|
||||
if (action === 'copy-ticket') {
|
||||
var code = btn.getAttribute('data-code') || '';
|
||||
if (!code) return;
|
||||
if (navigator.clipboard && navigator.clipboard.writeText) {
|
||||
navigator.clipboard.writeText(code)
|
||||
.then(function () {
|
||||
var original = btn.textContent;
|
||||
btn.textContent = '✓';
|
||||
setTimeout(function () { btn.textContent = original; }, 800);
|
||||
})
|
||||
.catch(function () {
|
||||
// Fallback: select/copy via prompt
|
||||
window.prompt('Copy ticket number:', code);
|
||||
});
|
||||
} else {
|
||||
window.prompt('Copy ticket number:', code);
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
if (!id) return;
|
||||
if (!action || !id) return;
|
||||
var wrapper = btn.closest('[data-alert-type]');
|
||||
|
||||
if (action === 'resolve-ticket') {
|
||||
if (!confirm('Mark ticket as resolved?')) return;
|
||||
@ -819,6 +749,58 @@ table.addEventListener('change', function (e) {
|
||||
apiJson('/api/remarks/' + encodeURIComponent(id) + '/resolve', {method: 'POST', body: '{}'})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) { alert(e.message || 'Failed.'); });
|
||||
} else if (action === 'toggle-edit-ticket') {
|
||||
if (!wrapper) return;
|
||||
var edit = wrapper.querySelector('[data-edit="ticket"]');
|
||||
if (!edit) return;
|
||||
edit.style.display = (edit.style.display === 'none' || !edit.style.display) ? '' : 'none';
|
||||
} else if (action === 'toggle-edit-remark') {
|
||||
if (!wrapper) return;
|
||||
var edit2 = wrapper.querySelector('[data-edit="remark"]');
|
||||
if (!edit2) return;
|
||||
edit2.style.display = (edit2.style.display === 'none' || !edit2.style.display) ? '' : 'none';
|
||||
} else if (action === 'cancel-edit') {
|
||||
if (!wrapper) return;
|
||||
var editAny = wrapper.querySelector('[data-edit]');
|
||||
if (editAny) editAny.style.display = 'none';
|
||||
} else if (action === 'save-ticket') {
|
||||
if (!wrapper) return;
|
||||
var editT = wrapper.querySelector('[data-edit="ticket"]');
|
||||
if (!editT) return;
|
||||
var descEl = editT.querySelector('[data-field="description"]');
|
||||
var statusEl2 = editT.querySelector('[data-field="status"]');
|
||||
var descVal = descEl ? descEl.value : '';
|
||||
if (statusEl2) statusEl2.textContent = 'Saving...';
|
||||
apiJson('/api/tickets/' + encodeURIComponent(id), {
|
||||
method: 'PATCH',
|
||||
body: JSON.stringify({description: descVal})
|
||||
})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) {
|
||||
if (statusEl2) statusEl2.textContent = e.message || 'Failed.';
|
||||
else alert(e.message || 'Failed.');
|
||||
});
|
||||
} else if (action === 'save-remark') {
|
||||
if (!wrapper) return;
|
||||
var editR = wrapper.querySelector('[data-edit="remark"]');
|
||||
if (!editR) return;
|
||||
var bodyEl = editR.querySelector('[data-field="body"]');
|
||||
var statusEl3 = editR.querySelector('[data-field="status"]');
|
||||
var bodyVal = bodyEl ? bodyEl.value : '';
|
||||
if (!bodyVal || !bodyVal.trim()) {
|
||||
if (statusEl3) statusEl3.textContent = 'Body is required.';
|
||||
return;
|
||||
}
|
||||
if (statusEl3) statusEl3.textContent = 'Saving...';
|
||||
apiJson('/api/remarks/' + encodeURIComponent(id), {
|
||||
method: 'PATCH',
|
||||
body: JSON.stringify({body: bodyVal})
|
||||
})
|
||||
.then(function () { loadAlerts(currentRunId); })
|
||||
.catch(function (e) {
|
||||
if (statusEl3) statusEl3.textContent = e.message || 'Failed.';
|
||||
else alert(e.message || 'Failed.');
|
||||
});
|
||||
}
|
||||
});
|
||||
});
|
||||
@ -843,8 +825,8 @@ table.addEventListener('change', function (e) {
|
||||
function bindInlineCreateForms() {
|
||||
var btnTicket = document.getElementById('rcm_ticket_save');
|
||||
var btnRemark = document.getElementById('rcm_remark_save');
|
||||
var tCode = document.getElementById('rcm_ticket_code');
|
||||
var tStatus = document.getElementById('rcm_ticket_status');
|
||||
var tDesc = document.getElementById('rcm_ticket_description');
|
||||
var tStatus = document.getElementById('rcm_ticket_status');
|
||||
var rBody = document.getElementById('rcm_remark_body');
|
||||
var rStatus = document.getElementById('rcm_remark_status');
|
||||
|
||||
@ -856,8 +838,8 @@ var tStatus = document.getElementById('rcm_ticket_status');
|
||||
function setDisabled(disabled) {
|
||||
if (btnTicket) btnTicket.disabled = disabled;
|
||||
if (btnRemark) btnRemark.disabled = disabled;
|
||||
if (tCode) tCode.disabled = disabled;
|
||||
if (rBody) rBody.disabled = disabled;
|
||||
if (tDesc) tDesc.disabled = disabled;
|
||||
if (rBody) rBody.disabled = disabled;
|
||||
}
|
||||
|
||||
window.__rcmSetCreateDisabled = setDisabled;
|
||||
@ -867,25 +849,15 @@ if (rBody) rBody.disabled = disabled;
|
||||
btnTicket.addEventListener('click', function () {
|
||||
if (!currentRunId) { alert('Select a run first.'); return; }
|
||||
clearStatus();
|
||||
var ticket_code = tCode ? (tCode.value || '').trim().toUpperCase() : '';
|
||||
if (!ticket_code) {
|
||||
if (tStatus) tStatus.textContent = 'Ticket number is required.';
|
||||
else alert('Ticket number is required.');
|
||||
return;
|
||||
}
|
||||
if (!/^T\d{8}\.\d{4}$/.test(ticket_code)) {
|
||||
if (tStatus) tStatus.textContent = 'Invalid ticket number format. Expected TYYYYMMDD.####.';
|
||||
else alert('Invalid ticket number format. Expected TYYYYMMDD.####.');
|
||||
return;
|
||||
}
|
||||
var description = tDesc ? tDesc.value : '';
|
||||
if (tStatus) tStatus.textContent = 'Saving...';
|
||||
apiJson('/api/tickets', {
|
||||
method: 'POST',
|
||||
body: JSON.stringify({job_run_id: currentRunId, ticket_code: ticket_code})
|
||||
body: JSON.stringify({job_run_id: currentRunId, description: description})
|
||||
})
|
||||
.then(function () {
|
||||
if (tCode) tCode.value = '';
|
||||
if (tStatus) tStatus.textContent = '';
|
||||
if (tDesc) tDesc.value = '';
|
||||
if (tStatus) tStatus.textContent = '';
|
||||
loadAlerts(currentRunId);
|
||||
})
|
||||
.catch(function (e) {
|
||||
@ -952,16 +924,10 @@ if (tStatus) tStatus.textContent = '';
|
||||
stEl.innerHTML = (d ? ('<span class="status-dot ' + d + '" aria-hidden="true"></span>') : '');
|
||||
}
|
||||
document.getElementById('rcm_remark').textContent = run.remark || '';
|
||||
document.getElementById('rcm_overall_message').textContent = run.overall_message || '';
|
||||
|
||||
currentRunId = run.id || null;
|
||||
if (window.__rcmClearCreateStatus) window.__rcmClearCreateStatus();
|
||||
if (window.__rcmSetCreateDisabled) window.__rcmSetCreateDisabled(!currentRunId);
|
||||
if (btnMarkSuccessOverride) {
|
||||
var _rs = (run.status || '').toString().toLowerCase();
|
||||
var _canOverride = !!currentRunId && !run.missed && (_rs.indexOf('override') === -1) && (_rs.indexOf('success') === -1);
|
||||
btnMarkSuccessOverride.disabled = !_canOverride;
|
||||
}
|
||||
loadAlerts(currentRunId);
|
||||
|
||||
var mail = run.mail || null;
|
||||
@ -994,7 +960,7 @@ if (tStatus) tStatus.textContent = '';
|
||||
var tbody = document.querySelector('#rcm_objects_table tbody');
|
||||
if (tbody) {
|
||||
tbody.innerHTML = '';
|
||||
sortObjects(run.objects || []).forEach(function (obj) {
|
||||
(run.objects || []).forEach(function (obj) {
|
||||
var tr = document.createElement('tr');
|
||||
|
||||
var tdName = document.createElement('td');
|
||||
@ -1025,7 +991,6 @@ if (tStatus) tStatus.textContent = '';
|
||||
currentJobId = jobId;
|
||||
|
||||
if (btnMarkAllReviewed) btnMarkAllReviewed.disabled = true;
|
||||
if (btnMarkSuccessOverride) btnMarkSuccessOverride.disabled = true;
|
||||
|
||||
var modalEl = document.getElementById('runChecksModal');
|
||||
var modal = bootstrap.Modal.getOrCreateInstance(modalEl);
|
||||
@ -1196,4 +1161,4 @@ if (tStatus) tStatus.textContent = '';
|
||||
updateButtons();
|
||||
})();
|
||||
</script>
|
||||
{% endblock %}
|
||||
{% endblock %}
|
||||
|
||||
@ -160,30 +160,8 @@
|
||||
{% if users %}
|
||||
{% for user in users %}
|
||||
<tr>
|
||||
{% set is_last_admin = ('admin' in user.roles and (admin_users_count or 0) <= 1) %}
|
||||
<td>{{ user.username }}</td>
|
||||
<td>
|
||||
<form method="post" action="{{ url_for('main.settings_users_update_roles', user_id=user.id) }}" class="d-flex flex-wrap gap-2 align-items-center">
|
||||
<div class="form-check form-check-inline m-0">
|
||||
<input class="form-check-input" type="checkbox" id="role_admin_{{ user.id }}" name="roles" value="admin" {% if 'admin' in user.roles %}checked{% endif %} {% if is_last_admin %}disabled title="Cannot remove admin from the last admin account"{% endif %} />
|
||||
<label class="form-check-label" for="role_admin_{{ user.id }}">Admin</label>
|
||||
</div>
|
||||
<div class="form-check form-check-inline m-0">
|
||||
<input class="form-check-input" type="checkbox" id="role_operator_{{ user.id }}" name="roles" value="operator" {% if 'operator' in user.roles %}checked{% endif %} />
|
||||
<label class="form-check-label" for="role_operator_{{ user.id }}">Operator</label>
|
||||
</div>
|
||||
<div class="form-check form-check-inline m-0">
|
||||
<input class="form-check-input" type="checkbox" id="role_reporter_{{ user.id }}" name="roles" value="reporter" {% if 'reporter' in user.roles %}checked{% endif %} />
|
||||
<label class="form-check-label" for="role_reporter_{{ user.id }}">Reporter</label>
|
||||
</div>
|
||||
<div class="form-check form-check-inline m-0">
|
||||
<input class="form-check-input" type="checkbox" id="role_viewer_{{ user.id }}" name="roles" value="viewer" {% if 'viewer' in user.roles %}checked{% endif %} />
|
||||
<label class="form-check-label" for="role_viewer_{{ user.id }}">Viewer</label>
|
||||
</div>
|
||||
<button type="submit" class="btn btn-sm btn-outline-primary">Save</button>
|
||||
</form>
|
||||
<div class="text-muted small mt-1">Current: {{ (user.role or '')|replace(',', ', ') }}</div>
|
||||
</td>
|
||||
<td>{{ (user.role or '')|replace(',', ', ') }}</td>
|
||||
<td>
|
||||
<div class="d-flex flex-wrap gap-2">
|
||||
<form method="post" action="{{ url_for('main.settings_users_reset_password', user_id=user.id) }}" class="d-inline">
|
||||
@ -192,6 +170,7 @@
|
||||
<button type="submit" class="btn btn-outline-secondary">Reset</button>
|
||||
</div>
|
||||
</form>
|
||||
{% set is_last_admin = (user.role == 'admin' and (users | selectattr('role', 'equalto', 'admin') | list | length) <= 1) %}
|
||||
<form method="post" action="{{ url_for('main.settings_users_delete', user_id=user.id) }}" class="d-inline">
|
||||
<button type="submit" class="btn btn-sm btn-outline-danger" {% if is_last_admin %}disabled title="Cannot delete the last admin account"{% endif %}>Delete</button>
|
||||
</form>
|
||||
|
||||
@ -17,16 +17,19 @@
|
||||
{% endif %}
|
||||
</div>
|
||||
|
||||
<div class="row g-3">
|
||||
<form method="post" class="row g-3"> <div class="col-12">
|
||||
<label class="form-label">Description</label>
|
||||
<textarea class="form-control" name="description" rows="5">{{ ticket.description or '' }}</textarea>
|
||||
</div>
|
||||
{% if active_role in ['admin','operator'] %}
|
||||
<div class="col-12">
|
||||
|
||||
<button class="btn btn-primary" type="submit">Save</button>
|
||||
{% if not ticket.resolved_at %}
|
||||
<button class="btn btn-outline-success" type="button" onclick="if(confirm('Mark ticket as resolved?')){fetch('{{ url_for('main.api_ticket_resolve', ticket_id=ticket.id) }}',{method:'POST'}).then(()=>location.reload());}">Resolve</button>
|
||||
{% endif %}
|
||||
</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
</form>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
|
||||
@ -45,7 +45,7 @@
|
||||
|
||||
<div class="col-auto" style="min-width: 260px;">
|
||||
<label class="form-label" for="flt_q">Search</label>
|
||||
<input class="form-control" id="flt_q" name="q" value="{{ q }}" placeholder="ticket code / job" />
|
||||
<input class="form-control" id="flt_q" name="q" value="{{ q }}" placeholder="ticket code / description / job" />
|
||||
</div>
|
||||
|
||||
<div class="col-auto">
|
||||
@ -89,7 +89,7 @@
|
||||
<td class="text-nowrap">{{ t.start_date }}</td>
|
||||
<td class="text-nowrap">{{ t.resolved_at }}</td>
|
||||
<td class="text-nowrap">
|
||||
<a class="btn btn-sm btn-outline-primary" href="{{ url_for('main.ticket_detail', ticket_id=t.id) }}">View</a>
|
||||
<a class="btn btn-sm btn-outline-primary" href="{{ url_for('main.ticket_detail', ticket_id=t.id) }}">View / Edit</a>
|
||||
{% if t.active and t.job_id %}
|
||||
<a class="btn btn-sm btn-outline-secondary ms-1" href="{{ url_for('main.job_detail', job_id=t.job_id) }}">Job page</a>
|
||||
{% endif %}
|
||||
@ -144,7 +144,7 @@
|
||||
<td class="text-nowrap">{{ r.start_date }}</td>
|
||||
<td class="text-nowrap">{{ r.resolved_at }}</td>
|
||||
<td class="text-nowrap">
|
||||
<a class="btn btn-sm btn-outline-primary" href="{{ url_for('main.remark_detail', remark_id=r.id) }}">View</a>
|
||||
<a class="btn btn-sm btn-outline-primary" href="{{ url_for('main.remark_detail', remark_id=r.id) }}">View / Edit</a>
|
||||
{% if r.active and r.job_id %}
|
||||
<a class="btn btn-sm btn-outline-secondary ms-1" href="{{ url_for('main.job_detail', job_id=r.job_id) }}">Job page</a>
|
||||
{% endif %}
|
||||
|
||||
@ -1,299 +1,6 @@
|
||||
|
||||
***
|
||||
|
||||
## v0.1.21
|
||||
|
||||
This release focuses on improving correctness, consistency, and access control across core application workflows, with particular attention to changelog rendering, browser-specific mail readability, Run Checks visibility, role-based access restrictions, override flexibility, and VSPC object linking reliability. The goal is to ensure predictable behavior, clearer diagnostics, and safer administration across both day-to-day operations and complex multi-entity reports.
|
||||
|
||||
### Changelog Rendering and Documentation Accuracy
|
||||
|
||||
- Updated the Changelog route to render remote Markdown content instead of plain text.
|
||||
- Enabled full Markdown parsing so headings, lists, links, and code blocks are displayed correctly.
|
||||
- Ensured the changelog always fetches the latest version directly from the source repository at request time.
|
||||
- Removed legacy plain-text rendering to prevent loss of structure and formatting.
|
||||
|
||||
### Mail Rendering and Browser Compatibility
|
||||
|
||||
- Forced a light color scheme for embedded mail content to prevent Microsoft Edge from applying automatic dark mode styling.
|
||||
- Added explicit `color-scheme` and `forced-color-adjust` rules so original mail CSS is respected.
|
||||
- Ensured consistent mail readability across Edge and Firefox.
|
||||
- Applied these fixes consistently across Inbox, Deleted Inbox, Job Details, Run Checks, Daily Jobs, and Admin All Mail views.
|
||||
|
||||
### Run Checks Visibility and Consistency
|
||||
|
||||
- Added support for displaying the overall remark (overall_message) directly on the Run Checks page.
|
||||
- Ensured consistency between Run Checks and Job Details, where the overall remark was already available.
|
||||
- Improved operator visibility of high-level run context without requiring navigation to job details.
|
||||
|
||||
### Initial Setup and User Existence Safeguards
|
||||
|
||||
- Fixed an incorrect redirect to the “Initial admin setup” page when users already exist.
|
||||
- Changed setup detection logic from “admin user exists” to “any user exists”.
|
||||
- Ensured existing environments always show the login page instead of allowing a new initial admin to be created.
|
||||
- Prevented direct access to the initial setup route when at least one user is present.
|
||||
|
||||
### Role-Based Access Control and Menu Restrictions
|
||||
|
||||
- Restricted the Reporter role to only access Dashboard, Reports, Changelog, and Feedback.
|
||||
- Updated menu rendering to fully hide unauthorized menu items for Reporter users.
|
||||
- Adjusted route access to ensure Feedback pages remain accessible for the Reporter role.
|
||||
- Improved overall consistency between visible navigation and backend access rules.
|
||||
|
||||
### Override Matching Flexibility and Maintainability
|
||||
|
||||
- Added configurable error text matching modes for overrides: contains, exact, starts with, and ends with.
|
||||
- Updated override evaluation logic to apply the selected match mode across run remarks and object error messages.
|
||||
- Extended the overrides UI with a match type selector and improved edit support for existing overrides.
|
||||
- Added a database migration to create and backfill the `overrides.match_error_mode` field for existing records.
|
||||
|
||||
### Job Deletion Stability
|
||||
|
||||
- Fixed an error that occurred during job deletion.
|
||||
- Corrected backend deletion logic to prevent runtime exceptions.
|
||||
- Ensured related records are handled safely to avoid constraint or reference errors during removal.
|
||||
|
||||
### VSPC Object Linking and Normalization
|
||||
|
||||
- Fixed VSPC company name normalization so detection and object prefixing behave consistently.
|
||||
- Ensured filtered object persistence respects the UNIQUE(customer_id, object_name) constraint.
|
||||
- Correctly update `last_seen` timestamps for existing objects.
|
||||
- Added automatic object persistence routing for VSPC per-company runs, ensuring objects are linked to the correct customer and job.
|
||||
- Improved auto-approval for VSPC Active Alarms summaries with per-company run creation and case-insensitive object matching.
|
||||
- Added best-effort retroactive processing to automatically link older inbox messages once company mappings are approved.
|
||||
|
||||
### VSPC Normalization Bug Fixes and Backward Compatibility
|
||||
|
||||
- Removed duplicate definitions of VSPC Active Alarms company extraction logic that caused inconsistent normalization.
|
||||
- Ensured a single, consistent normalization path is used when creating jobs and linking objects.
|
||||
- Improved object linking so real objects (e.g. HV01, USB Disk) are reliably associated with their jobs.
|
||||
- Restored automatic re-linking for both new and historical VSPC mails.
|
||||
- Added backward-compatible matching to prevent existing VSPC jobs from breaking due to earlier inconsistent company naming.
|
||||
|
||||
---
|
||||
|
||||
## v0.1.20
|
||||
|
||||
This release delivers a comprehensive set of improvements focused on parser correctness, data consistency, and clearer operator workflows across Inbox handling, Run Checks, and administrative tooling. The main goal of these changes is to ensure that backup notifications are parsed reliably, presented consistently, and handled through predictable and auditable workflows, even for complex or multi-entity reports.
|
||||
|
||||
### Mail Parsing and Data Integrity
|
||||
|
||||
- Fixed Veeam Backup for Microsoft 365 parsing where the overall summary message was not consistently stored.
|
||||
- Improved extraction of overall detail messages so permission and role warnings are reliably captured.
|
||||
- Ensured the extracted overall message is always available across Job Details, Run Checks, and reporting views.
|
||||
- Added decoding of HTML entities in parsed object fields (name, type, status, error message) before storage, ensuring characters such as ampersands are displayed correctly.
|
||||
- Improved robustness of parsing logic to prevent partial or misleading data from being stored when mails contain mixed or malformed content.
|
||||
|
||||
### Object Classification and Sorting
|
||||
|
||||
- Updated object list sorting to improve readability and prioritization.
|
||||
- Objects are now grouped by severity in a fixed order: Errors first, then Warnings, followed by all other statuses.
|
||||
- Within each severity group, objects are sorted alphabetically (A–Z).
|
||||
- Applied the same sorting logic consistently across Inbox, Job Details, Run Checks, Daily Jobs, and the Admin All Mail view.
|
||||
- Improved overall run status determination by reliably deriving the worst detected object state.
|
||||
|
||||
### Parsers Overview and Maintainability
|
||||
|
||||
- Refactored the Parsers overview page to use the central parser registry instead of a static, hardcoded list.
|
||||
- All available parsers are now displayed automatically, ensuring the page stays in sync as parsers are added or removed.
|
||||
- Removed hardcoded parser definitions from templates to improve long-term maintainability.
|
||||
- Fixed a startup crash in the parsers route caused by an invalid absolute import by switching to a package-relative import.
|
||||
- Prevented Gunicorn worker boot failures and Bad Gateway errors during application initialization.
|
||||
|
||||
### User Management and Feedback Handling
|
||||
|
||||
- Added support for editing user roles directly from the User Management interface.
|
||||
- Implemented backend logic to update existing role assignments without requiring user deletion.
|
||||
- Ensured role changes are applied immediately and reflected correctly in permissions and access control.
|
||||
- Updated feedback listings to show only Open items by default.
|
||||
- Ensured Resolved items are always sorted to the bottom when viewing all feedback.
|
||||
- Preserved existing filtering, searching, and user-controlled sorting behavior.
|
||||
|
||||
### UI Improvements and Usability Enhancements
|
||||
|
||||
- Introduced reusable ellipsis handling for long detail fields to prevent layout overlap.
|
||||
- Added click-to-expand behavior for truncated fields, with double-click support to expand and select all text.
|
||||
- Added automatic tooltips showing the full value when a field is truncated.
|
||||
- Removed the redundant “Objects” heading above objects tables to reduce visual clutter.
|
||||
- Applied truncation and expansion behavior consistently across Inbox, Deleted Mail, Run Checks, Daily Jobs, Job Detail views, and Admin All Mail.
|
||||
- Reset expanded ellipsis fields when Bootstrap modals or offcanvas components are opened or closed to prevent state leakage.
|
||||
- Fixed layout issues where the Objects table could overlap mail content in the Run Checks popup.
|
||||
|
||||
### Veeam Cloud Connect and VSPC Parsing
|
||||
|
||||
- Improved the Veeam Cloud Connect Report parser by combining User and Repository Name into a single object identifier.
|
||||
- Excluded “TOTAL” rows from object processing.
|
||||
- Correctly classified red rows as Errors and yellow/orange rows as Warnings.
|
||||
- Ensured overall status is set to Error when one or more objects are in error state.
|
||||
- Added support for Veeam Service Provider Console daily alarm summary emails.
|
||||
- Implemented per-company object aggregation and derived overall status from the worst detected state.
|
||||
- Improved detection of VSPC Active Alarms emails to prevent incorrect fallback to other Veeam parsers.
|
||||
- Fixed a SyntaxError in the VSPC parser that caused application startup failures.
|
||||
|
||||
### VSPC Company Mapping Workflow
|
||||
|
||||
- Introduced a dedicated company-mapping popup for VSPC Active Alarms summary reports.
|
||||
- Enabled manual mapping of companies found in mails to existing customers.
|
||||
- Implemented per-company job and run creation using the format “Active alarms summary | <Company>”.
|
||||
- Disabled the standard approval flow for this report type and replaced it with a dedicated mapping workflow.
|
||||
- Required all detected companies to be mapped before full approval, while still allowing partial approvals.
|
||||
- Prevented duplicate run creation on repeated approvals.
|
||||
- Improved visibility and usability of the mapping popup with scroll support for large company lists.
|
||||
- Ensured only alarms belonging to the selected company are attached to the corresponding run.
|
||||
|
||||
### NTFS Auditing and Synology ABB Enhancements
|
||||
|
||||
- Added full parser support for NTFS Auditing reports.
|
||||
- Improved hostname and FQDN extraction from subject lines, supporting multiple subject formats and prefixes.
|
||||
- Ensured consistent job name generation as “<hostname> file audits”.
|
||||
- Set overall status to Warning when detected change counts are greater than zero.
|
||||
- Improved Synology Active Backup for Business parsing to detect partially completed jobs as Warning.
|
||||
- Added support for localized completion messages and subject variants.
|
||||
- Improved per-device object extraction and ensured specific device statuses take precedence over generic listings.
|
||||
|
||||
### Workflow Simplification and Cleanup
|
||||
|
||||
- Removed the “Mark success (override)” button from the Run Checks popup.
|
||||
- Prevented creation of unintended overrides when marking individual runs as successful.
|
||||
- Simplified override handling so Run Checks actions no longer affect override administration.
|
||||
- Ensured firmware update notifications (QNAP) are treated as informational warnings and excluded from missing-run detection and reporting.
|
||||
|
||||
---
|
||||
|
||||
## v0.1.19
|
||||
This release delivers a broad set of improvements focused on reliability, transparency, and operational control across mail processing, administrative auditing, and Run Checks workflows. The changes aim to make message handling more robust, provide better insight for administrators, and give operators clearer and more flexible control when reviewing backup runs.
|
||||
|
||||
### Mail Import Reliability and Data Integrity
|
||||
- Updated the mail import flow so messages are only moved to the processed folder after a successful database store and commit.
|
||||
- Prevented Graph emails from being moved when parsing, storing, or committing data fails, ensuring no messages are lost due to partial failures.
|
||||
- Added explicit commit and rollback handling to guarantee database consistency before any mail state changes occur.
|
||||
- Improved logging around import, commit, and rollback failures to make skipped or retried mails easier to trace and troubleshoot.
|
||||
|
||||
### Administrative Mail Auditing and Visibility
|
||||
- Introduced an admin-only “All Mail” audit page that provides a complete overview of all received mail messages.
|
||||
- Implemented pagination with a fixed page size of 50 items to ensure consistent performance and predictable navigation.
|
||||
- Added always-visible search filters that can be combined using AND logic, including From, Subject, Backup, Type, Job name, and a received date/time range.
|
||||
- Added an “Only unlinked” filter to quickly identify messages that are not associated with any job.
|
||||
- Reused the existing Inbox message detail modal to allow consistent inspection of messages from the All Mail page.
|
||||
- Added a dedicated navigation entry so administrators can easily access the All Mail audit view.
|
||||
- Fixed modal opening behavior in the All Mail page to fully align click handling and popups with the Inbox implementation.
|
||||
|
||||
### Inbox and Mail Body Rendering Improvements
|
||||
- Treated whitespace-only email bodies as empty during import so HTML report attachments can be extracted and displayed correctly.
|
||||
- Added legacy fallback logic in the Inbox message detail API to extract the first HTML attachment from stored EML files when bodies are empty or invalid.
|
||||
- Improved iframe rendering in the Inbox so full HTML documents (commonly used for report attachments) are rendered directly instead of being wrapped.
|
||||
- Added detection for “effectively empty” HTML bodies, such as empty Graph-generated HTML skeletons.
|
||||
- Ensured that both newly imported and already-stored messages can dynamically fall back to EML attachment extraction without requiring a reset.
|
||||
|
||||
### Run Checks Usability and Control
|
||||
- Added a copy-to-clipboard icon next to ticket numbers in the Run Checks popup to quickly copy only the ticket code.
|
||||
- Prevented accidental selection of appended status text when copying ticket numbers.
|
||||
- Introduced a manual “Success (override)” action that allows Operators and Admins to mark a run as successful even if it originally failed or produced warnings.
|
||||
- Implemented backend support to persist the override state without modifying the original run data.
|
||||
- Updated UI indicators so overridden runs are clearly shown with a blue success status.
|
||||
- Ensured overrides apply only to the selected run and do not affect historical or related runs.
|
||||
- Improved Run Checks mail rendering by falling back to text bodies when HTML bodies are missing, matching Inbox and All Mail behavior.
|
||||
- Added support for extracting HTML content from stored EML files when both HTML and text bodies are unavailable.
|
||||
- Ensured plain-text emails are safely rendered using preformatted HTML to preserve readability.
|
||||
|
||||
### Customer, Ticket, and Scope Cleanup
|
||||
- Updated customer deletion logic to allow removal of customers even when tickets or remarks are linked.
|
||||
- Added explicit cleanup of related TicketScope and RemarkScope records prior to customer deletion.
|
||||
- Ensured jobs linked to a deleted customer are safely unassigned to prevent foreign key constraint errors.
|
||||
- Eliminated deletion failures caused by lingering ticket or remark relationships.
|
||||
|
||||
### Parser Enhancements and Informational Messages
|
||||
- Added parser support for 3CX SSL Certificate notification emails.
|
||||
- Classified these messages as Backup: 3CX with Type: SSL Certificate.
|
||||
- Parsed and displayed certificate information in the Run Checks popup.
|
||||
- Stored these messages as successful runs so certificate status can be tracked over time.
|
||||
- Added detection for Synology DSM automatic update cancellation messages in both Dutch and English.
|
||||
- Classified Synology Updates messages as informational and set their overall status to Warning.
|
||||
- Excluded Synology Updates informational messages from scheduling logic and reporting output.
|
||||
|
||||
### UI Layout and Status Accuracy Improvements
|
||||
- Moved the Details section above the email body in both Inbox and Job Details popups to improve readability.
|
||||
- Avoided long detail texts being constrained to narrow side columns.
|
||||
- Adjusted missed run detection to include a ±1 hour grace window around scheduled run times.
|
||||
- Prevented runs that arrive shortly after the scheduled time from being temporarily marked as Missed.
|
||||
- Ensured the Missed status is only applied after the full grace window has elapsed, reducing false alerts in Run Checks and Daily Jobs views.
|
||||
|
||||
---
|
||||
|
||||
## v0.1.18
|
||||
|
||||
This release focuses on improving ticket reuse, scoping, and visibility across jobs, runs, and history views to ensure consistent and flexible ticket handling.
|
||||
|
||||
### Ticket Linking and Reuse
|
||||
- Updated ticket linking logic to allow the same existing ticket number to be associated with multiple jobs and job runs.
|
||||
- Prevented duplicate ticket creation errors when reusing an existing ticket code.
|
||||
- Ensured existing tickets are consistently reused and linked instead of being rejected when already present in the system.
|
||||
|
||||
### Ticket Scope and Resolution
|
||||
- Fixed missing ticket number display in job and run popups by always creating or reusing a ticket scope when linking an existing ticket to a job.
|
||||
- Updated ticket resolution logic to support per-job resolution when resolving tickets from a job or run context.
|
||||
- Ensured resolving a ticket from the central Tickets view resolves the ticket globally and closes all associated job scopes.
|
||||
- Updated ticket active status determination to be based on open job scopes, allowing the same ticket number to remain active for other jobs when applicable.
|
||||
|
||||
### Job History – Tickets and Remarks
|
||||
- Added a Tickets and Remarks section to the Job History mail popup.
|
||||
- Aligned ticket handling in Job History with the existing Run Checks popup behavior.
|
||||
- Enabled viewing of active and resolved tickets and remarks per job run.
|
||||
- Added support for creating new tickets and remarks directly from the Job History popup.
|
||||
- Enabled resolving tickets and remarks directly from the Job History popup.
|
||||
- Ensured tickets and remarks are correctly scoped to the selected run (run_id).
|
||||
|
||||
---
|
||||
|
||||
## v0.1.17
|
||||
|
||||
### Release Summary
|
||||
|
||||
This release focuses on improving job normalization, ticket and remark handling, UI usability, and the robustness of run and object detection across the platform.
|
||||
|
||||
### Job normalization and aggregation
|
||||
- Veeam job names are now normalized to prevent duplicates:
|
||||
- Jobs with “(Combined)” and “(Full)” suffixes are merged with their base job names.
|
||||
- Ensures accurate aggregation, reporting, and statistics for Veeam Backup and Microsoft 365 jobs.
|
||||
- Added support for archiving inactive jobs while keeping all historical runs fully included in reports.
|
||||
|
||||
### Inbox and bulk operations
|
||||
- Introduced multi-select inbox functionality for Operator and Admin roles.
|
||||
- Added a bulk “Delete selected” action with validation, counters, and admin audit logging.
|
||||
|
||||
### Jobs UI and navigation
|
||||
- Restored row-click navigation on the Jobs page.
|
||||
- Moved the Archive action from the Jobs table to the Job Details page for consistency.
|
||||
- Improved layout and behavior of job run popups, ensuring objects are visible, correctly rendered, and consistently sorted.
|
||||
|
||||
### Tickets and remarks
|
||||
- Ticket creation now always uses a user-provided ticket code with strict format and uniqueness validation.
|
||||
- Editing of tickets and remarks has been fully disabled; items must be resolved and recreated instead.
|
||||
- Removed ticket description fields from creation and detail views to prevent inconsistent data.
|
||||
- Fixed backend indentation errors that previously caused startup and Bad Gateway failures.
|
||||
|
||||
### Customer deletion stability
|
||||
- Fixed foreign key constraint issues when deleting customers.
|
||||
- Customer deletion now safely unlinks jobs while preserving historical job and run data.
|
||||
- Enforced cascading deletes where appropriate to prevent integrity errors.
|
||||
|
||||
### Feedback handling
|
||||
- Users can now reply directly to Feedback items while they are in the “Open” state.
|
||||
- Replies are stored for audit and history tracking.
|
||||
|
||||
### Veeam parser improvements
|
||||
- Configuration Backup parser now correctly captures multi-line overall warning messages.
|
||||
- Improved date parsing to support formats without leading zeros.
|
||||
- Microsoft 365 parser now always persists overall warning/info messages, even on successful runs.
|
||||
|
||||
### Run checks and missed run detection
|
||||
- Improved weekly and monthly schedule inference to reduce false positives.
|
||||
- Monthly jobs are now detected and marked as missed on the correct expected date.
|
||||
- Added fallback mechanisms for loading run objects in Run Checks to support legacy and transitional data.
|
||||
|
||||
Overall, this release significantly improves data consistency, usability, and reliability across jobs, tickets, inbox management, and run analysis.
|
||||
|
||||
---
|
||||
|
||||
================================================================================================================================================
|
||||
## v0.1.16
|
||||
|
||||
This release significantly expands and stabilizes the reporting functionality, focusing on configurability, correctness, and richer output formats.
|
||||
|
||||
@ -1 +1 @@
|
||||
v0.1.20
|
||||
v0.1.16
|
||||
|
||||
Loading…
Reference in New Issue
Block a user