From 3e9bb0e065a191a166b82e8d0cc168d97ec13463 Mon Sep 17 00:00:00 2001 From: Ivo Oskamp Date: Fri, 9 Jan 2026 13:01:06 +0100 Subject: [PATCH] Auto-commit local changes before build (2026-01-09 13:01:06) --- .last-branch | 2 +- .../backupchecks/src/backend/app/main/routes_feedback.py | 8 +++++--- docs/changelog.md | 7 +++++++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.last-branch b/.last-branch index 393b1d3..0a5db20 100644 --- a/.last-branch +++ b/.last-branch @@ -1 +1 @@ -v20260109-06-user-management-edit-roles +v20260109-07-feedback-open-default-resolved-sort diff --git a/containers/backupchecks/src/backend/app/main/routes_feedback.py b/containers/backupchecks/src/backend/app/main/routes_feedback.py index 2dbc85e..256deb0 100644 --- a/containers/backupchecks/src/backend/app/main/routes_feedback.py +++ b/containers/backupchecks/src/backend/app/main/routes_feedback.py @@ -10,9 +10,8 @@ def feedback_page(): if item_type not in ("", "bug", "feature"): item_type = "" - # Default to showing both open and resolved items. Resolved items should remain - # visible for all users until an admin deletes them. - status = (request.args.get("status") or "all").strip().lower() + # Default to showing only open items. Users can still switch to Resolved or All via the filter. + status = (request.args.get("status") or "open").strip().lower() if status not in ("open", "resolved", "all"): status = "all" @@ -46,6 +45,9 @@ def feedback_page(): else: order_sql = "vote_count DESC, fi.created_at DESC" + # Always keep resolved items at the bottom when mixing statuses. + order_sql = "CASE WHEN fi.status = 'resolved' THEN 1 ELSE 0 END, " + order_sql + sql = text( f""" SELECT diff --git a/docs/changelog.md b/docs/changelog.md index 6fd414a..ac8cc2b 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -46,6 +46,13 @@ - Updated validation to ensure role changes are applied immediately and consistently. - Ensured role updates are reflected correctly in permissions and access control. +--- + +## v20260109-07-feedback-open-default-resolved-sort + +- Updated feedback listing to show only Open items by default. +- Adjusted sorting logic so Resolved items are always placed at the bottom when viewing all items. +- Preserved existing filtering, searching, and user-controlled sorting behavior. ================================================================================================================================================ ## v0.1.19 This release delivers a broad set of improvements focused on reliability, transparency, and operational control across mail processing, administrative auditing, and Run Checks workflows. The changes aim to make message handling more robust, provide better insight for administrators, and give operators clearer and more flexible control when reviewing backup runs. -- 2.45.2